Skip to content

Comments

[WEB-2308] fix: description editor loader on issue modal when editing sub issue from another project.#5625

Merged
pushya22 merged 2 commits intopreviewfrom
fix/description-editor-loader
Sep 18, 2024
Merged

[WEB-2308] fix: description editor loader on issue modal when editing sub issue from another project.#5625
pushya22 merged 2 commits intopreviewfrom
fix/description-editor-loader

Conversation

@prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Sep 17, 2024

Issue link: WEB-2308

Summary by CodeRabbit

  • New Features

    • Improved handling of project identification in the issue creation and update modal, enhancing flexibility and robustness.
  • Bug Fixes

    • Ensured that the modal can now correctly derive the project ID from either the data or router parameters, preventing issues when data is unavailable.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in the CreateUpdateIssueModalBase component focus on how the projectId is determined. The original implementation directly used useParams() to extract projectId, while the updated approach introduces a new variable, routerProjectId, to store this value. The projectId is now derived from either data?.project_id or routerProjectId, allowing for a fallback mechanism when data is unavailable.

Changes

File Path Change Summary
web/core/components/issues/issue-modal/base.tsx Modified the derivation of projectId to use data?.project_id ?? routerProjectId?.toString() instead of direct extraction from useParams().

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • rahulramesha

Poem

In the land of code where rabbits play,
A change was made to brighten the day.
With project IDs now flexibly found,
Our modal hops high, leaping off the ground!
So here’s to the tweaks, both clever and bright,
Let’s code and create, from morning till night! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@prateekshourya29 prateekshourya29 changed the title [WEB-2308] fix: description editor loader on issue modal when edition sub issue from another project. [WEB-2308] fix: description editor loader on issue modal when editing sub issue from another project. Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants