[WEB-3139] fix: sub-issue visibility

[anmolsinghbhatia]

Description

This PR resolves the visibility bug for sub-issues that occurs during the initial load.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Improvement (change that would cause existing functionality to not work as expected)

References

[WEB-3139]

Summary by CodeRabbit

• Refactor
  • Updated the way useIssueDetail hook is called in issue-related components
  • Simplified function retrieval by removing issueServiceType parameter in some hook calls
  • Maintained existing functionality while adjusting function access methods

[coderabbitai]

Walkthrough

The pull request involves modifications to how the useIssueDetail hook is used in two components related to sub-issues. The primary change is separating the retrieval of different functions from the hook, specifically fetchSubIssues and removeSubIssue. In the helper.tsx and issue-list-item.tsx files, the hook is now called with different parameters or without parameters, changing how issue-related functions are accessed while maintaining the overall component functionality.

Changes

File	Change Summary
web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx	Separated fetchSubIssues and removeSubIssue hook calls, removing issueServiceType from fetchSubIssues retrieval
web/core/components/issues/sub-issues/issue-list-item.tsx	Modified useIssueDetail hook call to remove issueServiceType, simplifying function retrieval

Possibly related PRs

• [WEB-2308] fix: description editor loader on issue modal when editing sub issue from another project. #5625: Modifies useIssueDetail hook in IssueListItem component similarly
• [WEB-2859] fix: sub-issue collapsible visibility #6259: Enhances error handling in sub-issues fetching function

Suggested labels

🐛bug

Suggested reviewers

• sriramveeraghanta
• rahulramesha

Poem

🐰 Hop, hop, through the code we go,
Refactoring hooks with a gentle flow
Sub-issues dancing, parameters light
Simplifying calls with rabbit delight!
Clean and crisp, our changes take flight 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx (1)

40-41: Consider consolidating hook calls to optimize performance.

Splitting useIssueDetail into multiple calls could lead to:

• Multiple re-renders due to separate subscriptions
• Potential race conditions in state updates
• Increased memory usage from multiple hook instances

Consider consolidating the hooks:

-  const { fetchSubIssues } = useIssueDetail();
-  const { removeSubIssue } = useIssueDetail(issueServiceType);
+  const { fetchSubIssues, removeSubIssue } = useIssueDetail(issueServiceType);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea0772 and 1fed423.

📒 Files selected for processing (2)

• web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx (1 hunks)
• web/core/components/issues/sub-issues/issue-list-item.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

web/core/components/issues/sub-issues/issue-list-item.tsx (2)

Line range hint 123-133: LGTM! Loading state handling looks good.

The implementation properly manages the loading state during sub-issue fetching:

1. Shows loader while fetching
2. Updates visibility after fetch completion
3. Handles race conditions by clearing loader state

This should fix the visibility bug during the initial loading phase.

---

60-62: Verify consistent hook usage across components.

The separation of useIssueDetail calls follows the same pattern as in helper.tsx, but there's an inconsistency in how getIssueById is accessed. This could lead to confusion about when to use the hook with or without issueServiceType.

Let's check if this pattern is consistent across the codebase:

✅ Verification successful

The hook usage pattern is consistent with the codebase design

The separation of useIssueDetail calls follows a deliberate pattern where sub-issue operations use the hook without parameters, while core issue operations use it with issueServiceType. This is consistent across the codebase and appears to be an intentional design choice to maintain separate states for issues and sub-issues.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for all useIssueDetail hook usages
rg "useIssueDetail\(" -A 3

Length of output: 51092