Skip to content

[WEB-3362] fix: create sub work item operation#6603

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub-work-item
Feb 13, 2025
Merged

[WEB-3362] fix: create sub work item operation#6603
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub-work-item

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 13, 2025

Description

This PR includes fix for add sub work item operation.

Type of Change

  • Bug fix

References

[WEB-3362]

Summary by CodeRabbit

  • Bug Fixes
    • Improved sub-issue association to ensure that when sub-issues are created or updated, they are reliably linked to their correct parent issue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

Walkthrough

This pull request modifies how sub-issues are associated with their parent issues. In both the IssueDetailWidgetModals and SubIssuesRoot components, the function calls to add a sub-issue have been updated to use the _issue.parent_id property instead of using a locally provided identifier (issueId or parentIssueId). The change ensures that the correct parent issue is referenced during sub-issue creation. No exported or public entity declarations were altered.

Changes

File(s) Change Summary
web/core/components/issues/…/issue-detail-widget-modals.tsx
web/core/components/issues/…/root.tsx
Updated calls to addSubIssue to use _issue.parent_id instead of issueId or parentIssueId for sub-issue association.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as Component
    participant S as SubIssueOperations
    U->>C: Submit modal form
    C->>S: addSubIssue(workspaceSlug, projectId, _issue.parent_id, [_issue.id])
    S-->>C: Return result
Loading

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • rahulramesha

Poem

Hopping through lines of code with glee,
I update IDs to fix the key.
No more mix-ups in issue trees,
With _issue.parent_id, bugs take their leave.
A bunny's cheer in every decree! 🐰🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b88ae11 and 92cdc4e.

📒 Files selected for processing (2)
  • web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx (1 hunks)
  • web/core/components/issues/sub-issues/root.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (2)
web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx (1)

83-87: LGTM! Bug fix for sub-work item creation.

The change correctly uses _issue.parent_id instead of issueId when adding a sub-issue, ensuring the proper parent-child relationship is established.

web/core/components/issues/sub-issues/root.tsx (1)

466-470: LGTM! Consistent fix for sub-work item creation.

The change correctly uses _issue.parent_id instead of parentIssueId, maintaining consistency with the fix in issue-detail-widget-modals.tsx and ensuring proper parent-child relationships.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit a95864b into preview Feb 13, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-sub-work-item branch February 13, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants