[WEB-3039] fix: assignee count in dashboard

[NarayanBavisetti]

Description

fixed the count of the assigned issue in dashboard.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

References

WEB-3039

Summary by CodeRabbit

• Bug Fixes
  • Refined issue filtering to exclude deleted issues from user dashboards
  • Improved accuracy of assigned issues counting by removing deleted issues from calculations

[makeplane]

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

The pull request modifies the filtering logic for issues in dashboard-related functions within the base.py file. The key change involves adding a condition issue_assignee__deleted_at__isnull=True to both dashboard_overview_stats and dashboard_assigned_issues functions. This ensures that only non-deleted issues assigned to a user are included in the dashboard statistics and issue lists, refining the query to exclude issues that have been marked as deleted by their assignees.

Changes

File	Change Summary
apiserver/plane/app/views/dashboard/base.py	Updated filtering conditions for assigned issues in dashboard_overview_stats and dashboard_assigned_issues functions to exclude deleted issues

Possibly related PRs

• [WEB-2228] fix: dashboard peek overview issue stats #5442 #5560: Modifies dashboard overview statistics related to issue filtering
• [WEB-2791]fix:priority icons shape in dashboard #6144: Changes to issue list item components
• [WEB-3139] fix: sub-issue visibility #6410: Addresses visibility issues for sub-issues

Suggested labels

🐛bug, ⚙️backend

Suggested reviewers

• pablohashescobar
• gurusainath
• SatishGandham

Poem

🐰 Hopping through code with care,
Filtering issues with a rabbit's flair,
Deleted tasks now swept away,
Dashboard stats shine bright today,
Clean and crisp, our data's clear! 🔍

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apiserver/plane/app/views/dashboard/base.py (1)

56-56: LGTM! Fix line length.

The added condition correctly filters out deleted assignees, ensuring accurate counts. However, the line exceeds the length limit.

Break the line into multiple lines for better readability:

-            (Q(assignees__in=[request.user]) & Q(issue_assignee__deleted_at__isnull=True)),
+            (
+                Q(assignees__in=[request.user])
+                & Q(issue_assignee__deleted_at__isnull=True)
+            ),

🧰 Tools

🪛 Ruff (0.8.2)

56-56: Line too long (91 > 88)

(E501)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4432be1 and a7af8b3.

📒 Files selected for processing (1)

• apiserver/plane/app/views/dashboard/base.py (2 hunks)

🧰 Additional context used

🪛 Ruff (0.8.2)

apiserver/plane/app/views/dashboard/base.py

56-56: Line too long (91 > 88)

(E501)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint-apiserver
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

apiserver/plane/app/views/dashboard/base.py (2)

179-182: LGTM! Well-formatted filter condition.

The added condition correctly filters out deleted assignees, ensuring consistency with the overview stats. The multi-line formatting improves readability.

---

56-56: Overall implementation looks good!

The changes consistently filter out deleted assignees in both the overview stats and assigned issues, effectively fixing the assignee count in the dashboard. The implementation is thorough and maintains consistency across functions.

Also applies to: 179-182

🧰 Tools

🪛 Ruff (0.8.2)

56-56: Line too long (91 > 88)

(E501)