[WEB-2513] fix: page container height

[aaryan610]

Problem:

The pages container height doesn't extend to the complete screen height. Use has to click on a specific area to focus on the page.

Solution:

Added h-full class to Increase the page container height to match the screen height.

Media:

Before	After
Screen.Recording.2024-09-20.at.19.16.41.mov	Screen.Recording.2024-09-20.at.19.14.54.mov

Plane issue: WEB-2513

Summary by CodeRabbit

• Bug Fixes
  • Improved height styling for the page editor component, enhancing the overall layout and user experience.

[coderabbitai]

Walkthrough

The changes in this pull request involve updating the containerClassName prop in the PageEditorBody component. The modification adds the h-full class to the existing class names, changing it from "p-0 pb-64" to "h-full p-0 pb-64". This adjustment may influence the height styling of the container when rendered.

Changes

File	Change Summary
web/core/components/pages/editor/editor-body.tsx	Updated containerClassName from "p-0 pb-64" to "h-full p-0 pb-64" to include height styling.

Possibly related PRs

• [WEB-2480] fix: project settings layout #5638: The changes in this PR involve adding the h-full class to a div in the ProjectSettingLayout, which directly relates to the modification of the containerClassName prop in the main PR that also adds h-full.

Suggested labels

🐛bug

Poem

In the editor's cozy nook,
A change was made with a quick look.
With h-full now in play,
The height's brightened up today!
A hop, a skip, a joyful cheer,
For styling changes, we hold dear! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66cfc73 and 4e1cbac.

Files selected for processing (1)

• web/core/components/pages/editor/editor-body.tsx (1 hunks)

Additional comments not posted (1)

web/core/components/pages/editor/editor-body.tsx (1)

179-179: LGTM!

The addition of the h-full class to the containerClassName prop is a straightforward and effective solution to make the page container extend to the full height of the screen. This change aligns perfectly with the PR objective of improving user interaction by allowing users to click anywhere within the container to focus on the page.

The implementation looks good, and no issues are identified.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SatishGandham]

It should be min-h-screen?

[aaryan610]

Not needed as it would add an unnecessary scroll to the container since the editor doesn't always occupy the complete screen height.