[WEB-2539] fix: update version history overlay z-index

[aaryan610]

Problem:

Editor toolbar is appearing over the version history overlay.

Solution:

Updated the z-index of the version history overlay.

Plane issue: WEB-2539

Summary by CodeRabbit

• Bug Fixes
  • Improved visibility of the PageVersionsOverlay by adjusting its stacking order.

[coderabbitai]

Walkthrough

The changes involve a modification to the PageVersionsOverlay component's z-index in the web/core/components/pages/version/root.tsx file. The z-index value was updated from z-10 to z-20, enhancing its visibility in the stacking order. Other properties, such as opacity and pointer-events, remain unchanged, and the conditional rendering based on the isOpen state continues to function as before.

Changes

Files	Change Summary
web/core/components/pages/version/root.tsx	Updated z-index of PageVersionsOverlay from z-10 to z-20

Possibly related PRs

• [WEB-2475] fix: applied filters header z-index and transparency  #5632: Modifies the z-index of the header component, relevant to the changes in the PageVersionsOverlay.
• [WEB-2513] fix: page container height #5669: Involves changes to a component's styling, specifically height, which may affect stacking context related to the z-index adjustments.

Suggested labels

🎨UI / UX

Suggested reviewers

• SatishGandham

Poem

In the garden where overlays play,
A z-index change brightens the day.
From ten to twenty, they rise up high,
Above all the rest, like a rabbit in the sky! 🐇✨
With opacity steady, they dance and they sway,
Celebrating changes in a whimsical way!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/pages/version/root.tsx (1)

43-43: Approved: Z-index update addresses the overlay issue.

The change from z-10 to z-20 effectively resolves the problem of the editor toolbar appearing over the version history overlay, as described in the PR objectives. This minimal change is focused and appropriate for the issue at hand.

For improved maintainability, consider defining z-index values as constants or in a configuration file. This approach would make it easier to manage z-index values across the application and prevent potential stacking conflicts in the future. For example:

// In a constants file (e.g., zIndexConstants.ts)
export const Z_INDEX = {
  EDITOR_TOOLBAR: 10,
  VERSION_HISTORY_OVERLAY: 20,
  // ... other z-index values
};

// In your component
import { Z_INDEX } from '@/constants/zIndexConstants';

// ...

className={cn(
  `absolute inset-0 z-[${Z_INDEX.VERSION_HISTORY_OVERLAY}] size-full bg-custom-background-100 flex overflow-hidden opacity-0 pointer-events-none transition-opacity`,
  {
    "opacity-100 pointer-events-auto": isOpen,
  }
)}

This approach would make it easier to maintain consistent z-index values across the application and quickly identify or adjust the stacking order when needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fbb6094 and b629537.

📒 Files selected for processing (1)

• web/core/components/pages/version/root.tsx (1 hunks)