Skip to content

[WEB-2512] fix: Large dropdown properties truncation#5672

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-dropdown-text-truncation
Sep 21, 2024
Merged

[WEB-2512] fix: Large dropdown properties truncation#5672
sriramveeraghanta merged 1 commit intopreviewfrom
fix-dropdown-text-truncation

Conversation

@rahulramesha
Copy link
Contributor

@rahulramesha rahulramesha commented Sep 20, 2024

This PR adds a minor UI fix to fix truncation on issues with large properties.

Before
Screenshot 2024-09-20 at 9 08 50 PM

After
Screenshot 2024-09-20 at 9 09 31 PM

Summary by CodeRabbit

  • New Features
    • Updated button components to occupy the full width of their parent containers for improved layout consistency.

@rahulramesha rahulramesha added 🐛bug Something isn't working 🌐frontend labels Sep 20, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The changes involve updates to the BorderButton and BackgroundButton components in the web/core/components/dropdowns/buttons.tsx file. The modifications specifically add the w-full class to the div elements of both buttons, ensuring they occupy the full width of their parent container while maintaining existing height, flex properties, and padding.

Changes

File Change Summary
web/core/components/dropdowns/buttons.tsx Updated class names for BorderButton and BackgroundButton to include w-full, ensuring full width layout.

Possibly related PRs

Poem

In a garden of buttons, wide and bright,
A rabbit hops in, with pure delight.
"W-full," he cheers, "let's fill the space,
With every leap, we'll find our place!"
So here's to the change, a joyful tune,
As buttons spread wide, like flowers in bloom! 🐇🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 604ddad and 1f852e9.

Files selected for processing (1)
  • web/core/components/dropdowns/buttons.tsx (2 hunks)
Additional comments not posted (2)
web/core/components/dropdowns/buttons.tsx (2)

77-77: LGTM!

The addition of the w-full class to the button's div element ensures that the button stretches to fill the available width of its parent container. This change aligns with the PR objective of fixing the truncation issue for large dropdown properties.


101-101: LGTM!

Similar to the BorderButton component, the addition of the w-full class to the button's div element ensures that the button stretches to fill the available width of its parent container. This change aligns with the PR objective of fixing the truncation issue for large dropdown properties.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants