[WEB-2612] fix: truncated project name in analytics dropdown#5883
[WEB-2612] fix: truncated project name in analytics dropdown#5883
Conversation
WalkthroughThe changes in this pull request involve a modification to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
web/core/components/analytics/custom-analytics/select/project.tsx (1)
26-26: LGTM! Consider using a CSS variable for flexibility.The addition of
max-w-[300px]effectively addresses the issue of truncated project names in the analytics dropdown. This change ensures that the dropdown options have a consistent maximum width, improving the overall user experience.For improved maintainability and flexibility, consider using a CSS variable instead of a hard-coded value. This would allow for easier adjustments across different screen sizes or component instances. Here's a suggested implementation:
- Define a CSS variable in your global styles:
:root { --max-project-width: 300px; }
- Update the className to use the CSS variable:
-<div className="flex items-center gap-2 max-w-[300px]"> +<div className="flex items-center gap-2 max-w-[var(--max-project-width)]">This approach maintains the current functionality while providing more flexibility for future adjustments.
Summary
This PR fixes the project name overflow in analytics dropddown
[WEB-2612]
Summary by CodeRabbit
New Features
Bug Fixes