[WEB-2570] fix: convert image size to string before calculations

[aaryan610]

Bug fix:

Convert image height and width to string before calculations.

Plane issue: WEB-2570

Summary by CodeRabbit

• New Features
  • Enhanced the CustomImageBlock component for improved handling of image dimensions, ensuring consistent type treatment for width and height.
  • Updated the CustomImageNodeViewProps to allow both numeric and string values for width and height attributes, providing greater flexibility for image sizing.

[coderabbitai]

Warning

Rate limit exceeded

@aaryan610 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between ec08fb0 and 94c1cb0.

Walkthrough

The changes in this pull request focus on enhancing the handling of image dimensions in the CustomImageBlock and CustomImageNodeViewProps components. Specifically, the initialization and updating of the size state in the CustomImageBlock component have been refined to ensure consistent string handling for width and height attributes. Additionally, the CustomImageNodeViewProps type has been updated to allow for both numeric and string types for width and height, increasing flexibility in attribute assignment.

Changes

File Path	Change Summary
packages/editor/src/core/extensions/custom-image/components/image-block.tsx	Modified the CustomImageBlock component to ensure width and height attributes are consistently treated as strings, defaulting to "35%" and "auto".
packages/editor/src/core/extensions/custom-image/components/image-node.tsx	Updated the CustomImageNodeViewProps type to allow width and height attributes to be either number or string, enhancing flexibility in type usage.

Possibly related PRs

• [WEB-2450] fix: image resize component #5623: The changes in the CustomImageBlock component in this PR involve modifications to how image dimensions are handled, which relates to the changes in the size state initialization and updates in the main PR.
• [WEB-2509] fix: image fullscreen size #5686: This PR also modifies the CustomImageBlock component, specifically how width and height are processed, which is directly related to the changes made in the main PR regarding the handling of size attributes.

Suggested labels

🐛bug

Suggested reviewers

• SatishGandham

Poem

In the garden where images bloom,
Width and height find their room.
Strings and numbers dance with glee,
Custom blocks, as fine as can be!
Hopping through code, a joyful sight,
Changes made, all feels just right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.