[WEB-2509] fix: image fullscreen size

[aaryan610]

Added null coalescing and optional chaining for image size.

Summary by CodeRabbit

• New Features
  • Enhanced image handling in the editor with improved dimension processing for custom images.
• Bug Fixes
  • Improved robustness of full-screen image actions by preventing errors related to undefined width and height values.

[coderabbitai]

Walkthrough

The changes involve updates to the CustomImageBlock and ImageFullScreenAction components. In CustomImageBlock, image dimensions are now derived from a size object instead of being directly assigned. In ImageFullScreenAction, the handling of width and height values has been improved with optional chaining to prevent errors when these values are undefined. These modifications enhance the overall robustness and functionality of the image handling components.

Changes

File Path	Change Summary
packages/editor/src/core/extensions/custom-image/...	Updated CustomImageBlock to derive height and width from a size object.
packages/editor/src/core/extensions/custom-image/...	Enhanced ImageFullScreenAction with optional chaining for width and height to prevent errors.

Possibly related PRs

• [WEB-2450] fix: image resize component #5623: The changes in the CustomImageBlock component regarding image dimensions and resizing are directly related to the modifications made in the same file, enhancing the image loading and resizing functionality.
• [WEB-2509] feat: fullscreen option for editor images #5665: The introduction of the ImageToolbarRoot component in the CustomImageBlock file is relevant as it builds upon the existing image handling logic, which is also modified in the main PR.

Suggested labels

✨feature

Suggested reviewers

• SatishGandham
• Palanikannan1437

Poem

In the garden of code, changes bloom bright,
Dimensions now dance, fitting just right.
With a hop and a skip, errors take flight,
Our images shine, a wonderful sight!
So let’s cheer for the tweaks, both bold and slight,
For a smoother experience, we take delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (2)

packages/editor/src/core/extensions/custom-image/components/toolbar/full-screen.tsx (2)

24-25: Approve changes with suggestions for improvement

The addition of optional chaining (?.) to the replace method calls is a good improvement. It prevents potential errors if width or height are undefined, aligning with the PR objective of implementing null coalescing and optional chaining for image size.

However, consider the following enhancement:

-  const widthInNumber = useMemo(() => Number(width?.replace("px", "")), [width]);
-  const heightInNumber = useMemo(() => Number(height?.replace("px", "")), [height]);
+  const widthInNumber = useMemo(() => Number(width?.replace("px", "") ?? 0), [width]);
+  const heightInNumber = useMemo(() => Number(height?.replace("px", "") ?? 0), [height]);

This change ensures that if width or height are undefined, or if the replace operation results in an empty string, the Number function will receive 0 instead of undefined. This prevents potential NaN values, which could cause issues in subsequent calculations or rendering.

---

Line range hint 1-159: Overall component review: Solid implementation with room for minor improvements

The ImageFullScreenAction component is well-structured and provides a good user experience for viewing images in fullscreen mode. The recent changes to add optional chaining for width and height calculations improve the component's resilience to undefined values.

Positive aspects:

1. Clear separation of concerns with distinct handlers for different actions.
2. Effective use of React hooks (useState, useMemo, useCallback, useEffect).
3. Keyboard shortcut support enhances accessibility.
4. Responsive design considerations with flexible sizing.

Suggestions for further improvement:

1. Implement more robust error handling for invalid image dimensions.
2. Consider adding loading states or placeholders for slow-loading images.
3. Evaluate the accessibility of the component, especially for keyboard navigation and screen readers.
4. Add unit tests to ensure the component behaves correctly with various input scenarios.

These enhancements would further improve the component's reliability and user experience. Overall, the component is well-implemented and the recent changes are a step in the right direction.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6170a80 and cf1bd9e.

Files selected for processing (2)

• packages/editor/src/core/extensions/custom-image/components/image-block.tsx (1 hunks)
• packages/editor/src/core/extensions/custom-image/components/toolbar/full-screen.tsx (1 hunks)

Additional comments not posted (1)

packages/editor/src/core/extensions/custom-image/components/image-block.tsx (1)

161-162: LGTM! Improved consistency and robustness in image dimension handling.

The changes to use size.height and size.width for the image object passed to ImageToolbarRoot are well-implemented. This modification:

1. Aligns with the PR objective of implementing null coalescing and optional chaining for image size.
2. Ensures that the most up-to-date dimensions are consistently used throughout the component.
3. Improves robustness by addressing potential issues with undefined or null values.

These changes contribute to a more maintainable and reliable codebase.