regression: Show the full screen toolbar option of images in read only instances as well

[Palanikannan1437]

Description

Show the full screen toolbar option of images in read only instances as well!

Credits

Thanks mikhaella from discord for the catch!

Summary by CodeRabbit

• New Features

  • Improved logic for displaying image utilities and resizing options in the Custom Image Block.
  • Introduced a dedicated control for managing the visibility of the image resizer.

• Bug Fixes

  • Streamlined conditions for showing image utilities, enhancing user experience when working with remote images.

[coderabbitai]

Walkthrough

The changes made to the CustomImageBlock component in image-block.tsx involve updates to the logic governing the display of image utilities and resizing functionality. The condition for showing image utilities has been simplified, focusing solely on the presence of a remote image source and completion of the initial resize. Additionally, a new variable for managing the visibility of the image resizer has been introduced, and rendering logic has been adjusted accordingly.

Changes

File Path	Change Summary
packages/editor/src/core/extensions/custom-image/components/image-block.tsx	Updated logic for displaying image utilities and resizing functionality; introduced showImageResizer variable; refined rendering conditions; updated types for ImageAttributes and Size; modified CustomImageBlock component.

Possibly related PRs

• [WEB-2450] fix: image resize component #5623: Modifies the CustomImageBlock component's resizing functionality and introduces new state variables.
• [WEB-2509] fix: image fullscreen size #5686: Updates how the dimensions of the image are determined in the CustomImageBlock.
• [PE-46] fix: added aspect ratio to resizing #5693: Adds aspect ratio support for image attributes, relevant to the resizing functionality.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• SatishGandham
• aaryan610
• sriramveeraghanta

🐇 In the garden where images play,
A resizer hops, brightening the day.
With utilities now clear and bright,
Our images dance in the soft sunlight.
So let’s cheer for the code, oh so clever,
For resizing joy, we’ll hop on forever! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/editor/src/core/extensions/custom-image/components/image-block.tsx (1)

185-188: Approve changes with a minor suggestion.

The modifications to showImageUtils and the introduction of showImageResizer align well with the PR objective. This change allows the image utilities (including the full screen toolbar) to be displayed in read-only instances while keeping the resizer limited to editable instances.

A minor suggestion for improved readability:

Consider extracting the common conditions into a separate variable:

const imageReady = remoteImageSrc && initialResizeComplete;
const showImageUtils = imageReady;
const showImageResizer = editor.isEditable && imageReady;

This would make the code more DRY and easier to maintain.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ee0dce4 and 323fe7d.

📒 Files selected for processing (1)

• packages/editor/src/core/extensions/custom-image/components/image-block.tsx (2 hunks)

🔇 Additional comments (2)

packages/editor/src/core/extensions/custom-image/components/image-block.tsx (2)

244-244: LGTM: Consistent use of showImageResizer.

The update to use showImageResizer for conditional rendering of the image resizer is consistent with the logic defined earlier. This ensures that the resizer is only displayed when appropriate (i.e., in editable instances with a fully loaded remote image).

---

Line range hint 1-270: Overall assessment: Changes align well with PR objective.

The modifications made to the CustomImageBlock component successfully address the PR objective of enabling the full screen toolbar option for images in read-only instances. The key changes include:

1. Separating the logic for displaying image utilities from the editor's editability.
2. Introducing a new variable showImageResizer to maintain the editor's editability check for the resizer.
3. Updating the conditional rendering to use these new variables consistently.

These changes allow the image utilities (including the full screen toolbar) to be accessible in read-only instances while keeping the resizer functionality limited to editable instances. The implementation is clean and focused, with no unnecessary changes to other parts of the file.