[WEB-2802]fix:filters drop down fix safari

[vamsikrishnamathala]

Summary

Fixed visibility issue of filters dropdown in intake for Safari browser.

Reference

WEB-2802

Summary by CodeRabbit

• Bug Fixes
  • Improved the vertical alignment of the dropdown panel in the FiltersDropdown component for better compatibility with Safari.

[coderabbitai]

Walkthrough

The changes in this pull request focus on modifying the Popover.Panel component within the FiltersDropdown in the dropdown.tsx file. Specifically, the class name was updated from "fixed z-10" to "fixed z-10 translate-y-0", which introduces the translate-y-0 class to create a new stacking context, particularly for compatibility with Safari. This change does not affect any other logic, error handling, or control flow within the component.

Changes

File Path	Change Summary
web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx	Updated class name in Popover.Panel from "fixed z-10" to "fixed z-10 translate-y-0" for stacking context compatibility.

Possibly related PRs

• [WEB-2304] fix: increase z-index from z-20 to z-[21] in dropdown.tsx #5446: This PR modifies the z-index in dropdown.tsx, which is relevant to the changes made in the Popover.Panel component in the main PR, as both involve adjustments to stacking contexts.
• [WEB-2475] fix: applied filters header z-index and transparency  #5632: This PR addresses z-index issues in the applied filters header, which relates to the overall management of z-index values in dropdown components, similar to the changes in the main PR.
• [WEB-2525] fix: activity filters #5682: This PR introduces a required property for filtering activities, which may indirectly relate to the dropdown functionality in the main PR by enhancing the filtering capabilities within the application.

Suggested reviewers

• sriramveeraghanta
• SatishGandham
• anmolsinghbhatia

🐰 In the dropdown's cozy nook,
A tweak was made, come take a look!
With class anew, it stands so tall,
Aligning well, it won't fall!
Hopping high, in style it glows,
A little change, how sweet it flows!
🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3a9f94f and 6205160.

📒 Files selected for processing (1)

• web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1)

88-88: Consider adding a comment to document the Safari fix.

To help future maintainers understand the purpose of translate-y-0, consider adding a comment explaining that it addresses a Safari-specific positioning issue.

-              <Popover.Panel className="fixed z-10 translate-y-0">
+              {/* translate-y-0 fixes dropdown positioning issues in Safari */}
+              <Popover.Panel className="fixed z-10 translate-y-0">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3c6006d and 3a9f94f.

📒 Files selected for processing (1)

• web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1 hunks)

🔇 Additional comments (1)

web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1)

88-88: LGTM! Good fix for Safari's positioning issue.

The addition of translate-y-0 effectively resolves the Safari-specific positioning issue while maintaining compatibility with other browsers. This works well with the existing transition animations defined in the Transition component.