[WEB-2525] fix: activity filters#5682
Conversation
WalkthroughThe changes introduced in this pull request involve the addition of a new required property, Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
web/ce/components/issues/worklog/activity/filter-root.tsx (1)
12-12: LGTM: Addition ofprojectIdprop.The addition of the
projectIdprop aligns with the PR objectives to fix the activity filters by passing the project ID. This change should resolve the issue where filters weren't functioning due to the missing project ID.Consider adding a brief comment explaining the purpose of this prop, e.g.:
/** The ID of the project for which activities are being filtered */ projectId: string;
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/ce/components/issues/worklog/activity/filter-root.tsx (1 hunks)
Additional comments not posted (2)
web/ce/components/issues/worklog/activity/filter-root.tsx (2)
13-13: Clarify the purpose of the optionalisIntakeIssueprop.Addressing the past review comment: The
isIntakeIssueprop is defined as optional. Could you provide more context on why this prop is optional and when it would be used? This information would be helpful for maintainability and understanding the component's behavior.To better understand the usage of
isIntakeIssue, let's search for its occurrences:#!/bin/bash # Description: Check for usage of isIntakeIssue prop echo "Searching for isIntakeIssue usage in the codebase:" rg --type typescript -A 5 "isIntakeIssue"Based on the results, we can determine if this prop is necessary and how it affects the component's functionality.
Line range hint
16-31: Verify usage ofprojectIdprop in the component.The
projectIdprop has been added to theTActivityFilterRoottype, but it's not being used in theActivityFilterRootcomponent. Ensure that this prop is being passed down to child components or used in filtering logic as intended.To confirm the usage of
projectIdin child components or related files, please run the following script:If the
projectIdis not being used, consider updating the component to utilize this prop for filtering activities.
2 participants
Changes:
This PR addresses a fix for the issue activity filters. Previously, the intake and inbox issue activity filters were not rendering as they expected a project ID from the route. Now, the project ID is passed as a prop, resolving the issue.
Reference:
[WEB-2525]
Summary by CodeRabbit
projectIdfilter for more precise activity filtering in the Activity Filter component.projectIdparameter.These updates allow users to filter activities based on specific projects, improving the overall functionality and user experience.