[WEB-2678]fix: create labels empty state

[vamsikrishnamathala]

Description

Handled empty state when project labels were not present.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-2678

Summary by CodeRabbit

• New Features
  • Enhanced user experience for adding labels with improved input validation.
  • Clearer feedback for adding labels based on user input.
• Bug Fixes
  • Prevented the addition of empty labels by introducing necessary checks.

[coderabbitai]

Walkthrough

The pull request introduces improvements to label selection and creation functionality in two related components. The changes focus on enhancing user experience by adding input validation and more informative feedback when adding new labels. Specifically, the modifications prevent users from creating empty labels and provide clearer guidance during the label creation process by dynamically updating prompts and cursor styles based on user input.

Changes

File	Change Summary
web/core/components/issues/issue-detail/label/select/label-select.tsx	- Added condition to prevent adding empty labels - Updated "Add" label option display logic - Modified class names for label addition prompt
web/core/components/issues/issue-layouts/properties/labels.tsx	- Added input length check for label creation - Updated "Add" label prompt text - Conditionally applied cursor style based on query

Poem

🐰 A Label's Tale of Wisdom Bright
No empty tags shall see the light
Type with care, your cursor keen
Guidance clear on every screen
CodeRabbit's touch, so subtle and right! 🏷️

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

web/core/components/issues/issue-detail/label/select/label-select.tsx (1)

188-191: Consider moving empty check to handleAddLabel

The empty check could be moved to the handleAddLabel function to centralize validation and ensure consistent behavior across all entry points.

-if(!query.length) return
-handleAddLabel(query);
+handleAddLabel(query);

// In handleAddLabel function:
const handleAddLabel = async (labelName: string) => {
+  if (!labelName.trim()) return;
   setSubmitting(true);
   // ... rest of the function
};

web/core/components/issues/issue-layouts/properties/labels.tsx (2)

344-347: Consider moving empty check to handleAddLabel

Similar to the label-select component, consider moving the empty check to the handleAddLabel function for consistent validation.

-if (!query.length) return;
-handleAddLabel(query);
+handleAddLabel(query);

// In handleAddLabel function:
const handleAddLabel = async (labelName: string) => {
+  if (!projectId || !labelName.trim()) return;
-  if (!projectId) return;
   setSubmitting(true);
   // ... rest of the function
};

---

347-355: LGTM! Consistent implementation with label-select

The implementation maintains consistency with the label-select component, providing the same user experience across different parts of the application.

Note: There's a minor inconsistency in semicolon usage between this file and label-select.tsx, but this is not a significant issue.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ede4aad and c9cfb92.

📒 Files selected for processing (2)

• web/core/components/issues/issue-detail/label/select/label-select.tsx (1 hunks)
• web/core/components/issues/issue-layouts/properties/labels.tsx (1 hunks)

🔇 Additional comments (1)

web/core/components/issues/issue-detail/label/select/label-select.tsx (1)

191-199: LGTM! Clear user feedback implementation

The implementation provides excellent user feedback by:

• Using appropriate cursor styles based on input state
• Showing clear guidance text when no input is present
• Displaying dynamic text for label creation when input exists