fix: changed the response structure in project page duplicate

[NarayanBavisetti]

Description

changed the response structure in project page duplicate

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Summary by CodeRabbit

• New Features

  • Enhanced page duplication process by automatically setting the page owner to the user creating the duplicate.

• Bug Fixes

  • Improved error handling for page updates to prevent modifications to archived or locked pages.

• Performance

  • Optimized page retrieval query to include project information more efficiently.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the PageDuplicateEndpoint class in the page management system. The changes focus on improving page duplication functionality by explicitly setting the page owner to the current user during duplication. Additionally, the code enhances the page retrieval process by using a more sophisticated query method that includes project ID aggregation. The error handling for page updates has been refined to prevent modifications to archived or locked pages, adding an extra layer of data integrity and access control.

Changes

File	Change Summary
apiserver/plane/app/views/page/base.py	- Added line to set owned_by to current user during page duplication - Enhanced page retrieval with annotated project ID query - Improved error handling for partial_update method to check page status

Suggested Reviewers

• pablohashescobar
• pushya22
• sriramveeraghanta

Suggested Labels

⚙️backend

Possibly related PRs

• fix: workspace user property migration #5908: Migration script changes potentially related to project and ownership associations

Poem

🐰 A page duplicates with grace,
Owned by the creator's embrace
Queries dance with project's might
Locked pages bow to wisdom's light
Code hops, logic takes its flight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61d6d92 and 837a0d5.

📒 Files selected for processing (1)

• apiserver/plane/app/views/page/base.py (2 hunks)

🔇 Additional comments (2)

apiserver/plane/app/views/page/base.py (2)

575-575: Validate ownership logic when duplicating pages
Setting page.owned_by = request.user ensures that the user who duplicates the page becomes its owner, which appears consistent with the PR objectives. However, confirm whether the original page owner's rights should be preserved for auditing or collaborative ownership.

Would you like to maintain any reference to the original owner or include a note indicating the duplication origin?

---

590-601: Confirm array aggregation filter expression
The filter condition filter=~Q(projects__id=True) in your ArrayAgg annotation may be unintended or leftover code. Typically, you might exclude NULL values or specify a valid condition (e.g., projects__id__isnull=False).

Please double-check that this condition aligns with how you want to filter project IDs. If required, update it to a more appropriate filter, or remove it if no special filtering is needed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.