Skip to content

[WEB-3110] chore: changed the creator of page when duplicated#6378

Merged
pushya22 merged 1 commit intopreviewfrom
chore-page-duplicate-creator
Jan 10, 2025
Merged

[WEB-3110] chore: changed the creator of page when duplicated#6378
pushya22 merged 1 commit intopreviewfrom
chore-page-duplicate-creator

Conversation

@NarayanBavisetti
Copy link
Collaborator

@NarayanBavisetti NarayanBavisetti commented Jan 10, 2025

Description

  • The creator of the page is changed when the page is duplicated.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Summary by CodeRabbit

  • New Features
    • Enhanced page duplication process to track the user who creates a duplicate page
  • Bug Fixes
    • Improved user attribution when duplicating pages by setting created_by and updated_by fields

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

Walkthrough

The pull request modifies the PageDuplicateEndpoint class in the page base view to enhance page duplication tracking. When a page is duplicated, the new page now explicitly sets both created_by and updated_by attributes to the current user. This change ensures accurate user attribution during the page duplication process, maintaining clear ownership information for newly created pages.

Changes

File Change Summary
apiserver/plane/app/views/page/base.py Added created_by and updated_by attributes to page duplication process, setting both to request.user

Suggested labels

🌐frontend, 🌟improvement

Suggested reviewers

  • pablohashescobar

Possibly related PRs

Poem

🐰 A rabbit's tale of pages new,
Duplicated with a user's view
Created and updated, tracked with care
By the one who clicked "Duplicate" there!
A digital trail, crisp and bright 🖨️

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apiserver/plane/app/views/page/base.py (1)

576-577: LGTM! Consider grouping user-related attributes together.

The changes correctly set both created_by and updated_by to the current user when duplicating a page. For better code organization, consider grouping all user-related attributes together.

         page.pk = None
         page.name = f"{page.name} (Copy)"
         page.description_binary = None
+        # Group user-related attributes
         page.owned_by = request.user
         page.created_by = request.user
         page.updated_by = request.user
         page.save()
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58ac1dc and 6df6767.

📒 Files selected for processing (1)
  • apiserver/plane/app/views/page/base.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint-apiserver
  • GitHub Check: Analyze (javascript)

@pushya22 pushya22 changed the title chore: changed the creator of page when duplicated [WEB-3110] chore: changed the creator of page when duplicated Jan 10, 2025
@pushya22 pushya22 merged commit 95175ab into preview Jan 10, 2025
10 of 11 checks passed
@pushya22 pushya22 deleted the chore-page-duplicate-creator branch January 10, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants