[WEB-3042]fix: added tooltips for truncated favorites

[vamsikrishnamathala]

Description

Added tooltips for truncated favorite items.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-3042

Summary by CodeRabbit

• Style
  • Updated Tooltip component styling in favorite folder and favorite item title components
  • Added left margin to tooltip when sidebar is not collapsed

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Tooltip component in two related files within the workspace sidebar favorites section. The changes primarily involve adjusting the Tooltip implementation by adding a left margin class and removing the disabled prop. These modifications affect how tooltips are displayed when the sidebar is collapsed or expanded, potentially improving the visual presentation of favorite items.

Changes

File	Change Summary
web/core/components/workspace/sidebar/favorites/favorite-folder.tsx	- Added className="ml-8" to Tooltip - Removed disabled prop from Tooltip
web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx	- Imported cn utility from @plane/utils - Added conditional left margin using cn(!isSidebarCollapsed && "ml-8") - Removed disabled prop from Tooltip

Possibly related PRs

• [WEB-2774] Chore: re-ordering functionality for entities in favorites. #6078: Directly related changes to the Tooltip component in FavoriteFolder
• [WEB-2774] fix:favorites reorder #6179: Reordering functionality in the FavoriteFolder
• [WEB-2926]fix: added tooltips for favorites #6320: Added tooltips to the favorites section

Suggested reviewers

• rahulramesha
• SatishGandham
• anmolsinghbhatia

Poem

🐰 A Rabbit's Tooltip Tale 🐰

Margins dancing left and right,
Tooltips spreading their delight,
Collapsed or open, they now shine bright,
With classes neat and margins tight,
A sidebar's whisper, soft and light! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx (1)

32-32: Assess margin usage consistency with the other file.
Here, the margin (ml-8) is applied conditionally based on !isSidebarCollapsed. In favorite-folder.tsx, it's hard-coded without the condition. If you want them to behave identically, consider reusing the same pattern for consistency.

You could align both implementations with something like:

- className="ml-8"
+ className={cn(!isSidebarCollapsed && "ml-8")}

web/core/components/workspace/sidebar/favorites/favorite-folder.tsx (1)

191-191: Ensure alignment of margin behavior with the other tooltip usage.
Since favorite-item-title.tsx conditionally applies the left margin based on the sidebar state, it might be beneficial to follow the same logic here, unless you explicitly want the extra margin at all times.

Consider:

- className="ml-8"
+ className={cn(!isSidebarCollapsed && "ml-8")}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cabde0 and 837c2b3.

📒 Files selected for processing (2)

• web/core/components/workspace/sidebar/favorites/favorite-folder.tsx (1 hunks)
• web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint-web
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx (1)

6-6: Good import of the cn utility.
The addition of cn from @plane/utils helps conditionally apply classes while keeping the code concise and readable.