Skip to content

[WEB-3042]fix: added tooltips for truncated favorites #6330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Jan 7, 2025
Merged

[WEB-3042]fix: added tooltips for truncated favorites #6330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions web/core/components/workspace/sidebar/favorites/favorite-folder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,7 @@ export const FavoriteFolder: React.FC<Props> = (props) => {
</div>
) : (
<>
<Tooltip
tooltipContent={`${favorite.name}`}
position="right"
disabled={!isSidebarCollapsed}
isMobile={isMobile}
>
<Tooltip tooltipContent={`${favorite.name}`} position="right" className="ml-8" isMobile={isMobile}>
<div className="flex-grow flex truncate">
<Disclosure.Button
as="button"
Expand Down
3 changes: 2 additions & 1 deletion ...core/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-title.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React, { FC } from "react";
import { observer } from "mobx-react";
import Link from "next/link";
import { Tooltip } from "@plane/ui";
import { cn } from "@plane/utils";
import { useAppTheme } from "@/hooks/store";
import { usePlatformOS } from "@/hooks/use-platform-os";

Expand All @@ -28,7 +29,7 @@ export const FavoriteItemTitle: FC<Props> = observer((props) => {
};

return (
<Tooltip tooltipContent={title} isMobile={isMobile} disabled={!isSidebarCollapsed} position="right">
<Tooltip tooltipContent={title} isMobile={isMobile} position="right" className={cn(!isSidebarCollapsed && "ml-8")}>
<Link href={href} className={isSidebarCollapsed ? collapsedClass : linkClass} draggable onClick={handleOnClick}>
<span className="flex items-center justify-center size-5">{icon}</span>
{!isSidebarCollapsed && <span className="text-sm leading-5 font-medium flex-1 truncate">{title}</span>}
Expand Down
Loading