Skip to content

Comments

feat: Chinese language support#6407

Merged
sriramveeraghanta merged 2 commits intopreviewfrom
feat-chinese-support
Jan 16, 2025
Merged

feat: Chinese language support#6407
sriramveeraghanta merged 2 commits intopreviewfrom
feat-chinese-support

Conversation

@sriramveeraghanta
Copy link
Member

@sriramveeraghanta sriramveeraghanta commented Jan 16, 2025

Description

Adding Chinese language translations.

Type of Change

  • Feature (non-breaking change which adds functionality)

References

#6390

Summary by CodeRabbit

  • New Features

    • Added support for Chinese (Simplified) language
    • Expanded internationalization configuration to include Chinese translations
    • Introduced comprehensive Chinese language localization for user interface elements
  • Documentation

    • Updated language support configuration to reflect new language option

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

Walkthrough

The pull request introduces Chinese language support to the internationalization configuration. This involves updating the language configuration in the index.ts file and adding a new translations.json file for Simplified Chinese translations. The changes expand the supported languages array, update the translations object, and include a comprehensive set of Chinese translations for various user interface elements and messages.

Changes

File Change Summary
packages/i18n/src/config/index.ts - Added "zh-CN" to languages array
- Incorporated zh_CN translations
- Expanded SUPPORTED_LANGUAGES with Chinese language entry
packages/i18n/src/locales/zh-CN/translations.json - New translations file added
- Comprehensive Chinese translations for UI elements, actions, and messages

Poem

🐰 A linguistic leap, a rabbit's delight,
Chinese characters now shine so bright!
From "submit" to "cancel", words take flight,
Translations dancing with pure insight,
Bridging cultures with linguistic might! 🌏


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/i18n/src/config/index.ts (1)

1-5: Consider organizing imports alphabetically

The import statements could be organized alphabetically for better maintainability.

Apply this change:

- import cn from "../locales/cn/translations.json";
- import en from "../locales/en/translations.json";
- import es from "../locales/es/translations.json";
- import fr from "../locales/fr/translations.json";
- import ja from "../locales/ja/translations.json";
+ import zh from "../locales/zh/translations.json";
+ import en from "../locales/en/translations.json";
+ import es from "../locales/es/translations.json";
+ import fr from "../locales/fr/translations.json";
+ import ja from "../locales/ja/translations.json";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8acea7f and 5c9f3ad.

📒 Files selected for processing (2)
  • packages/i18n/src/config/index.ts (3 hunks)
  • packages/i18n/src/locales/cn/translations.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/i18n/src/locales/cn/translations.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
packages/i18n/src/locales/zh-CN/translations.json (1)

117-117: Improve the workspace request email template translation.

The email template contains untranslated placeholders [/workspace-name] and [工作区创建目的]. Consider using more descriptive Chinese placeholders for consistency.

-  "workspace_request_body": "实例管理员:\n\n请在 URL [/workspace-name] 处创建一个新的工作区。[工作区创建目的]\n\n谢谢。\n{{firstName}} {{lastName}}\n{{email}}",
+  "workspace_request_body": "实例管理员:\n\n请在 URL [工作区名称] 处创建一个新的工作区。[创建目的]\n\n谢谢。\n{{firstName}} {{lastName}}\n{{email}}",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9f3ad and 3d313f8.

📒 Files selected for processing (2)
  • packages/i18n/src/config/index.ts (3 hunks)
  • packages/i18n/src/locales/zh-CN/translations.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/i18n/src/config/index.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (2)
packages/i18n/src/locales/zh-CN/translations.json (2)

1-319: Well-structured and culturally appropriate translations!

The translations maintain a consistent formal tone using "您" and provide clear, professional Chinese translations for technical terms.


1-319: Valid JSON structure and formatting!

The file follows proper JSON syntax and formatting conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants