feat(i18n): add Vietnamese#6842
Conversation
- Added Vietnamese (Tiếng việt) to the list of supported languages. - Created a new translations file for Vietnamese with comprehensive translations for various UI elements. - Updated the TranslationStore to include the new Vietnamese language option.
|
|
WalkthroughThis pull request introduces Vietnamese language support to the application. It updates the supported languages configuration, adds Vietnamese translations in a new JSON file, and extends the translation store logic to load the Vietnamese translations. Additionally, the language type definitions are updated to include the new "vi" option. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant TS as TranslationStore
participant FS as File System
U->>TS: Request translations for "vi"
TS->>FS: Load translations from ../locales/vi/translations.json
FS-->>TS: Return Vietnamese translations
TS-->>U: Provide localized content
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/i18n/src/constants/language.ts (1)
22-22: Capitalization correction needed for Vietnamese language label.The Vietnamese language label should be "Tiếng Việt" with a capital V since language names are proper nouns in Vietnamese.
- { label: "Tiếng việt", value: "vi" }, + { label: "Tiếng Việt", value: "vi" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/vi/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
🔇 Additional comments (3)
packages/i18n/src/types/language.ts (1)
17-18: Language type definition looks good.The addition of "vi" to the TLanguage type definition is correct and maintains consistency with the other language options.
packages/i18n/src/store/index.ts (1)
172-173: Translation import implementation looks good.The Vietnamese language case is properly implemented following the same pattern as other language options in the importLanguageFile method.
packages/i18n/src/locales/vi/translations.json (1)
1-2329: Vietnamese translations look well-structured and comprehensive.The translations file follows the correct JSON structure and includes translations for all the necessary UI elements and messages. The translations appear to be complete and consistent with the application's terminology.
anmolsinghbhatia
changed the base branch from
preview
to
feat-vietnamese-and-portuguese-language-support
anmolsinghbhatia
merged commit 5ec817b
into
makeplane:feat-vietnamese-and-portuguese-language-support
- Added Vietnamese (Tiếng việt) to the list of supported languages. - Created a new translations file for Vietnamese with comprehensive translations for various UI elements. - Updated the TranslationStore to include the new Vietnamese language option.
3 participants
Description
Add Vietnamese support
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
Change the language setting from English to Tiếng Việt. All text should be displayed in Vietnamese.
References
Translated with reference to Chinese
Summary by CodeRabbit