feat: Adding Romanian Language locale#6809
Conversation
WalkthroughThe changes introduce Romanian language support to the application's internationalization module. A new entry for Romanian ("ro", labeled "Română") was added to the supported languages constant and type definition. A dedicated Romanian translations JSON file has been created, and the translation store was updated to load the Romanian translations. These modifications allow the application to serve a fully localized experience for Romanian-speaking users. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TranslationStore
participant FileSystem
User->>TranslationStore: Request translations for "ro"
TranslationStore->>FileSystem: Load ../locales/ro/translations.json
FileSystem-->>TranslationStore: Return Romanian translations
TranslationStore-->>User: Provide Romanian translations
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey @mnbro Can you please sign the CLA? |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/i18n/src/locales/ro/translations.json (1)
1-2372: Maintainability & Future Scalability Suggestion
Given the file’s considerable size and the number of UI components covered, it might be beneficial in the long run to consider splitting translations into feature-specific or domain-specific JSON files (for example, one file for authentication messages, one for dashboard/notifications, etc.). This modular approach would enhance maintainability and simplify future updates or reviews by native speakers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/ro/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/i18n/src/constants/language.ts
- packages/i18n/src/store/index.ts
- packages/i18n/src/types/language.ts
🔇 Additional comments (1)
packages/i18n/src/locales/ro/translations.json (1)
1-2372: Overall Structure & Completeness of the Translation File
This new Romanian translations file is very comprehensive. All the key–value pairs are well organized into logical sections (e.g., "sidebar", "auth", "toast", "workspace", etc.), which mirrors the structure typically used for localization in our codebase. The translations appear clear and consistent with Romanian language conventions. It’s a solid addition for supporting the new locale.
@sriramveeraghanta Done ✅ |
5609f0b
into
makeplane:feat-romanian-and-indonesian-language-support
* Add ro Romanian Language locale (#6809) * feat: add Indonesian language support (#6794) Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> * chore: core translation added and code refactor --------- Co-authored-by: mnbro <107358316+mnbro@users.noreply.github.com> Co-authored-by: Rasyid Ridho <rasyid@sekeco.id>
* Add ro Romanian Language locale (#6809) * feat: add Indonesian language support (#6794) Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> * chore: core translation added and code refactor --------- Co-authored-by: mnbro <107358316+mnbro@users.noreply.github.com> Co-authored-by: Rasyid Ridho <rasyid@sekeco.id>
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit