Skip to content

[PE-237] fix: editor placeholder and muted text color#6430

Merged
pushya22 merged 1 commit intopreviewfrom
fix/editor-placeholder
Jan 20, 2025
Merged

[PE-237] fix: editor placeholder and muted text color#6430
pushya22 merged 1 commit intopreviewfrom
fix/editor-placeholder

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Jan 20, 2025

Description

This PR updates the colors of the placeholders and muted texts for the editor improving the visibilty of such text items in colored backgrounds, like stickies and callout blocks.

Type of Change

  • Improvement (change that would cause existing functionality to not work as expected)

Summary by CodeRabbit

  • Style
    • Updated placeholder text color in the editor to use a new --color-placeholder variable
    • Adjusted color for checked task list items to improve visual consistency

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2025

Walkthrough

This pull request focuses on updating the color styling for placeholder text and checked task list items in the ProseMirror editor. A new CSS variable --color-placeholder is introduced in the variables.css file, which is then used to replace existing color references in the editor.css file. The changes aim to improve color consistency and styling across the editor's placeholder and task list elements.

Changes

File Change Summary
packages/editor/src/styles/variables.css Added new CSS variable --color-placeholder with rgba(var(--color-text-100), 0.5) value
packages/editor/src/styles/editor.css Updated color properties for:
- Placeholder text selectors
- Checked task list items

Possibly related PRs

Suggested labels

🎨UI / UX

Suggested reviewers

  • SatishGandham

Poem

🐰 A rabbit's ode to color's grace,
Placeholders now with softer trace,
CSS variables dance and glow,
Styling magic starts to flow!
Editor's palette, crisp and bright,
A chromatic rabbit's delight! 🎨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13cc8b0 and e533a1d.

📒 Files selected for processing (2)
  • packages/editor/src/styles/editor.css (3 hunks)
  • packages/editor/src/styles/variables.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (4)
packages/editor/src/styles/variables.css (1)

2-2: Well-structured implementation of the placeholder color variable!

The new --color-placeholder variable is well-designed:

  • Uses semantic naming
  • Leverages existing color system
  • 50% opacity ensures visibility against various backgrounds
packages/editor/src/styles/editor.css (3)

28-28: LGTM! Consistent use of placeholder color for empty editor.

The implementation correctly uses the new --color-placeholder variable for the first-line placeholder.


37-37: LGTM! Consistent styling for empty line placeholders.

The implementation maintains visual consistency by using the same placeholder color for all empty lines.


195-195: LGTM! Appropriate use of placeholder color for completed tasks.

Using the placeholder color for checked items effectively indicates their completed state while maintaining consistency with other muted elements.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 changed the title [PE-237] fix: editor placeholder color [PE-237] fix: editor placeholder and muted text color Jan 20, 2025
@pushya22 pushya22 merged commit 22836ea into preview Jan 20, 2025
10 of 14 checks passed
@pushya22 pushya22 deleted the fix/editor-placeholder branch January 20, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants