fix: todo list item color when item is checked and custom color is applied

[aaryan610]

Bug fix:

When a todo list item contains some characters with custom color applied, checking the item doesn't mute that color.

Media:

Before	After
Screen.Recording.2024-11-28.at.16.28.32.mov	Screen.Recording.2024-11-28.at.16.22.57.mov

Summary by CodeRabbit

• New Features

  • Enhanced styles for task lists, improving visual hierarchy and interactivity.
  • Added transitions for color and opacity in task list items and checkboxes.

• Bug Fixes

  • Improved specificity for task list item selectors, ensuring consistent appearance for checked items.

• Style

  • Adjusted margin and padding for consistent spacing in the editor.
  • Maintained responsive design for smaller screens.

[coderabbitai]

Walkthrough

The changes involve modifications to the CSS styles for the .ProseMirror class, particularly enhancing the styling and interactivity of task lists. Key updates include restructuring styles for task list items, improving specificity for checked items, and adding transitions for color and opacity. The overall visual hierarchy and spacing of elements have been refined, ensuring consistent presentation across the editor. Responsive design considerations have been maintained through the use of media queries.

Changes

File Path	Change Summary
packages/editor/src/styles/editor.css	Updated styles for .ProseMirror class and task lists, including nested selectors, transitions for color and opacity, and adjustments to margin and padding for consistent spacing.

Possibly related PRs

• [WEB-1116] fix: task list not getting synced in realtime collaboration #5566: Modifies CSS for checkboxes within a task list, enhancing selector specificity.
• [WEB-2503] chore: remove line-through decoration from checked todo list items #5659: Removes line-through decoration from checked todo list items and introduces a color transition effect.
• [WEB-2732] fix: global css conflicts #5945: Significant updates to CSS for the .ProseMirror class and its child elements.

Suggested labels

🐛bug

Suggested reviewers

• SatishGandham

🐰 In the editor's bright, bustling space,
Styles have changed with a hop and a grace.
Task lists now dance with colors that flow,
Transitions and margins make the layout glow.
With each little checkbox, a click brings delight,
A whimsical world, where tasks feel just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/editor/src/styles/editor.css (1)

193-201: Consider consolidating transition declarations

The implementation correctly addresses the color muting for checked items. However, there's a minor opportunity for improvement in the transition declarations.

Consider this small refinement to avoid repeating the transition property:

 ul[data-type="taskList"] li[data-checked="true"] {
   & > div > p {
     color: rgb(var(--color-text-400));
   }

   [data-text-color] {
     opacity: 0.6;
-    transition: opacity 0.2s ease;
   }
 }

The transition is already defined in the base styles (line 189), so it doesn't need to be repeated here. This makes the code more maintainable as the transition timing only needs to be updated in one place.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 378e896 and 0f77919.

📒 Files selected for processing (1)

• packages/editor/src/styles/editor.css (1 hunks)

🔇 Additional comments (2)

packages/editor/src/styles/editor.css (2)

182-190: LGTM: Well-structured transitions for task list items

The addition of smooth transitions for both color and opacity changes will provide better visual feedback when toggling task list items.

---

182-201: Implementation successfully addresses the PR objective

The changes effectively solve the reported issue by:

1. Properly muting custom colored text when items are checked
2. Maintaining visual consistency with regular text items
3. Providing smooth transitions for better user experience

The implementation is clean, maintainable, and follows CSS best practices.