[WEB-3435]fix: add favorites

[vamsikrishnamathala]

Description

This update fixes the page crash while adding a favorite.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-3435

Summary by CodeRabbit

• Refactor
  • Enhanced the mechanism for identifying favorite items to ensure that details are retrieved and displayed more accurately across the platform.

[coderabbitai]

Walkthrough

This pull request updates the way the favorite item identifier is derived in the useFavoriteItemDetails hook. The previous access via favorite?.entity_data?.id is replaced with favorite?.entity_identifier. The remaining functionality—including the derivation of other item properties and the switch for handling different entity types—remains unchanged. This revision may affect how subsequent store hook calls retrieve data.

Changes

File	Summary
web/.../use-favorite-item-details.tsx	Replaced favorite?.entity_data?.id with favorite?.entity_identifier to derive favoriteItemId; other code remains unchanged

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant H as useFavoriteItemDetails Hook
    participant F as Favorite Data
    participant S as Store Hooks

    U->>H: Request favorite item details
    H->>F: Retrieve favorite?.entity_identifier
    H->>S: Call getViewById / getProjectById / getCycleById / getModuleById with favoriteItemId
    S-->>H: Return item details
    H->>U: Provide finalized details

Loading

Possibly related PRs

• [WEB-2374] fix: untitle page title in favorites list #5515: Introduces a helper function for determining the item title in useFavoriteItemDetails, which is directly related to how favorite items are processed.
• [WEB-2597] fix: handle favorite entity data causing application error #5756: Involves modifications to accessing properties of the favorite object using optional chaining in the same function.

Suggested labels

🌐frontend

Suggested reviewers

• sriramveeraghanta
• rahulramesha

Poem

I'm a little bunny, hopping in the code,
Found a change that lightened the load.
From entity_data to entity_identifier so clear,
I twirl my whiskers with joyful cheer!
Keep on hopping, let's debug with delight!
🐇💻 Happy code days, morning to night!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/hooks/use-favorite-item-details.tsx (1)

16-16: Consider adding type safety.

To prevent similar issues in the future, consider adding runtime validation for the entity_identifier.

-  const favoriteItemId = favorite?.entity_identifier;
+  const favoriteItemId = favorite?.entity_identifier;
+  if (!favoriteItemId) {
+    console.warn('Missing entity_identifier for favorite item:', favorite);
+  }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fa45ef and e4a70ea.

📒 Files selected for processing (1)

• web/core/hooks/use-favorite-item-details.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/core/hooks/use-favorite-item-details.tsx (1)

16-16: LGTM! Verify the fix across all entity types.

The change from entity_data?.id to entity_identifier looks correct and should resolve the crash. This is a more reliable way to access the identifier.

Please verify that entity_identifier is consistently set for all entity types (project, page, view, cycle, module) by testing the favorites functionality with each type.