fix: favorite mutation on quick actions

[gakshita]

Description

This Pr fixes the ui issue faced on quick fav/unfav actions

Summary by CodeRabbit

• New Features
  • Enhanced favorite management: When adding a favorite, the system now returns the existing record if one is already present, preventing duplicate entries.
  • Improved removal operations: Deletion of favorites now verifies existence first, ensuring a smoother and more consistent user experience.

[coderabbitai]

Walkthrough

This PR introduces changes to the handling of user favorites in both the backend and frontend. In the backend, the WorkspaceFavoriteEndpoint now checks for an existing favorite based on workspace, user, entity type, and identifier before creating a new one. In the frontend, the FavoriteStore updates its addFavorite and deleteFavorite methods to perform early checks against existing entries, avoiding redundant operations and unnecessary UUID generation.

Changes

File(s)	Change Summary
apiserver/…/workspace/favorite.py	Modified the post method to check for existing favorites using workspace, user, entity type, and entity identifier, returning the first match if available.
web/core/store/favorite.store.ts	In addFavorite, added a check for an existing entity in entityMap prior to generating a new UUID; in deleteFavorite, added a check to exit early if not found.

Possibly related PRs

• [WEB-3435]fix: add favorites #6652: Focuses on handling entity identifiers and preventing redundant favorite operations by checking for existing entries.
• fix: home quick start widget validation #6626: Modifies the addFavorite method to include a check for existing entries, indicating a direct relationship in their logic regarding favorite management.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• rahulramesha
• SatishGandham

Poem

I’m a rabbit with code in my paws,
Hopping through logic without any flaws.
I check for favorites, old and new,
Skipping re-creation like I always do.
With twitching whiskers, I celebrate the flow—
Code and carrots, off we go!
🐇🌟

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5d2869 and 9eb1a0d.

📒 Files selected for processing (1)

• apiserver/plane/app/views/workspace/favorite.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apiserver/plane/app/views/workspace/favorite.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.