feat(translations): add Slovak, Deutsch, Ukrainian and Polish translation#6743
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request enhances the localization system by adding Polish language support and updating existing translation files. The changes include adding a new language option in the constants and type definitions, updating the language import logic, and introducing complete translation files for Polish and German. Additionally, existing translation files in Slovak and Czech have been updated for terminology consistency. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant TranslationStore
participant PolishTranslationsFile
User->>UI: Select language "pl"
UI->>TranslationStore: Call importLanguageFile("pl")
alt Language Supported
TranslationStore->>PolishTranslationsFile: Import translations
PolishTranslationsFile-->>TranslationStore: Return Polish translations
TranslationStore-->>UI: Provide Polish translations
else Language Unsupported
TranslationStore-->>UI: Throw error
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
packages/i18n/src/store/index.ts (1)
165-166:⚠️ Potential issueDuplicate error throwing code.
There's a duplicate line for throwing an error for unsupported languages. The duplicated code should be removed.
Remove the redundant line:
default: throw new Error(`Unsupported language: ${language}`); } - throw new Error(`Unsupported language: ${language}`); } }
🧹 Nitpick comments (7)
packages/i18n/src/locales/de/translations.json (1)
169-2324: Overall File Structure and Consistency:
This new German translation file is highly comprehensive and maintains a clear, hierarchical organization that mirrors the application’s UI structure. Each major section—from"home"and"common"to detailed project, dashboard, and settings translations—uses precise language and appropriate placeholders (e.g.{seconds},{workspace}). Overall, the file is formatted correctly with valid JSON syntax.Suggestion for Future Improvements:
For long and comprehensive translation files such as this one, consider modularizing the content into smaller files (for example, grouping by feature or domain such as authentication, dashboard, settings, etc.). This can help to improve maintainability and ease future updates.packages/i18n/src/locales/sk/translations.json (6)
10-10: Update Sidebar Terminology – "views" replaced with "Pohľady".
This change updates the sidebar key to use the new standardized term for views.
293-295: Consistent Sidebar Label Update – "views" now reads "Pohľady".
The sidebar section now displays the updated term, ensuring uniformity with the changed terminology.
452-452: Clipboard Notification Text Revised.
The key"view_link_copied_to_clipboard"now correctly states "Odkaz na pohľad bol skopírovaný do schránky," aligning with the new terminology.
1124-1130: Updated "view" Object – Pluralization and Action Labels.
The changed lines update the plural forms and action labels:
• The label now correctly reads as{count, plural, one {Pohľad} few {Pohľady} other {Pohľadov}}.
• The corresponding action buttons now use "Vytvoriť pohľad" and "Aktualizovať pohľad."
This ensures that both singular and plural contexts consistently employ the new term.
1408-1408: "Add View" Button Label Updated.
The key"add_view"is now "Pridať pohľad," which adheres to the updated terminology for views.
2155-2156: Disabled Views Message Revised.
The messages now state "Pohľady nie sú povolené" and "Aktivujte pohľady v nastaveniach projektu." to clearly inform users that the views feature is disabled, using the updated term consistently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/sk/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)packages/i18n/src/locales/cs/translations.json(1 hunks)packages/i18n/src/locales/sk/translations.json(1 hunks)packages/i18n/src/locales/sk/translations.json(8 hunks)packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/de/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/pl/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (7)
packages/i18n/src/types/language.ts (1)
1-1:⚠️ Potential issueMissing Polish language in type definition.
The PR objectives mention adding Polish translations, but the
TLanguagetype only has Ukrainian added. Polish should also be included to maintain consistency across the localization system.Update the type definition to include Polish:
-export type TLanguage = "en" | "fr" | "es" | "ja" | "zh-CN" | "ru" | "it" | "cs" | "sk" | "de" | "ua"; +export type TLanguage = "en" | "fr" | "es" | "ja" | "zh-CN" | "ru" | "it" | "cs" | "sk" | "de" | "ua" | "pl";Likely an incorrect or invalid review comment.
packages/i18n/src/locales/cs/translations.json (1)
9-9: Good localization improvement.The translation of "workspace" to "Pracovní prostor" makes the Czech localization more natural by replacing the English term with a proper Czech equivalent.
packages/i18n/src/locales/de/translations.json (4)
1-20: Review of Sidebar Translations:
The"sidebar"object (lines 1–20) provides clear and succinct German translations for key UI elements such as"projects","pages","new_work_item", and others. The vocabulary (e.g. "Projekte", "Seiten", "Neues Arbeitselement") is appropriate and consistent with common German UI usage.
21-90: Review of Authentication Translations:
The"auth"section (lines 21–90) is detailed and well-organized. The labels, placeholders, error messages, and toast notifications (e.g."E-Mail ist erforderlich","Passwort festlegen","Passwörter stimmen nicht überein") accurately convey the intended meanings in German. The nested structure for fields like email and password is maintained correctly.
91-154: Review of Registration and Sign-In Flow Translations:
The sections for registration ("sign_up", lines 91–114) and sign-in ("sign_in", lines 115–132), as well as the forgotten password and reset flows (through line 154), are comprehensive and clearly articulate the required steps. The headers, sub-headers, and instructional texts are well translated. Verify that any empty strings (e.g. the"sub_header"in some steps) are intentional.
155-168: Review of Password Management and Sign-Out Translations:
The keys related to setting and changing the password (e.g."set_password","change_password", and their associated toast messages in lines 155–168) are descriptive and user-friendly. The German text is grammatically correct and aligns with best practices for password management messaging.packages/i18n/src/locales/pl/translations.json (1)
1-2324: Comprehensive Polish Translations File AddedThis new JSON file provides a complete set of Polish translations across all UI elements and messages in the application. The overall structure—with nested objects for sections like "sidebar", "auth", "forgot_password", etc.—is well organized and aligns with our existing i18n conventions.
Please verify the following aspects:
- Consistency & Accuracy: Ensure that every translation accurately conveys the intended meaning from the source language. In particular, review messages with ICU format placeholders (e.g.,
{seconds},{count, plural, one{...} few{...} other{...}}) so that they match our formatting conventions and are consistent with translations in other languages.- Structural Alignment: Check that the keys mirror those in other locale files (e.g., for Slovak, Deutsch, and Ukrainian) so that updates to keys or usage in the codebase do not result in mismatches.
- Contextual Relevance: Review complex sections (especially nested sections like authentication flows, notifications, and error messages) to confirm that regional or cultural nuances are accurately reflected for Polish users.
Overall, the implementation is comprehensive. If the translations have been validated by native speakers and align with our project’s i18n guidelines, then this addition should enhance the localization support effectively.
sriramveeraghanta
changed the base branch from
preview
to
feat-core-translations
sriramveeraghanta
merged commit 6da970d
into
makeplane:feat-core-translations
* feat(translations): add Korean translation (#6755) * feat(translations): init Korean translation Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> * feat(translations): add rough Korean translation Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> --------- Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> * feat(translations): add Slovak, Deutsch, Ukrainian and Polish translation (#6743) * feat(translation): add Slovak translation * feat(translation): add Slovak translation for workspace * feat(translation): improved Slovak translation for views * feat(translation): add Deutsch translation * feat(translation): add Ukrainian translation * feat(translation): add Polish translation --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * fix: project cycle translations * fix: build error * feat: Add zh-TW Traditional Chinese locale (#6764) Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * chore: zh-TW core translation updated --------- Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> Co-authored-by: Ján Regeš <jan.reges@gmail.com> Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> Co-authored-by: Peter Dave Hello <hsu@peterdavehello.org>
* feat(translations): add Korean translation (#6755) * feat(translations): init Korean translation Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> * feat(translations): add rough Korean translation Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> --------- Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> * feat(translations): add Slovak, Deutsch, Ukrainian and Polish translation (#6743) * feat(translation): add Slovak translation * feat(translation): add Slovak translation for workspace * feat(translation): improved Slovak translation for views * feat(translation): add Deutsch translation * feat(translation): add Ukrainian translation * feat(translation): add Polish translation --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * fix: project cycle translations * fix: build error * feat: Add zh-TW Traditional Chinese locale (#6764) Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * chore: zh-TW core translation updated --------- Co-authored-by: NavyStack <navystack@askfront.com> Co-authored-by: FVOCI <150913557+fvoci@users.noreply.github.com> Co-authored-by: Ján Regeš <jan.reges@gmail.com> Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> Co-authored-by: Peter Dave Hello <hsu@peterdavehello.org>
2 participants
Description
This PR adds support for Slovak, Deutsch, Ukrainian and Polish translations.
Type of Change
Summary by CodeRabbit
New Features
Localization Updates