Skip to content

[WEB-4546] chore: home update#7456

Merged
pushya22 merged 1 commit intopreviewfrom
chore-home-ui-update
Jul 23, 2025
Merged

[WEB-4546] chore: home update#7456
pushya22 merged 1 commit intopreviewfrom
chore-home-ui-update

Conversation

@gakshita
Copy link
Collaborator

@gakshita gakshita commented Jul 22, 2025

Description

  • Updated home width & center aligned

Summary by CodeRabbit

  • New Features

    • Added internationalization support for greeting messages, enabling localized text display.
  • Style

    • Improved layout and spacing for greeting components, including increased container width and responsive padding.
    • Adjusted visibility of button text labels to show only on medium screens and larger.
    • Updated heading tags to use more appropriate semantic levels for accessibility and structure.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

This update adjusts UI elements for improved layout and accessibility. It changes the visibility of a button label in the workspace header, updates container width and padding in the home root component, modifies heading levels for semantic correctness, and introduces internationalization and styling improvements to the user greetings component.

Changes

File(s) Change Summary
apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx Modified button label visibility: label now only shown on medium+ screens using responsive utility classes.
apps/web/core/components/home/root.tsx Increased container max width to 800px and added responsive horizontal padding classes.
apps/web/core/components/home/user-greetings.tsx Changed heading tags: main greeting from <h3> to <h2>, subheading from <h6> to <h5>.
apps/web/core/components/user/user-greetings.tsx Added i18n support for greetings, changed heading tags, and updated styling classes for improved layout.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UserGreetingsView
    participant i18n (useTranslation)

    User->>UserGreetingsView: Render component
    UserGreetingsView->>i18n (useTranslation): Get translation function t()
    UserGreetingsView->>UserGreetingsView: Format greeting using t()
    UserGreetingsView-->>User: Display localized greeting and date/time
Loading

Estimated code review effort

2 (~15 minutes)

Possibly related PRs

Suggested labels

🌐frontend, 🧹chore

Suggested reviewers

  • prateekshourya29

Poem

A button now hides its label small,
While greetings say "hello" to all.
Wider roots and headings anew,
With translations joining the view.
A hop, a skip, a UI tweak—
The frontend's looking quite unique!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 763a28a and 2cbe20b.

📒 Files selected for processing (4)
  • apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1 hunks)
  • apps/web/core/components/home/root.tsx (1 hunks)
  • apps/web/core/components/home/user-greetings.tsx (1 hunks)
  • apps/web/core/components/user/user-greetings.tsx (3 hunks)
🧠 Learnings (2)
apps/web/core/components/home/root.tsx (1)

Learnt from: lifeiscontent
PR: #7164
File: packages/ui/.storybook/main.ts:24-47
Timestamp: 2025-06-04T16:22:44.344Z
Learning: In packages/ui/.storybook/main.ts, the webpackFinal function intentionally overrides the CSS loader strategy by finding and replacing existing CSS rules. This is a temporary workaround for a known upstream issue in Storybook's CSS handling that has been communicated to the Storybook maintainers. The current implementation should not be changed until the upstream issue is resolved.

apps/web/core/components/user/user-greetings.tsx (2)

Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".

Learnt from: vamsikrishnamathala
PR: #7061
File: web/core/components/workspace-notifications/root.tsx:18-18
Timestamp: 2025-05-14T13:16:23.323Z
Learning: In the Plane project codebase, the path alias @/plane-web resolves to the ce directory, making imports like @/plane-web/hooks/use-notification-preview correctly resolve to files in web/ce/hooks/.

🧬 Code Graph Analysis (4)
apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
apps/web/core/components/home/user-greetings.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
apps/web/core/components/home/root.tsx (2)
packages/ui/src/content-wrapper/content-wrapper.tsx (1)
  • ContentWrapper (36-36)
packages/utils/src/common.ts (1)
  • cn (8-8)
apps/web/core/components/user/user-greetings.tsx (2)
packages/i18n/src/hooks/use-translation.ts (1)
  • useTranslation (23-35)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
🧰 Additional context used
🧠 Learnings (2)
apps/web/core/components/home/root.tsx (1)

Learnt from: lifeiscontent
PR: #7164
File: packages/ui/.storybook/main.ts:24-47
Timestamp: 2025-06-04T16:22:44.344Z
Learning: In packages/ui/.storybook/main.ts, the webpackFinal function intentionally overrides the CSS loader strategy by finding and replacing existing CSS rules. This is a temporary workaround for a known upstream issue in Storybook's CSS handling that has been communicated to the Storybook maintainers. The current implementation should not be changed until the upstream issue is resolved.

apps/web/core/components/user/user-greetings.tsx (2)

Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".

Learnt from: vamsikrishnamathala
PR: #7061
File: web/core/components/workspace-notifications/root.tsx:18-18
Timestamp: 2025-05-14T13:16:23.323Z
Learning: In the Plane project codebase, the path alias @/plane-web resolves to the ce directory, making imports like @/plane-web/hooks/use-notification-preview correctly resolve to files in web/ce/hooks/.

🧬 Code Graph Analysis (4)
apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
apps/web/core/components/home/user-greetings.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
apps/web/core/components/home/root.tsx (2)
packages/ui/src/content-wrapper/content-wrapper.tsx (1)
  • ContentWrapper (36-36)
packages/utils/src/common.ts (1)
  • cn (8-8)
apps/web/core/components/user/user-greetings.tsx (2)
packages/i18n/src/hooks/use-translation.ts (1)
  • useTranslation (23-35)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
🔇 Additional comments (6)
apps/web/core/components/home/user-greetings.tsx (1)

45-47: LGTM! Improved semantic HTML structure.

The heading level changes from <h3> to <h2> and <h6> to <h5> provide better semantic hierarchy and accessibility. This aligns with the similar improvements made in the corresponding user greetings component.

Also applies to: 48-53

apps/web/core/components/home/root.tsx (1)

63-65: LGTM! Improved layout with responsive padding.

The changes enhance the layout by:

  • Increasing max-width from 750px to 800px for more content space
  • Adding responsive horizontal padding (px-page-x lg:px-0) that provides padding on smaller screens while removing it on large screens for better responsiveness

This aligns well with the overall UI improvements in this PR.

apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)

49-49: LGTM! Good responsive design for better mobile experience.

The responsive visibility classes (hidden sm:hidden md:block) appropriately hide the button label on smaller screens to save space while keeping it visible on medium screens and above where there's sufficient room. This follows good responsive design patterns.

apps/web/core/components/user/user-greetings.tsx (3)

3-3: LGTM! Excellent internationalization integration.

The addition of the useTranslation hook properly enables localization support for this component. The import organization and comment structure are clean and follow established patterns.

Also applies to: 17-18


44-47: LGTM! Improved layout and semantic structure with i18n support.

Great improvements here:

  • Added responsive layout with flex flex-col items-center my-6
  • Upgraded semantic HTML from <h3> to <h2> with proper styling
  • Properly implemented internationalization using t("good") and t(greeting) for dynamic translation support

The translation keys follow a logical pattern and will work well with the i18n system.


48-53: LGTM! Consistent semantic improvements.

The heading level change from <h6> to <h5> maintains consistency with the main heading upgrade and provides better semantic hierarchy. The emoji and time display functionality remains intact.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 changed the title chore: home update [WEB-4546] chore: home update Jul 23, 2025
@makeplane
Copy link

makeplane bot commented Jul 23, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@pushya22 pushya22 merged commit 9007ec3 into preview Jul 23, 2025
5 of 6 checks passed
@pushya22 pushya22 deleted the chore-home-ui-update branch July 23, 2025 04:41
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants