Skip to content

add Turkish language support#6874

Merged
anmolsinghbhatia merged 2 commits intomakeplane:feat-turkish-language-supportfrom
fasdjkherig:feat-turkish-language-support
Apr 12, 2025
Merged

add Turkish language support#6874
anmolsinghbhatia merged 2 commits intomakeplane:feat-turkish-language-supportfrom
fasdjkherig:feat-turkish-language-support

Conversation

@fasdjkherig
Copy link
Contributor

@fasdjkherig fasdjkherig commented Apr 6, 2025

Description

add Turkish language support

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • New Features
    • Introduced Turkish language support with complete localized content for user interface elements and notifications.
    • Enhanced the language selection experience by adding Turkish as an option for end-users.
    • Added a new JSON file with Turkish translations for various actions and messages.

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2025

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 6, 2025

Walkthrough

The changes add support for the Turkish language. A new Turkish language entry has been included in the supported languages constant and type definitions, a new JSON file with Turkish translations has been created, and the translation store has been updated with logic to import this file based on the "tr" code. No other functionality was altered.

Changes

File(s) Change Summary
packages/i18n/src/constants/language.ts
packages/i18n/src/types/language.ts
Added Turkish language ("tr" with label "Türkçe") to the supported languages constant and type definition.
packages/i18n/src/locales/tr/translations.json Added a new JSON file containing Turkish translations for various UI elements and messages.
packages/i18n/src/store/index.ts Updated the importLanguageFile method to include a case for Turkish, importing its translation file.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant A as Application
    participant TS as TranslationStore
    participant JSON as TurkishTranslations.json

    U->>A: Select Turkish language ("tr")
    A->>TS: importLanguageFile("tr")
    TS->>JSON: Load Turkish translation data
    JSON-->>TS: Return Turkish translations
    TS-->>A: Provide translation data
    A->>U: Render UI with Turkish translations
Loading

Poem

I’m a little bunny, hopping with glee,
Adding Turkish tongues for all to see.
New translations bloom in JSON’s clear art,
In code fields where language plays its part.
Hop along with joy, a language new and smart!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a7f48c4 and 27cb952.

📒 Files selected for processing (1)
  • packages/i18n/src/store/index.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/i18n/src/store/index.ts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/i18n/src/store/index.ts (1)

176-177: Fix indentation to match existing pattern.

The indentation for the Turkish language case doesn't match the pattern used for other languages in the switch statement. Consider aligning it with the existing cases.

-        case "tr":
-        return import("../locales/tr/translations.json");
+      case "tr":
+        return import("../locales/tr/translations.json");
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34337f9 and a7f48c4.

📒 Files selected for processing (4)
  • packages/i18n/src/constants/language.ts (1 hunks)
  • packages/i18n/src/locales/tr/translations.json (1 hunks)
  • packages/i18n/src/store/index.ts (1 hunks)
  • packages/i18n/src/types/language.ts (1 hunks)
🔇 Additional comments (3)
packages/i18n/src/constants/language.ts (1)

24-24: LGTM! Turkish language added correctly.

The Turkish language option has been properly added to the SUPPORTED_LANGUAGES constant with the correct label "Türkçe" and ISO language code "tr".

packages/i18n/src/types/language.ts (1)

19-20: LGTM! Turkish language type added correctly.

The "tr" language code has been properly added to the TLanguage type definition, which ensures type safety when using it throughout the application.

packages/i18n/src/locales/tr/translations.json (1)

1-2273: Turkish translations look good.

The Turkish translations file has been added with comprehensive translation entries covering UI elements, messages, errors, and various other text across the application. The JSON structure is valid and consistent with other language files.

@fasdjkherig
Copy link
Contributor Author

Hi @prateekshourya29 could you please take a look at my PR

@anmolsinghbhatia anmolsinghbhatia changed the base branch from preview to feat-turkish-language-support April 12, 2025 12:42
@anmolsinghbhatia anmolsinghbhatia merged commit eb44c46 into makeplane:feat-turkish-language-support Apr 12, 2025
2 of 3 checks passed
sriramveeraghanta pushed a commit that referenced this pull request Apr 15, 2025
* add Turkish language support (#6874)

* add turkish language support

* fix indentation

* chore: extended core translation added

* chore: code refactor

---------

Co-authored-by: Farahat Abdrabouh <88924701+fasdjkherig@users.noreply.github.com>
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
* add Turkish language support (#6874)

* add turkish language support

* fix indentation

* chore: extended core translation added

* chore: code refactor

---------

Co-authored-by: Farahat Abdrabouh <88924701+fasdjkherig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants