add Turkish language support#6874
add Turkish language support#6874anmolsinghbhatia merged 2 commits intomakeplane:feat-turkish-language-supportfrom
Conversation
WalkthroughThe changes add support for the Turkish language. A new Turkish language entry has been included in the supported languages constant and type definitions, a new JSON file with Turkish translations has been created, and the translation store has been updated with logic to import this file based on the "tr" code. No other functionality was altered. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as Application
participant TS as TranslationStore
participant JSON as TurkishTranslations.json
U->>A: Select Turkish language ("tr")
A->>TS: importLanguageFile("tr")
TS->>JSON: Load Turkish translation data
JSON-->>TS: Return Turkish translations
TS-->>A: Provide translation data
A->>U: Render UI with Turkish translations
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/i18n/src/store/index.ts (1)
176-177: Fix indentation to match existing pattern.The indentation for the Turkish language case doesn't match the pattern used for other languages in the switch statement. Consider aligning it with the existing cases.
- case "tr": - return import("../locales/tr/translations.json"); + case "tr": + return import("../locales/tr/translations.json");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/tr/translations.json(1 hunks)packages/i18n/src/store/index.ts(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
🔇 Additional comments (3)
packages/i18n/src/constants/language.ts (1)
24-24: LGTM! Turkish language added correctly.The Turkish language option has been properly added to the
SUPPORTED_LANGUAGESconstant with the correct label "Türkçe" and ISO language code "tr".packages/i18n/src/types/language.ts (1)
19-20: LGTM! Turkish language type added correctly.The "tr" language code has been properly added to the
TLanguagetype definition, which ensures type safety when using it throughout the application.packages/i18n/src/locales/tr/translations.json (1)
1-2273: Turkish translations look good.The Turkish translations file has been added with comprehensive translation entries covering UI elements, messages, errors, and various other text across the application. The JSON structure is valid and consistent with other language files.
|
Hi @prateekshourya29 could you please take a look at my PR |
eb44c46
into
makeplane:feat-turkish-language-support
* add Turkish language support (#6874) * add turkish language support * fix indentation * chore: extended core translation added * chore: code refactor --------- Co-authored-by: Farahat Abdrabouh <88924701+fasdjkherig@users.noreply.github.com>
* add Turkish language support (#6874) * add turkish language support * fix indentation * chore: extended core translation added * chore: code refactor --------- Co-authored-by: Farahat Abdrabouh <88924701+fasdjkherig@users.noreply.github.com>
Description
add Turkish language support
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit