[WEB-3855] fix: Turkish language support#7383
[WEB-3855] fix: Turkish language support#7383sriramveeraghanta merged 2 commits intomakeplane:previewfrom
Conversation
|
Bektaş IŞIK seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughThe Turkish translation file for the application was updated, replacing incorrect, placeholder, or phonetic Turkish strings with accurate translations in the "sidebar" and "auth" sections. Only the string values were changed, ensuring correct and meaningful Turkish localization without modifying any structure or keys. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/i18n/src/locales/tr-TR/translations.json (1)
627-670: Potentially confusing duplicate top-level keysTop-level keys such as
error,loading,warning,analytics,upgrade,projectsetc. coexist with section-level keys of the same English name (e.g.sidebar.analytics,common.loading).
This is legal JSON, yet developers/readers can easily pick the wrong key when coding. A common convention in Plane is to keep truly global items incommonand avoid bare top-level duplicates.Consider moving these globals under
common(or another namespace) to reduce lookup-time ambiguity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/i18n/src/locales/tr-TR/translations.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: janreges
PR: makeplane/plane#6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
packages/i18n/src/locales/tr-TR/translations.json (2)
Learnt from: janreges
PR: makeplane/plane#6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
Learnt from: vamsikrishnamathala
PR: makeplane/plane#7092
File: web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx:109-113
Timestamp: 2025-05-22T11:21:49.370Z
Learning: Both translation keys "sub_work_item.empty_state.list_filters.action" and "sub_work_item.empty_state.sub_list_filters.action" have identical values across all language files in the Plane project, so they can be used interchangeably.
🔇 Additional comments (1)
packages/i18n/src/locales/tr-TR/translations.json (1)
1-2507: JSON syntax & duplicate keys check passed
✅ Verified thatpackages/i18n/src/locales/tr-TR/translations.jsonis syntactically valid and contains no duplicate keys at the same depth. No further action required.
bektasisik
changed the title
|
@bektasisik could you please sign the CLA. |
|
i already did signed. @pushya22 |
5 participants
Description
Turkish language support, translated from English pronunciations to their real equivalents.
Type of Change
Summary by CodeRabbit
Summary by CodeRabbit