Skip to content

[WEB-3693] chore: cmd-k work item actions improvements#6891

Merged
pushya22 merged 2 commits intopreviewfrom
chore-cmd-k-work-item-action
Apr 9, 2025
Merged

[WEB-3693] chore: cmd-k work item actions improvements#6891
pushya22 merged 2 commits intopreviewfrom
chore-cmd-k-work-item-action

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Apr 8, 2025

Description

This PR includes improvement for cmd-k work item actions.

Type of Change

  • Improvement

References

[WEB-3693]

Summary by CodeRabbit

  • New Features
    • Command palette actions now display dynamic labels: “Epic actions” for epics and “Work item actions” for standard issues.
    • Action text for functions like deletion and URL copying now adjusts contextually based on the issue type.
    • Issue update interactions have been refined for behavior that aligns with whether an item is an epic or a work item.
    • Toast notification message updated to specify that a link has been copied to the clipboard.

@makeplane
Copy link

makeplane bot commented Apr 8, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 8, 2025

Walkthrough

The changes update several command palette action components to conditionally pass a service type to the useIssueDetail hook based on whether the issue is classified as an epic. This adjustment alters the behavior of the updateIssue function, allowing for distinct handling of epics versus standard work items. Additionally, dynamic UI text is introduced in the actions list to reflect the issue type, modifying headings and action labels accordingly.

Changes

File Path(s) Change Summary
web/.../actions-list.tsx Added import for EIssueServiceType; updated updateIssue hook call to use a conditional parameter (epic vs. standard); introduced dynamic actionHeading and entityType to adjust UI text (e.g., "Epic actions" vs. "Work item actions", "Delete ${entityType}", "Copy ${entityType} URL").
web/.../change-assignee.tsx, web/.../change-priority.tsx, web/.../change-state.tsx Modified useIssueDetail hook calls to conditionally pass EIssueServiceType.EPICS (if epic) or EIssueServiceType.ISSUES (if standard). In change-priority.tsx, updated the import to include EIssueServiceType.
web/.../header.tsx Updated toast notification message from t("common.copied_to_clipboard") to t("common.link_copied_to_clipboard").

Sequence Diagram(s)

sequenceDiagram
    participant UI as Component
    participant Hook as useIssueDetail Hook
    participant Service as Issue Service

    UI->>Hook: Call useIssueDetail(issue?.is_epic ? EPICS : ISSUES)
    alt Issue is Epic
        Note over UI,Hook: Using EPICS service type
    else Issue is Work Item
        Note over UI,Hook: Using ISSUES service type
    end
    Hook-->>UI: Return updateIssue function
    UI->>Service: Call updateIssue(data)
Loading

Poem

Hop along, my dear code friend,
Dynamic hues now blend and mend.
Epics and work items, clear as day,
With service types to lead the way.
A rabbit’s leap in code so bright—
Here's to changes that feel just right! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6fbca and 9a918c3.

📒 Files selected for processing (1)
  • web/core/components/issues/peek-overview/header.tsx (1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
web/core/components/issues/peek-overview/header.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (231-252)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
web/core/components/issues/peek-overview/header.tsx (1)

114-114: Improved notification message for link copying

Changing from a generic clipboard message to a more specific "link copied to clipboard" message improves clarity for users. This enhancement provides better context about what exactly was copied, aligning with the PR's goal of improving work item actions.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants