[WEB-4017] fix: hooks and store refactoring for issue-details#7107
[WEB-4017] fix: hooks and store refactoring for issue-details#7107sriramveeraghanta merged 8 commits intopreviewfrom
Conversation
WalkthroughA new hook, Changes
Sequence Diagram(s)sequenceDiagram
participant Component as IssueDetailsPage / IssuePeekOverview
participant Hook as useWorkItemProperties
Component->>Hook: useWorkItemProperties(projectId, workspaceSlug, workItemId, issueServiceType)
Note right of Hook: Returns early if any parameter is falsy
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
web/app/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx(2 hunks)web/ce/hooks/use-issue-properties.tsx(1 hunks)web/ce/store/issue/issue-details/root.store.ts(1 hunks)web/core/components/issues/peek-overview/root.tsx(2 hunks)web/core/hooks/store/use-issue-detail.ts(1 hunks)web/core/store/issue/root.store.ts(1 hunks)web/ee/hooks/use-issue-properties.tsx(1 hunks)web/ee/store/issue/issue-details/root.store.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (3)
web/ce/hooks/use-issue-properties.tsx (1)
web/core/store/router.store.ts (2)
projectId(85-87)workspaceSlug(69-71)
web/app/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx (2)
web/ce/hooks/use-issue-properties.tsx (1)
useWorkItemProperties(1-1)web/core/store/router.store.ts (3)
projectId(85-87)workspaceSlug(69-71)issueId(149-151)
web/core/components/issues/peek-overview/root.tsx (1)
web/ce/hooks/use-issue-properties.tsx (1)
useWorkItemProperties(1-1)
🔇 Additional comments (7)
web/core/hooks/store/use-issue-detail.ts (1)
7-7: Import path updated for new store structure.The import path change aligns with the store restructuring to separate CE and EE implementations. This improves modularity and maintainability.
web/core/store/issue/root.store.ts (1)
8-8: Import path updated for consistent store architecture.The change from relative to absolute import path supports the new modular store structure and improves code organization.
web/core/components/issues/peek-overview/root.tsx (1)
26-26: Import statement for new hook.The import path follows the new module structure established in the PR.
web/app/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx (1)
19-19: Import path looks good.The import statement correctly references the hook from the unified path that handles both CE and EE versions.
web/ee/hooks/use-issue-properties.tsx (1)
1-1: Good use of re-export pattern for CE/EE separation.This follows the established architectural pattern where EE modules proxy CE implementations, allowing for future enterprise-specific overrides while maintaining a unified import path.
web/ee/store/issue/issue-details/root.store.ts (1)
1-1: Consistent re-export pattern for store separation.This maintains the established CE/EE architectural pattern, allowing enterprise editions to extend or override the community edition store implementation when needed.
web/ce/store/issue/issue-details/root.store.ts (1)
1-5: Imports and type definitions look correct.The imports properly reference the core store components and required types. The type re-export maintains interface consistency.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx(3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
web/app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx (2)
web/ce/hooks/use-issue-properties.tsx (1)
useWorkItemProperties(3-10)web/core/store/router.store.ts (3)
projectId(85-87)workspaceSlug(69-71)issueId(149-151)
🔇 Additional comments (2)
web/app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx (2)
9-9: LGTM!The enum import is clean and follows established patterns.
20-20: LGTM!The hook import follows the established import structure and naming conventions.
gakshita
changed the title
…t-pages-in-work-items
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/settings/content-wrapper.tsx (1)
15-15: Mobile padding eliminated – confirm UX intentSwitching from
p-4tomd:px-4removes all horizontal padding on screens smaller than themdbreakpoint. Content in the settings view will now sit flush against the viewport edge on mobile, which can feel cramped and mis-aligned compared to other pages that keep a baselinepx-4/px-6.If that wasn’t a deliberate design call, consider re-introducing a small-screen padding:
- "md:px-4 max-w-[800px] 2xl:max-w-[1000px]": size === "md", + "px-4 md:px-4 max-w-[800px] 2xl:max-w-[1000px]": size === "md",(or
sm:px-4if you prefer Tailwind’ssmbreakpoint).Please verify across the mobile breakpoints before merging.
* fix: hooks and store splitting for issue-details * fix: refactoring * fix: refactoring * fix: refactor * fix: css
4 participants
Description
References
[WEB-4017]
Summary by CodeRabbit