[WEB-3863] fix: links error handling

[gakshita]

Description

For issue links the success toast was getting displayed even on failure. Thrown error for the toast to display correctly.

References

[WEB-3863]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for issue link updates, ensuring errors are now properly reported to users.

[coderabbitai]

Walkthrough

The error handling in the updateLink method of the IssueLinkStore class was updated. Now, if an error occurs during the update, the method reverts the local link data and rethrows the error, instead of returning the initial data as before.

Changes

File(s)	Change Summary
web/core/store/issue/issue-details/link.store.ts	Modified error handling in updateLink to rethrow errors after revert

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant IssueLinkStore

    Caller->>IssueLinkStore: updateLink(link)
    alt Success
        IssueLinkStore-->>Caller: updated link data
    else Error occurs
        IssueLinkStore->>IssueLinkStore: revert local link data
        IssueLinkStore-->>Caller: throw error
    end

Loading

Possibly related PRs

• [WEB-3863] fix: handled error handling for link editing #6968: Directly related as it also modifies error handling in the same method and file.

Suggested labels

🐛bug

Suggested reviewers

• anmolsinghbhatia
• sriramveeraghanta

Poem

A bug in the link was caught in the act,
Now errors don’t slip by—they’re sent right back!
With a hop and a jump, the state will revert,
And if trouble returns, you’ll know where it hurt.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04c7c53 and 2b113bf.

📒 Files selected for processing (1)

• web/core/store/issue/issue-details/link.store.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

web/core/store/issue/issue-details/link.store.ts (1)

144-144: LGTM! Proper error propagation for better UX.

This change correctly addresses the issue where success toast notifications were displayed even on failures. By throwing the error instead of returning the initial data, the calling code can now properly handle the error case and display appropriate error messages to users.

The optimistic update pattern with rollback on error is preserved, and the error is now properly propagated as it should be.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-3863] Link Updates Despite Invalid Format

Comment Automatically Generated by Plane