Feature implementation from commits 193ae9b..322af8c

[codeOwlAI]

PR Summary

Editor Improvements: Refactoring and File Handling Enhancements

Overview

This PR implements substantial code refactoring across the editor codebase, replacing string literals with constants from CORE_EXTENSIONS for improved maintainability. It also introduces a new UtilityExtension for file operations, enhances type safety, and improves file handling capabilities.

Change Types

Type	Description
Refactor	Replace string literals with CORE_EXTENSIONS constants throughout the codebase
Enhancement	Add UtilityExtension for file handling and WorkItemEmbed functionality
Enhancement	Improve file upload, deletion and restoration capabilities
Refactor	Improve type safety by replacing 'any' types with specific types
Bugfix	Fix error handling in file operations

---

Affected Modules

Module / File	Change Description
editor/src/core/extensions/	Added UtilityExtension, refactored to use constants, updated module exports
editor/src/core/helpers/	Improved file handling, image restoration, error handling
editor/src/core/hooks/	Updated editor hooks to use utility extension for file operations
editor/src/core/plugins/	Added new plugins for file drop, deletion, and restoration
i18n/	Refactored translation file handling
types/	Added new fields to user and project interfaces
core/store/	Enhanced settings management and UI state handling

---

Notes for Reviewers

• The refactoring of string literals to constants is extensive and touches many files
• The new file handling approach centralizes upload status management in the UtilityExtension
• Type safety improvements should make the codebase more robust

---

Additional Context

• URL structure for project settings has changed, with redirects added in Next.js config
• The editor's preserveWhitespace setting has been standardized to use boolean true instead of string "full"

[codeowlai]

🔒 Security Issue

Security: File Validation Removed.

All file validation logic (MIME type and size checks) has been removed, allowing any file type to be uploaded which creates a security vulnerability.

Current Code (Diff):

-   const { editor, filesList, pos, type, uploader } = args;
-   const filesArray = Array.from(filesList);
-   if (filesArray.length === 0) {
+   const { editor, filesList, pos, type, uploader } = args;
+   const filesArray = [];
+   for (let i = 0; i < filesList.length; i += 1) {
+     const file = filesList.item(i);
+     if (file) {
+       filesArray.push(file);
+     }
+   }
+   if (filesArray.length === 0) {

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	const { editor, filesList, pos, type, uploader } = args;
	const filesArray = Array.from(filesList);
	if (filesArray.length === 0) {
	const { editor, filesList, pos, type, uploader } = args;
	const filesArray = [];
	for (let i = 0; i < filesList.length; i += 1) {
	const file = filesList.item(i);
	if (file) {
	filesArray.push(file);
	}
	}
	if (filesArray.length === 0) {

🔄 Dependencies Affected

packages/editor/src/core/hooks/use-file-upload.ts

Function: useDropZone

Issue: The useDropZone hook calls uploadFirstFileAndInsertRemaining without validation parameters, expecting validation to happen inside the function

Suggestion: Add validation parameters to the uploadFirstFileAndInsertRemaining call or implement validation before calling it

---

[codeowlai]

🐛 Correctness Issue

Incorrect event type in paste handler.

The handlePaste function uses 'drop' as the event type instead of 'paste', which will cause incorrect tracking and processing of pasted files.

Current Code (Diff):

-               event: "drop",
+               event: "paste",

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	event: "drop",
	event: "paste",

🔄 Dependencies Affected

packages/editor/src/core/extensions/custom-image/custom-image.ts

Function: insertImageComponent

Issue: The insertImageComponent function uses the event parameter for tracking files, so using an incorrect event type will cause improper tracking

Suggestion: Update the event parameter to 'paste' to ensure proper file tracking

---

[codeowlai]

🐛 Correctness Issue

Empty attachment file handler.

The code detects attachment files but has an empty implementation for handling them, causing a silent failure where users can drop attachments but nothing happens.

Current Code (Diff):

-      } else if (fileType === "attachment") {
+      } else if (fileType === "attachment") {
+        // TODO: Implement attachment handling
+        console.error("Attachment handling not implemented yet");

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	} else if (fileType === "attachment") {
	}
	} else if (fileType === "attachment") {
	// TODO: Implement attachment handling
	console.error("Attachment handling not implemented yet");
	}

[codeowlai]

🐛 Correctness Issue

Breaking API Change: Error Propagation.

This change modifies error handling to throw errors instead of returning initial data, which could cause application crashes if callers aren't prepared to handle these exceptions.

Current Code (Diff):

-       return initialData;
+       throw error;