[WEB-4223] fix: remove build process from utils package#7138
[WEB-4223] fix: remove build process from utils package#7138sriramveeraghanta merged 1 commit intopreviewfrom
Conversation
WalkthroughThe changes update the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items
Comment Automatically Generated by Plane |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/utils/package.json (1)
10-13: Add a type-checking script for early error detection
Since the build process has been removed, consider adding atypecheckscript (tsc --noEmit) to catch type errors during development. This helps maintain type safety without requiring output artifacts.
Apply this diff:--- a/packages/utils/package.json +++ b/packages/utils/package.json @@ "scripts": { "lint": "eslint src --ext .ts,.tsx", "lint:errors": "eslint src --ext .ts,.tsx --quiet", + "typecheck": "tsc --noEmit" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
packages/utils/package.json(1 hunks)packages/utils/src/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/utils/package.json (1)
7-9: Verify TypeScript entry points inpackage.json
Ensure consuming environments (Node.js, bundlers, or the TypeScript compiler) can resolve and transpile.tsentry points without a build step. Without compiled outputs, imports likeimport { foo } from "@plane/utils"must be supported via an appropriate loader or toolchain configuration.packages/utils/src/index.ts (3)
9-9: Approve repositioning ofget-icon-for-linkexport
Movingexport * from "./get-icon-for-link";adjacent to related utilities improves logical grouping. No duplicates detected.
13-13: Approve relocation ofsubscriptionexport
Consolidatingexport * from "./subscription";enhances the consistency of the export order. Looks good.
16-16: Approveworkspaceexport ordering
Reorderingexport * from "./workspace";aligns with the new grouping strategy. No functional changes detected.
Description
This pull request addresses the removal of the build process from the utils package. The build process was deemed unnecessary for this package, as it primarily contains utility functions that do not require compilation or transformation.
Type of Change
Summary by CodeRabbit
Chores
Refactor