Skip to content

[WEB-3787] fix: project joining date#7127

Merged
sriramveeraghanta merged 3 commits intopreviewfrom
fix-project-joining-date
May 30, 2025
Merged

[WEB-3787] fix: project joining date#7127
sriramveeraghanta merged 3 commits intopreviewfrom
fix-project-joining-date

Conversation

@sangeethailango
Copy link
Member

@sangeethailango sangeethailango commented May 27, 2025

Description

  • Fixed wrong display of member's project joining date in settings

Summary by CodeRabbit

  • New Features

    • Project membership details now display the date when a member joined a project.
    • User profiles may now show a joining date if available.
  • Enhancements

    • Project member information includes additional timestamp details for improved visibility.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 27, 2025

Walkthrough

The changes introduce a new created_at timestamp field to project membership data across both backend and frontend code. Serializers and TypeScript interfaces are updated to include this field, and frontend logic is adjusted to use created_at as a member's joining_date in computed member details. An optional joining_date is also added to user types.

Changes

File(s) Change Summary
apiserver/plane/app/serializers/project.py Added created_at to ProjectMemberRoleSerializer fields and marked it as read-only.
packages/types/src/project/projects.d.ts Added created_at: string to IProjectMembership interface.
packages/types/src/users.d.ts Added optional joining_date?: string to IUserLite interface.
web/core/store/member/project-member.store.ts Updated getProjectMemberDetails to set member's joining_date from membership's created_at.

Sequence Diagram(s)

sequenceDiagram
    participant Backend as Backend Serializer
    participant Frontend as Frontend Store
    participant UI as User Interface

    Backend->Frontend: Send project member data (includes created_at)
    Frontend->Frontend: Map created_at to member.joining_date
    Frontend->UI: Provide enriched member details (with joining_date)
Loading

Suggested reviewers

  • prateekshourya29

Poem

In the warren of code, a new field appears—
created_at marks the start of our peers.
Now rabbits can see when friends joined the quest,
With joining_date hopping into each member's nest.
TypeScript and Python, in harmony sing,
Welcoming timestamps—let the histories spring!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f82be1 and 9c83fbf.

📒 Files selected for processing (1)
  • apiserver/plane/app/serializers/project.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apiserver/plane/app/serializers/project.py
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sangeethailango sangeethailango changed the title fix: return project joining date [WEB-3787] fix: project joining date May 27, 2025
@sangeethailango sangeethailango marked this pull request as draft May 27, 2025 13:31
@makeplane
Copy link

makeplane bot commented May 27, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@gakshita gakshita marked this pull request as ready for review May 27, 2025 13:59
@sriramveeraghanta sriramveeraghanta merged commit a0a6974 into preview May 30, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-project-joining-date branch May 30, 2025 12:53
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
* fix: return project joining date

* fix: added project's joining date

* fix: set created_at as read_only_fields

---------

Co-authored-by: gakshita <akshitagoyal1516@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants