[WEB-4249] fix: ensure user details are available in project member details computation

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability when viewing project member details by ensuring information is only shown when both membership and user details are available, preventing potential display issues.

[coderabbitai]

Walkthrough

The internal logic of the getProjectMemberDetails method in the project member store was updated to include an additional check for the presence of user details in the member map. The method now returns null if either project membership or user details are missing, preventing undefined access.

Changes

File(s)	Change Summary
web/core/store/member/base-project-member.store.ts	Updated getProjectMemberDetails to check for user details existence before returning member.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Store

    Caller->>Store: getProjectMemberDetails(projectId, memberId)
    Store->>Store: Check project membership
    alt Membership missing
        Store-->>Caller: return null
    else Membership exists
        Store->>Store: Check user details in member map
        alt User details missing
            Store-->>Caller: return null
        else User details exist
            Store-->>Caller: return member object with user details
        end
    end

Loading

Possibly related PRs

• [WEB-3787] fix: project joining date #7127: Modifies the same getProjectMemberDetails method to add a joining_date field, indicating both PRs alter the internal logic of this method.

Suggested labels

ready to merge

Suggested reviewers

• sriramveeraghanta
• dheeru0198

Poem

In the code where members dwell,
A rabbit checks the map as well.
No details found? It hops away—
Returns null, no time to stay.
With careful paws and logic neat,
The member check is now complete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1113f9f and f0b85ef.

📒 Files selected for processing (1)

• web/core/store/member/base-project-member.store.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

web/core/store/member/base-project-member.store.ts (1)

172-179: LGTM! Solid defensive programming improvement.

The addition of the user details existence check effectively prevents potential undefined access errors. The code now safely handles cases where project membership exists but corresponding user details are missing from the memberMap, which aligns perfectly with the PR objective of ensuring user details availability.

The refactor also improves readability by extracting the user details into a local variable.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4249] Plane Web Application Crashes When Accessing Member Tab in Project Settings

Comment Automatically Generated by Plane