[WIKI-520] fix: update content disposition handling in asset download endpoints

[pablohashescobar]

Description

• update content disposition headers to support filename with spaces

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Test Scenarios

• upload image with spaces should download without any s3 errors

References

WIKI-520

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of filenames in asset download links by generating a unique name when missing, ensuring consistent file naming during downloads.
• New Features
  • Asset download links now clearly separate attachment type from filename, improving compatibility and user experience when saving files.

[coderabbitai]

Walkthrough

The changes update how presigned URLs are generated for asset downloads by altering the handling of the content-disposition header and filename. The filename is now determined from asset attributes or a generated UUID, and the storage utility's default filename is set to a UUID if none is provided. No other logic or flow is affected.

Changes

File(s)	Change Summary
apps/api/plane/app/views/asset/v2.py	Updated asset download endpoints to separate content-disposition type and filename, using asset attributes or UUID for filename.
apps/api/plane/settings/storage.py	Changed _get_content_disposition method to default filename to a generated UUID string if not provided.

Possibly related PRs

• [WEB-4316] chore: new endpoints to download an asset #7207: Modifies the same asset download endpoint methods, specifically changing how content-disposition and filenames are handled for presigned URLs.

Suggested labels

⚙️backend, ready to merge

Suggested reviewers

• sriramveeraghanta

Poem

A rabbit hopped through code so neat,
Tweaked downloads so filenames greet.
No more missing names in flight—
UUIDs now set things right!
With headers clear and logic sound,
The assets land safe, all around.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 967b848 and 7c4d77b.

📒 Files selected for processing (1)

• apps/api/plane/settings/storage.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/api/plane/settings/storage.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WIKI-520] Download Fails with "Header value cannot be represented using ISO-8859-1" XML Error

Comment Automatically Generated by Plane

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3618ffc and 967b848.

📒 Files selected for processing (2)

• apps/api/plane/app/views/asset/v2.py (2 hunks)
• apps/api/plane/settings/storage.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

apps/api/plane/settings/storage.py (1)

3-3: Import addition looks good.

The UUID import is necessary for the filename generation functionality.

apps/api/plane/app/views/asset/v2.py (2)

743-744: Excellent fix for content disposition handling.

The change properly separates the disposition type from the filename, which should resolve the S3 errors with filenames containing spaces. The filename extraction from asset attributes with UUID fallback is well-implemented.

---

771-772: Consistent implementation across endpoints.

The same fix is properly applied to the project asset download endpoint, maintaining consistency across the codebase.