Skip to content

[WIKI-520] fix: update content disposition handling in asset download endpoints #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 2 commits into from
Jul 15, 2025
Merged

[WIKI-520] fix: update content disposition handling in asset download endpoints #7380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
967b848
fix: update content disposition handling in asset download endpoints
pablohashescobar Jul 10, 2025
7c4d77b
fix: improve content disposition handling in S3Storage class
pablohashescobar Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/api/plane/app/views/asset/v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,8 @@ def get(self, request, slug, asset_id):
storage = S3Storage(request=request)
signed_url = storage.generate_presigned_url(
object_name=asset.asset.name,
disposition=f"attachment; filename={asset.asset.name}",
disposition="attachment",
filename=asset.attributes.get("name", uuid.uuid4().hex),
)

return HttpResponseRedirect(signed_url)
Expand All @@ -767,7 +768,8 @@ def get(self, request, slug, project_id, asset_id):
storage = S3Storage(request=request)
signed_url = storage.generate_presigned_url(
object_name=asset.asset.name,
disposition=f"attachment; filename={asset.asset.name}",
disposition="attachment",
filename=asset.attributes.get("name", uuid.uuid4().hex),
)

return HttpResponseRedirect(signed_url)
4 changes: 4 additions & 0 deletions apps/api/plane/settings/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Python imports
import os
import uuid

# Third party imports
import boto3
Expand Down Expand Up @@ -101,6 +102,9 @@ def generate_presigned_post(

def _get_content_disposition(self, disposition, filename=None):
"""Helper method to generate Content-Disposition header value"""
if filename is None:
filename = uuid.uuid4().hex

if filename:
# Encode the filename to handle special characters
encoded_filename = quote(filename)
Expand Down