[WEB-4536] fix: remove inactive workspace members from lists and dropdowns

[prateekshourya29]

Description

This PR ensures that inactive members are excluded from all dropdown and lists across the app.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• New Features
  • Inactive members are now visible in the workspace members list.
• Bug Fixes
  • Members removed from a workspace are now marked as inactive instead of being deleted, ensuring their information is retained.

[coderabbitai]

Walkthrough

The changes adjust how workspace members are filtered and managed. The frontend now displays all members, regardless of active status, while the store logic ensures only active, non-bot members are considered in computed lists. Additionally, removing a member now marks them inactive rather than deleting their data.

Changes

File(s)	Change Summary
apps/web/core/components/workspace/settings/members-list.tsx	Removed filtering for inactive members; all members are now included in the displayed list.
apps/web/core/store/member/workspace-member.store.ts	Changed computed filtering to include only active, non-bot members; removal now sets inactive.

Sequence Diagram(s)

sequenceDiagram
    participant UI as Members List UI
    participant Store as Workspace Member Store

    UI->>Store: Fetch member details (searchedMemberIds)
    Store-->>UI: Return all member details (active & inactive)

    UI->>Store: Remove member from workspace
    Store->>Store: Set member's is_active = false
    Store-->>UI: Member now marked inactive, not deleted

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• makeplane/plane#7205: Modifies computed functions and immutability in the same store, related to member data handling.
• makeplane/plane#7435: Also adjusts filtering logic for workspace members' active status in both UI and store.

Suggested labels

🐛bug, 🌐frontend, ready to merge

Suggested reviewers

• vamsikrishnamathala
• sriramveeraghanta

Poem

In the warren of code, where members abound,
Now all can be seen, both silent and sound.
No more are the quiet ones swept from the view,
Inactive or not, they’re counted anew!
A hop and a skip, with a flick of the ear—
Every bunny is welcome, and every name clear.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 849b7b7 and 46e472a.

📒 Files selected for processing (2)

• apps/web/core/components/workspace/settings/members-list.tsx (1 hunks)
• apps/web/core/store/member/workspace-member.store.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: NarayanBavisetti
PR: makeplane/plane#7460
File: apps/api/plane/app/serializers/draft.py:112-122
Timestamp: 2025-07-23T18:18:06.849Z
Learning: In the Plane codebase serializers, workspace_id is not consistently passed in serializer context, so parent issue validation in DraftIssueCreateSerializer only checks project_id rather than both workspace_id and project_id. The existing project member authentication system already validates that users can only access projects they belong to, providing sufficient security without risking breaking functionality by adding workspace_id validation where the context might not be available.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

apps/web/core/store/member/workspace-member.store.ts (2)

123-125: LGTM! Filtering logic correctly excludes inactive members.

The addition of m.is_active to the filter condition properly implements the PR objective of removing inactive workspace members from lists and dropdowns while maintaining the existing bot filtering.

---

256-256: LGTM! Soft delete implementation preserves data integrity.

Setting is_active to false instead of deleting the member entry is a good architectural choice that:

• Preserves historical data and relationships
• Enables potential member reactivation
• Works seamlessly with the filtering logic in getWorkspaceMemberIds

apps/web/core/components/workspace/settings/members-list.tsx (1)

50-50: LGTM! Redundant filtering removed after store-level filtering.

Removing the filter((member) => member?.is_active) is correct because:

1. The store's getWorkspaceMemberIds already filters out inactive members
2. searchedMemberIds only contains active member IDs
3. This centralizes the filtering logic in the store layer rather than duplicating it in the UI

This follows good architectural principles by keeping business logic in the store.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-inactive-members

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4536] Inactive members are displayed in all the dropdown related to user addition across the platform

Comment Automatically Generated by Plane