Skip to content

[WEB-4536] fix: remove inactive workspace members from lists and dropdowns #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 1 commit into from
Jul 24, 2025
Merged

[WEB-4536] fix: remove inactive workspace members from lists and dropdowns #7473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/web/core/components/workspace/settings/members-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ export const WorkspaceMembersList: FC<{ searchQuery: string; isAdmin: boolean }>
// derived values
const searchedMemberIds = getSearchedWorkspaceMemberIds(searchQuery);
const searchedInvitationsIds = getSearchedWorkspaceInvitationIds(searchQuery);
const memberDetails = searchedMemberIds
?.map((memberId) => getWorkspaceMemberDetails(memberId))
.filter((member) => member?.is_active);
const memberDetails = searchedMemberIds?.map((memberId) => getWorkspaceMemberDetails(memberId));

return (
<>
Expand Down
7 changes: 4 additions & 3 deletions apps/web/core/store/member/workspace-member.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ export class WorkspaceMemberStore implements IWorkspaceMemberStore {
(m) => this.memberRoot?.memberMap?.[m.member]?.display_name?.toLowerCase(),
]);
//filter out bots
const memberIds = members.filter((m) => !this.memberRoot?.memberMap?.[m.member]?.is_bot).map((m) => m.member);
const memberIds = members
.filter((m) => m.is_active && !this.memberRoot?.memberMap?.[m.member]?.is_bot)
.map((m) => m.member);
return memberIds;
});

Expand Down Expand Up @@ -251,8 +253,7 @@ export class WorkspaceMemberStore implements IWorkspaceMemberStore {
if (!memberDetails) throw new Error("Member not found");
await this.workspaceService.deleteWorkspaceMember(workspaceSlug, memberDetails?.id).then(() => {
runInAction(() => {
delete this.memberRoot?.memberMap?.[userId];
delete this.workspaceMemberMap?.[workspaceSlug]?.[userId];
set(this.workspaceMemberMap, [workspaceSlug, userId, "is_active"], false);
});
});
};
Expand Down