fix: Replace unclear blue dot indicators with semantic badges in filter UI by naaa760 · Pull Request #7524 · makeplane/plane

naaa760 · 2025-07-31T07:19:02Z

Description

Fixed unclear semantics of blue dot indicators in issue filter UI by replacing them with semantic visual indicators:

#7448

Filter conditions: Replaced blue dot with filter icon badge (funnel icon)
Active phases: Replaced pulsing blue dot with "LIVE" text badge
Updated 5 components for consistency across all filter interfaces

Type of Change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Improvement (change that would cause existing functionality to not work as expected)
Code refactoring
Performance improvements
Documentation update

References

Bug: "Rounded dot has unclear semantics in issue filter UI"
Issue: Users confused by identical blue dots representing different concepts

Files Changed

apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx
apps/web/core/components/issues/issue-layouts/filters/header/helpers/filter-option.tsx
apps/web/core/components/issues/issue-detail/issue-activity/activity-filter.tsx
apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx
apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx

Summary by CodeRabbit

Style
- Enhanced the visual indicator for applied filters across multiple filter buttons and dropdowns, replacing small colored dots with larger, styled badges featuring a white icon for improved clarity.
- Updated the "LIVE" indicator in filter options from a pulsing dot to a pill-shaped label with the text "LIVE" for better visibility.

coderabbitai · 2025-07-31T07:19:09Z

Walkthrough

This change updates the visual indicators for filter states across several UI components. Small colored dots previously used to indicate active filters have been replaced with larger, styled badges featuring centered SVG icons or, in one case, a "LIVE" pill label. No logic or control flow was altered.

Changes

Cohort / File(s)	Change Summary
Filter Badge UI Enhancements `apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx`, `apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx`, `apps/web/core/components/issues/issue-detail/issue-activity/activity-filter.tsx`, `apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx`	Replaced small colored dot filter indicators with larger, styled badges containing centered SVG icons. Adjusted badge size, position, and styling for improved visibility and consistency. No changes to underlying logic.
"LIVE" Label for Active Pulse `apps/web/core/components/issues/issue-layouts/filters/header/helpers/filter-option.tsx`	Changed the active pulse indicator from an animated dot to a pill-shaped label with the text "LIVE," updating styling and removing animation. No logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI_Component
    participant Filter_Indicator

    User->>UI_Component: Interacts with filter button
    UI_Component->>Filter_Indicator: Determine filter state
    alt Filter applied
        Filter_Indicator->>UI_Component: Render badge with SVG icon or "LIVE" label
    else No filter applied
        Filter_Indicator->>UI_Component: Render no indicator
    end
    UI_Component->>User: Display updated filter indicator

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related issues

[bug]: Rounded dot has unclear semantics in issue filter UI #7448: The changes directly improve the visual clarity of filter-applied indicators, addressing the unclear semantics of the previous rounded dot UI elements.

Poem

A dot once blinked to say "I'm here,"
Now badges and labels make it clear.
SVG icons, bold and bright,
Show filters set, both day and night.
"LIVE" pulses on, a pill-shaped cheer—
UI refreshed, let’s all give a bunny ear! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1458c75 and ae43fff.

📒 Files selected for processing (5)

apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx (1 hunks)
apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx (1 hunks)
apps/web/core/components/issues/issue-detail/issue-activity/activity-filter.tsx (1 hunks)
apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1 hunks)
apps/web/core/components/issues/issue-layouts/filters/header/helpers/filter-option.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: mathalav55
PR: makeplane/plane#6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, `ISSUE_DISPLAY_FILTERS_BY_LAYOUT` and `ISSUE_DISPLAY_FILTERS_BY_PAGE` are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

🔇 Additional comments (5)

apps/web/core/components/issues/issue-detail-widgets/sub-issues/filters.tsx (1)

51-57: LGTM! Improved filter indicator with semantic icon.

The replacement of the simple dot with a badge containing a filter/funnel SVG icon significantly improves the semantic meaning of the visual indicator. The implementation uses proper flexbox centering, appropriate sizing, and maintains the existing conditional rendering logic.

apps/web/core/components/issues/issue-detail-widgets/sub-issues/display-filters.tsx (1)

46-52: LGTM! Consistent implementation across components.

The filter indicator implementation is identical to the previous component, ensuring visual consistency across the UI. The semantic filter icon clearly communicates the presence of active filters.

apps/web/core/components/issues/issue-layouts/filters/header/helpers/filter-option.tsx (1)

35-37: LGTM! Clear semantic indicator with explicit text.

Replacing the animated pulsing dot with a "LIVE" text badge provides explicit semantic meaning. The pill-shaped design with proper styling maintains visual hierarchy while clearly communicating the active state.

apps/web/core/components/issues/issue-detail/issue-activity/activity-filter.tsx (1)

34-38: LGTM! Maintains consistency across filter components.

The implementation follows the same pattern as other filter components, using the semantic filter icon badge. This ensures a consistent user experience across all filter interfaces.

apps/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx (1)

76-80: LGTM! Completes the consistent UI improvement across all filter components.

This final implementation maintains the same semantic filter icon badge pattern used throughout all other filter components, ensuring a cohesive and clear visual language for filter states across the entire application.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sriramveeraghanta · 2025-10-16T09:19:03Z

We have completely changed how the filters works. This is not required anymore.

naaa760 added 5 commits July 31, 2025 12:40

Filter menu button indicator

ccfcb60

Replaced pulsing blue dot with LIVE badge for active phases

7e2b379

Replaced blue dot with filter icon badge for activity filters

948da77

Replaced blue dot with filter icon badge for sub-issues filtersC

5569dcc

replaced blue dot with filter icon badge for display filters

ae43fff

sriramveeraghanta closed this Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: Replace unclear blue dot indicators with semantic badges in filter UI#7524

fix: Replace unclear blue dot indicators with semantic badges in filter UI#7524
naaa760 wants to merge 5 commits intomakeplane:previewfrom
naaa760:fix/issue-filter-dot-semantics

naaa760 commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

sriramveeraghanta commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

naaa760 commented Jul 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

References

Files Changed

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sriramveeraghanta commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naaa760 commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)