Skip to content

[PRIME-24] fix: update live server aio build path#7911

Merged
mguptahub merged 2 commits intopreviewfrom
fix-live-server-aio
Oct 7, 2025
Merged

[PRIME-24] fix: update live server aio build path#7911
mguptahub merged 2 commits intopreviewfrom
fix-live-server-aio

Conversation

@sriramveeraghanta
Copy link
Member

@sriramveeraghanta sriramveeraghanta commented Oct 6, 2025

Description

Update live server aio build path

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Chores
    • Updated service start command to use an absolute path for improved consistency.
    • Removed explicit working-directory configuration from the process supervisor.

Copilot AI review requested due to automatic review settings October 6, 2025 18:17
@makeplane
Copy link

makeplane bot commented Oct 6, 2025

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the supervisor configuration for the live server to fix the build path, changing from a relative path to an absolute path and updating the server entry point.

  • Updated the live server command to use absolute path /app/live/dist/start.js
  • Removed the separate directory configuration line
  • Simplified the supervisor configuration by consolidating path information into the command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sriramveeraghanta sriramveeraghanta changed the title [PRIME-24] fix: udpate live server aio build path [PRIME-24] fix: update live server aio build path Oct 6, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated the Supervisor [program:live] entry: removed the directory=/app/live/apps/live directive and changed the start command from node ./dist/server.js to node /app/live/apps/live/dist/start.js. Other supervisor options were left unchanged.

Changes

Cohort / File(s) Summary
Supervisor live program update
deployments/aio/community/supervisor.conf
Removed directory=/app/live/apps/live and changed command from node ./dist/server.js to node /app/live/apps/live/dist/start.js. Other supervisor settings (autostart, autorestart, log paths) unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Supervisor
  participant LiveNode as Live Service (node)
  participant FS as Filesystem

  Note over Supervisor,LiveNode: Startup now uses absolute path: node /app/live/apps/live/dist/start.js

  Supervisor->>FS: Read supervisor.conf (program:live)
  Supervisor->>LiveNode: Exec "node /app/live/apps/live/dist/start.js"
  LiveNode->>FS: Write stdout/stderr logs
  alt Process exits/crashes
    Supervisor->>LiveNode: Autorestart per config
  else Running
    LiveNode-->>Supervisor: Running
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • akshat5302
  • mguptahub

Poem

Hop-hop, I changed the start to a straighter track,
From dot-slash lanes to /app/live/apps/live in a pack.
No working dir to set, the command runs true,
Logs keep flowing, and restarts will too. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the main change by indicating that the live server AIO build path has been updated and uses concise, specific phrasing along with the relevant ticket reference. It directly reflects the modifications made in the supervisor configuration.
Description Check ✅ Passed The description provides a clear summary of the change and correctly marks it as a bug fix, matching the template’s required sections for Description and Type of Change. While it omits Screenshots, Test Scenarios, and References, those are non-critical when no UI or external integrations are involved.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-live-server-aio

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c32281 and 5d2af4f.

📒 Files selected for processing (1)
  • deployments/aio/community/supervisor.conf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
deployments/aio/community/supervisor.conf (2)

98-109: No working-directory dependencies detected
Searches in apps/live found no process.cwd(), __dirname or dynamic fs.readFile/writeFile calls—only static ES imports, which Node resolves by file location. Removing the directory directive is safe.


99-99: Verified entry point: start.js matches apps/live/package.json main and absolute path style is consistent.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mguptahub mguptahub merged commit 07ff457 into preview Oct 7, 2025
16 checks passed
@mguptahub mguptahub deleted the fix-live-server-aio branch October 7, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants