Skip to content

fix: dockerfile build paths#7322

Merged
sriramveeraghanta merged 2 commits intopreviewfrom
fix-docker-paths
Jul 2, 2025
Merged

fix: dockerfile build paths#7322
sriramveeraghanta merged 2 commits intopreviewfrom
fix-docker-paths

Conversation

@sriramveeraghanta
Copy link
Member

@sriramveeraghanta sriramveeraghanta commented Jul 2, 2025

Description

  • Updated the docker build paths using /apps folder structure

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Chores
    • Standardized environment variable syntax in application containers.
    • Improved container security by switching to non-root users.
    • Updated file copy paths to match the correct directory structure.
    • Removed unnecessary files from the final container images.
    • Enhanced Dockerfile comments for clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Walkthrough

The Dockerfiles for the admin, space, and web applications were updated to standardize environment variable syntax, capitalize stage names, correct build artifact paths, and add non-root user handling for improved security. Unused copy commands were removed, and clarifying comments were added. No changes were made to application logic or exported entities.

Changes

Files Change Summary
apps/admin/Dockerfile.admin Standardized ENV syntax, capitalized stage names, added non-root user/group, corrected build artifact paths, removed unused copies.
apps/space/Dockerfile.space Standardized ENV syntax, capitalized stage names, added non-root user/group, corrected build artifact paths, removed unused copies.
apps/web/Dockerfile.web Standardized ENV syntax, capitalized stage names, added non-root user/group, corrected build artifact paths, removed unused copies.

Sequence Diagram(s)

sequenceDiagram
    participant Dockerfile
    participant BaseImage
    participant Installer
    participant Runner

    Dockerfile->>BaseImage: FROM node:... AS base
    Dockerfile->>Installer: FROM base AS installer
    Installer->>Installer: Set ENV vars (disable telemetry)
    Installer->>Installer: Build Next.js app
    Dockerfile->>Runner: FROM base AS runner
    Runner->>Runner: Create non-root user/group
    Runner->>Runner: Set ENV vars (disable telemetry)
    Runner->>Runner: Copy build artifacts from installer
    Runner->>Runner: Switch to non-root user
    Runner->>Runner: Start app
Loading

Suggested labels

🏠self-hosted, 🐳docker, devops

Suggested reviewers

  • mguptahub

Poem

In Dockerfiles neat and tidy rows,
The rabbit hops where the Next.js grows.
From root to user, a safer space,
With paths corrected, files in place.
Telemetry silenced, builds now gleam—
DevOps dreams in a Docker stream! 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta marked this pull request as ready for review July 2, 2025 19:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🧹 Nitpick comments (4)
apps/admin/Dockerfile.admin (1)

49-50: Duplicate telemetry flags – declare once per stage

ENV NEXT_TELEMETRY_DISABLED=1 and ENV TURBO_TELEMETRY_DISABLED=1 are declared in both the installer and runner stages. Unless you intentionally want different values, define them once (e.g. in base) to avoid bloat and drift.

apps/web/Dockerfile.web (1)

59-60: Telemetry ENV duplicated – consolidate

Same flags appear later in the runner stage; define once to keep layers minimal.

apps/space/Dockerfile.space (2)

49-50: Duplicate telemetry ENV – can be set once

Same optimisation comment as the other Dockerfiles.


89-90: Redundant telemetry ENV

Same duplication as above.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e184b64 and 14c2dbe.

📒 Files selected for processing (3)
  • apps/admin/Dockerfile.admin (4 hunks)
  • apps/space/Dockerfile.space (4 hunks)
  • apps/web/Dockerfile.web (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/admin/Dockerfile.admin (1)

65-69: Static files copied to nested path – likely 404 at runtime

Next.js standalone expects .next/static at the project root (/app/.next/static). You copy to /app/apps/admin/.next/static, which the runtime server won’t find.

-COPY --from=installer /app/apps/admin/.next/static ./apps/admin/.next/static
+COPY --from=installer /app/apps/admin/.next/static ./.next/static

Please verify with a local container run.

apps/web/Dockerfile.web (1)

78-80: Verify static-asset destination

COPY … /app/apps/web/.next/static may not be where the standalone server looks for assets. Confirm and adjust to ./.next/static if needed.

apps/space/Dockerfile.space (1)

65-69: Potential wrong static path

Ensure the server expects static assets under .next/static, not apps/space/.next/static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants