fix: update docker file paths and context in branch build workflow#7323
fix: update docker file paths and context in branch build workflow#7323sriramveeraghanta merged 2 commits intopreviewfrom
Conversation
WalkthroughThe workflow configuration for building and pushing Docker images was updated to use new Dockerfile locations and build contexts under the Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/build-branch.yml (1)
135-137: Narrow build-context to the component directory for faster, lighter buildsThe Dockerfiles have moved under
./apps/**, butbuild-contextis still.for Admin, Web, Space and Live images.
Sending the whole repo (sometimes > 100 MB) to Docker unnecessarily increases cache misses and CI run-time.Optional refactor:
- build-context: . + build-context: ./apps/admin # similarly web/space/live belowRepeat the same adjustment for the other three blocks (
web,space,live).If the Dockerfiles rely on files outside their folder, keep the wider context, otherwise this change is a free win in performance and network traffic.
Also applies to: 157-159, 179-181, 201-203
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-branch.yml(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Build-Push API Server Docker Image
- GitHub Check: Build-Push Web Docker Image
- GitHub Check: Build-Push Space Docker Image
- GitHub Check: Build-Push Live Collaboration Docker Image
- GitHub Check: Build-Push Admin Docker Image
- GitHub Check: Analyze (javascript)
…kflow makeplane#7323" This reverts commit 7d417c5.
Description
Type of Change
Summary by CodeRabbit