[WEB-5256]chore: quick actions refactor#8019
Merged
sriramveeraghanta merged 9 commits intopreviewfrom Dec 9, 2025
Merged
Conversation
Contributor
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughCentralizes quick-action menu creation into a factory and shared helper hooks; removes an unused end-cycle hook and old view menu exports; updates multiple components to consume the new hooks and render optional additional modals returned by those hooks. Changes
Sequence Diagram(s)sequenceDiagram
participant Component as Component (Cycle/Module/View/Layout)
participant Hook as Menu Hook (use*MenuItems)
participant Factory as useQuickActionsFactory
participant Menu as CustomMenu
Component->>Hook: call with props (entity details, handlers, permissions)
Hook->>Factory: obtain factory functions
Factory-->>Hook: quick-action creators
Hook->>Hook: build items array and optional modals
Hook-->>Component: return items (or {items, modals})
Component->>Component: normalize (array or object)
Component->>Menu: render items
Menu-->>Component: user interactions (actions invoke provided handlers)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vamsikrishnamathala
changed the title
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/core/components/modules/quick-actions.tsx (1)
117-125: ContextMenu expects action, not onClickYou’re adding onClick; TContextMenuItem defines action. This breaks typing and the ContextMenu won’t invoke the wrapper.
- const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => ({ - ...item, - onClick: () => { + const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => ({ + ...item, + action: () => { captureClick({ elementName: MODULE_TRACKER_ELEMENTS.CONTEXT_MENU, }); item.action(); }, }));
🧹 Nitpick comments (12)
apps/web/core/components/views/quick-actions.tsx (2)
71-76: Avoid mutating hook-provided arrays when inserting publish itemSplicing MENU_ITEMS mutates the array returned by the hook. Use an immutable insert to prevent side effects.
Apply:
- if (publishContextMenu) MENU_ITEMS.splice(2, 0, publishContextMenu); + const MENU_ITEMS_WITH_PUBLISH = publishContextMenu + ? [ + ...MENU_ITEMS.slice(0, 2), + publishContextMenu, + ...MENU_ITEMS.slice(2), + ] + : MENU_ITEMS; + - const CONTEXT_MENU_ITEMS = MENU_ITEMS.map((item) => ({ + const CONTEXT_MENU_ITEMS = MENU_ITEMS_WITH_PUBLISH.map((item) => ({ ...item, action: () => { captureClick({ elementName: PROJECT_VIEW_TRACKER_ELEMENTS.LIST_ITEM_CONTEXT_MENU }); item.action(); }, }));
57-58: Harden window.open usageAdd noopener,noreferrer to prevent reverse tabnabbing.
- const handleOpenInNewTab = () => window.open(`/${viewLink}`, "_blank"); + const handleOpenInNewTab = () => window.open(`/${viewLink}`, "_blank", "noopener,noreferrer");apps/web/core/components/workspace/views/quick-action.tsx (3)
48-57: Normalize CE/EE return shapes like other componentsCurrently assumes an object with .items. For future-proofing, normalize to handle both array and object.
- const MENU_ITEMS = useViewMenuItems({ + const menuResult = useViewMenuItems({ isOwner, isAdmin, handleDelete: () => setDeleteViewModal(true), handleEdit: () => setUpdateViewModal(true), handleOpenInNewTab, handleCopyLink: handleCopyText, workspaceSlug, view, }); + const MENU_ITEMS = Array.isArray(menuResult) ? menuResult : menuResult.items; + const additionalModals = Array.isArray(menuResult) ? null : menuResult.modals;And render additionalModals before the menu if present.
69-105: Render optional modals from the hook (EE path)If EE returns modals, render them alongside local modals for consistency with other quick-actions.
return ( <> <CreateUpdateWorkspaceViewModal data={view} isOpen={updateViewModal} onClose={() => setUpdateViewModal(false)} /> <DeleteGlobalViewModal data={view} isOpen={deleteViewModal} onClose={() => setDeleteViewModal(false)} /> + {additionalModals} <CustomMenu
46-47: Harden window.open usageAdd noopener,noreferrer.
- const handleOpenInNewTab = () => window.open(`/${viewLink}`, "_blank"); + const handleOpenInNewTab = () => window.open(`/${viewLink}`, "_blank", "noopener,noreferrer");apps/web/core/components/modules/quick-actions.tsx (1)
69-70: Harden window.open usageAdd noopener,noreferrer.
- const handleOpenInNewTab = () => window.open(`/${moduleLink}`, "_blank"); + const handleOpenInNewTab = () => window.open(`/${moduleLink}`, "_blank", "noopener,noreferrer");apps/web/core/components/cycles/quick-actions.tsx (2)
101-114: Guard against undefined cycleDetails before calling the hookcycleDetails! can be undefined on initial render; this can throw inside the hook.
Pattern as in modules: early-return minimal menu (Open/Copy) until cycleDetails is available, then call useCycleMenuItems with cycleDetails.
69-70: Harden window.open usageAdd noopener,noreferrer.
- const handleOpenInNewTab = () => window.open(`/${cycleLink}`, "_blank"); + const handleOpenInNewTab = () => window.open(`/${cycleLink}`, "_blank", "noopener,noreferrer");apps/web/core/components/issues/layout-quick-actions.tsx (1)
30-31: Harden window.open usageAdd noopener,noreferrer.
- const handleOpenInNewTab = () => window.open(`/${layoutLink}`, "_blank"); + const handleOpenInNewTab = () => window.open(`/${layoutLink}`, "_blank", "noopener,noreferrer");apps/web/core/components/common/quick-actions-factory.tsx (2)
33-38: Consolidate duplicate "open in new tab" functions.Both
createOpenInNewTabMenuItem(lines 33-38) andcreateOpenInNewTab(lines 107-112) produce identical menu items with the same key, title (when translated), and icon. This creates unnecessary code duplication.Consider removing
createOpenInNewTaband usingcreateOpenInNewTabMenuItemconsistently across all contexts, or clarify the semantic difference if one exists.Also applies to: 107-112
40-45: Consolidate duplicate "copy link" functions.Both
createCopyLinkMenuItem(lines 40-45) andcreateCopyLayoutLinkMenuItem(lines 114-119) produce identical menu items. This duplication increases maintenance burden without apparent benefit.Consider using a single
createCopyLinkMenuItemfunction for both entity and layout contexts, or document why separate functions are necessary.Also applies to: 114-119
apps/web/ce/components/common/quick-actions-helper.tsx (1)
119-122: Consider moving theMenuResulttype definition earlier.The
MenuResulttype is defined on lines 119-122 but is used in return type annotations starting from line 20. While TypeScript hoisting makes this work, defining the type before its first usage improves readability.Consider moving the type definition to lines 4-7, right after the imports:
import type { ICycle, IModule, IProjectView, IWorkspaceView } from "@plane/types"; import type { TContextMenuItem } from "@plane/ui"; import { useQuickActionsFactory } from "@/components/common/quick-actions-factory"; +export type MenuResult = { + items: TContextMenuItem[]; + modals: JSX.Element | null; +}; + // Cycles export interface UseCycleMenuItemsProps {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
apps/web/ce/components/common/quick-actions-helper.tsx(1 hunks)apps/web/ce/components/cycles/end-cycle/index.ts(0 hunks)apps/web/ce/components/cycles/end-cycle/use-end-cycle.tsx(0 hunks)apps/web/ce/components/views/helper.tsx(0 hunks)apps/web/core/components/common/quick-actions-factory.tsx(1 hunks)apps/web/core/components/cycles/quick-actions.tsx(3 hunks)apps/web/core/components/issues/layout-quick-actions.tsx(1 hunks)apps/web/core/components/modules/quick-actions.tsx(3 hunks)apps/web/core/components/views/quick-actions.tsx(3 hunks)apps/web/core/components/workspace/views/quick-action.tsx(3 hunks)
💤 Files with no reviewable changes (3)
- apps/web/ce/components/views/helper.tsx
- apps/web/ce/components/cycles/end-cycle/index.ts
- apps/web/ce/components/cycles/end-cycle/use-end-cycle.tsx
🧰 Additional context used
🧬 Code graph analysis (7)
apps/web/core/components/modules/quick-actions.tsx (2)
apps/web/ce/components/common/quick-actions-helper.tsx (1)
useModuleMenuItems(59-82)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/views/quick-actions.tsx (2)
apps/web/ce/components/common/quick-actions-helper.tsx (1)
useViewMenuItems(97-109)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/common/quick-actions-factory.tsx (3)
packages/i18n/src/hooks/use-translation.ts (1)
useTranslation(23-35)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)packages/propel/src/icons/workspace/archive-icon.tsx (1)
ArchiveIcon(6-13)
apps/web/core/components/workspace/views/quick-action.tsx (1)
apps/web/ce/components/common/quick-actions-helper.tsx (1)
useViewMenuItems(97-109)
apps/web/core/components/cycles/quick-actions.tsx (2)
apps/web/ce/components/common/quick-actions-helper.tsx (1)
useCycleMenuItems(20-42)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/issues/layout-quick-actions.tsx (5)
apps/space/core/store/publish/publish.store.ts (1)
workspaceSlug(93-95)packages/utils/src/string.ts (1)
copyUrlToClipboard(66-72)packages/propel/src/toast/toast.tsx (1)
setToast(198-218)apps/web/ce/components/common/quick-actions-helper.tsx (1)
useLayoutMenuItems(124-134)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/ce/components/common/quick-actions-helper.tsx (5)
apps/web/core/components/common/quick-actions-factory.tsx (1)
useQuickActionsFactory(20-121)packages/types/src/module/modules.ts (1)
IModule(49-89)packages/types/src/views.ts (1)
IProjectView(14-35)packages/types/src/workspace-views.ts (1)
IWorkspaceView(9-33)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and lint web apps
🔇 Additional comments (8)
apps/web/core/components/views/quick-actions.tsx (1)
59-69: Good migration to unified hookProps wiring to useViewMenuItems looks correct and consistent with the shared factory.
apps/web/core/components/cycles/quick-actions.tsx (1)
116-129: LGTM on CE/EE normalization and action wrappingCorrect use of action wrapper for ContextMenu; consistent with TContextMenuItem.
apps/web/core/components/issues/layout-quick-actions.tsx (1)
41-44: CE/EE normalization looks goodCorrectly supports both array and object return shapes and renders additional modals.
apps/web/core/components/common/quick-actions-factory.tsx (1)
25-31: LGTM!The
createEditMenuItemfactory function correctly uses the translation hook and provides a clean interface with appropriate defaults.apps/web/ce/components/common/quick-actions-helper.tsx (4)
1-18: LGTM!The imports and interface definition for
UseCycleMenuItemsPropsare well-structured and include all necessary properties.
20-42: LGTM!The cycle menu logic correctly handles archived and completed states, with appropriate restrictions on edit, delete, and archive actions.
97-109: LGTM!The implementations of
useViewMenuItems,useLayoutMenuItems, anduseIntakeHeaderMenuItemsare clean and correctly use the factory functions with appropriate permission checks.Also applies to: 124-134, 136-147
64-64: Fix typo: usetoLowerCase()instead oftoLocaleLowerCase().Line 64 uses
toLocaleLowerCase(), which is not a standard JavaScript method. The correct method istoLowerCase().Apply this diff:
- const moduleState = moduleDetails?.status?.toLocaleLowerCase(); + const moduleState = moduleDetails?.status?.toLowerCase();Likely an incorrect or invalid review comment.
prateekshourya29
previously approved these changes
Oct 30, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
apps/web/core/components/issues/layout-quick-actions.tsx (1)
46-52: Use buttonClassName instead of className for CustomMenu trigger.Other components in this PR (e.g., cycles quick-actions) use
buttonClassNameto style the trigger. TheclassNameprop may not style the button as intended.Apply this diff:
<CustomMenu ellipsis placement="bottom-end" closeOnSelect maxHeight="lg" - className="flex-shrink-0 flex items-center justify-center size-[26px] bg-custom-background-80/70 rounded" + buttonClassName="flex-shrink-0 flex items-center justify-center size-[26px] bg-custom-background-80/70 rounded" >
🧹 Nitpick comments (3)
apps/web/core/components/issues/layout-quick-actions.tsx (1)
25-26: Consider using translations for toast messages.The success toast messages use hardcoded English strings. Other components in this PR use the
t()translation function for consistency.If i18n is required, import
useTranslationand replace:+import { useTranslation } from "@plane/i18n"; + export const LayoutQuickActions: React.FC<Props> = observer((props) => { + const { t } = useTranslation(); const { workspaceSlug, projectId, storeType } = props; const handleCopyLink = () => copyUrlToClipboard(layoutLink).then(() => { setToast({ type: TOAST_TYPE.SUCCESS, - title: "Link copied", - message: `${storeType === "EPIC" ? "Epics" : "Work items"} link copied to clipboard.`, + title: t("common.link_copied"), + message: t("common.link_copied_to_clipboard"), }); });apps/web/ce/components/common/quick-actions-helper.tsx (1)
136-147: Intake header items implementation is minimal but functional.Unlike the core version's stub, this CE implementation returns a working menu with the copy link action. The empty factory reference on line 141 is unused but harmless.
If the factory is unused, consider removing the initialization:
export const useIntakeHeaderMenuItems = (props: { workspaceSlug: string; projectId: string; handleCopyLink: () => void; }): MenuResult => { - const factory = useQuickActionsFactory(); - return { items: [factory.createCopyLinkMenuItem(props.handleCopyLink)], modals: null, }; };Wait—line 144 uses
factory.createCopyLinkMenuItem, so it is needed. Disregard this suggestion.apps/web/core/components/common/quick-actions-helper.tsx (1)
133-133: Review comment verified—inconsistency is intentional but naming could be clearer.Both
factory.createOpenInNewTab()andfactory.createOpenInNewTabMenuItem()exist in the factory implementation. Line 133 usescreateOpenInNewTab(layout-level actions for work item list views), while lines 71, 96, and 119 usecreateOpenInNewTabMenuItem(entity-level actions). They have different keys ("open-in-new-tab" vs "open-new-tab") and serve distinct purposes based on context.The naming inconsistency is real but appears intentional. Consider adding inline comments to clarify why the different method names exist, or consolidate to consistent naming if the distinction is unnecessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/web/ce/components/common/quick-actions-factory.tsx(1 hunks)apps/web/ce/components/common/quick-actions-helper.tsx(1 hunks)apps/web/core/components/common/quick-actions-factory.tsx(1 hunks)apps/web/core/components/common/quick-actions-helper.tsx(1 hunks)apps/web/core/components/cycles/quick-actions.tsx(3 hunks)apps/web/core/components/issues/layout-quick-actions.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/web/core/components/common/quick-actions-factory.tsx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T08:14:49.260Z
Learnt from: sriramveeraghanta
PR: makeplane/plane#7697
File: apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx:12-13
Timestamp: 2025-09-02T08:14:49.260Z
Learning: The star-us-link.tsx file in apps/web/app/(all)/[workspaceSlug]/(projects)/ already has "use client" directive at the top, making it a proper Client Component for hook usage.
Applied to files:
apps/web/core/components/issues/layout-quick-actions.tsx
🧬 Code graph analysis (4)
apps/web/core/components/cycles/quick-actions.tsx (2)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useCycleMenuItems(61-83)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/common/quick-actions-helper.tsx (5)
packages/types/src/module/modules.ts (1)
IModule(49-89)packages/types/src/views.ts (1)
IProjectView(14-35)packages/types/src/workspace-views.ts (1)
IWorkspaceView(9-33)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)apps/web/core/components/common/quick-actions-factory.tsx (1)
useQuickActionsFactory(9-82)
apps/web/ce/components/common/quick-actions-helper.tsx (5)
apps/web/core/components/common/quick-actions-factory.tsx (1)
useQuickActionsFactory(9-82)packages/types/src/module/modules.ts (1)
IModule(49-89)packages/types/src/views.ts (1)
IProjectView(14-35)packages/types/src/workspace-views.ts (1)
IWorkspaceView(9-33)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/issues/layout-quick-actions.tsx (4)
packages/utils/src/string.ts (1)
copyUrlToClipboard(66-72)packages/propel/src/toast/toast.tsx (1)
setToast(198-218)apps/web/core/components/common/quick-actions-helper.tsx (1)
useLayoutMenuItems(127-138)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Cursor Bugbot
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
apps/web/ce/components/common/quick-actions-factory.tsx (1)
1-1: LGTM! Clean CE re-export pattern.The re-export provides a public API surface for the CE layer to access the core factory implementation, maintaining the expected architectural separation.
apps/web/core/components/cycles/quick-actions.tsx (1)
153-153: Additional modals integration looks clean.The conditional rendering of
additionalModalsfrom the hook result properly extends the modal ecosystem while preserving existing modals.apps/web/core/components/common/quick-actions-helper.tsx (1)
140-145: Stub implementation is acceptable for now.The
useIntakeHeaderMenuItemsstub with disabled lint rule indicates planned future implementation. This is acceptable for a refactoring PR.Confirm this will be implemented in a follow-up issue or PR.
apps/web/ce/components/common/quick-actions-helper.tsx (2)
78-78: Module deletion constraint correctly implemented.The archived check on line 78 (
isEditingAllowed && !isArchived) properly prevents deletion of archived modules, matching the cycle deletion logic on line 38.Note: The past review comment about this line has been addressed in this version.
20-42: Cycle menu items implementation looks solid.The hook correctly derives
isArchivedandisCompletedfrom cycle details, applies appropriate constraints to each action, and returns filtered items with proper descriptions for disabled states.
prateekshourya29
previously approved these changes
Oct 30, 2025
* chore: updated imports
aaryan610
requested changes
Oct 30, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
apps/web/core/components/cycles/quick-actions.tsx (1)
117-125: Restore context menu tracking by overridingaction.
ContextMenuinvokes theactionhandler, so adding anonClickproperty never firescaptureClick. This regresses cycle analytics. Wrap the existing action instead of introducingonClick.- const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => ({ - ...item, - onClick: () => { - captureClick({ - elementName: CYCLE_TRACKER_ELEMENTS.CONTEXT_MENU, - }); - item.action(); - }, - })); + const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => { + const originalAction = item.action; + return { + ...item, + action: () => { + captureClick({ + elementName: CYCLE_TRACKER_ELEMENTS.CONTEXT_MENU, + }); + originalAction?.(); + }, + }; + });apps/web/core/components/workspace/views/quick-action.tsx (1)
48-105: NormalizeuseViewMenuItemsresult for CE/EE and render modals.The hook can return either an array (CE) or
{ items, modals }(EE). AccessingMENU_ITEMS.itemscrashes on CE and drops hook-provided modals entirely. Normalize the result before rendering.- const MENU_ITEMS = useViewMenuItems({ + const menuResult = useViewMenuItems({ isOwner, isAdmin, handleDelete: () => setDeleteViewModal(true), handleEdit: () => setUpdateViewModal(true), handleOpenInNewTab, handleCopyLink: handleCopyText, workspaceSlug, view, }); + const MENU_ITEMS: TContextMenuItem[] = Array.isArray(menuResult) ? menuResult : menuResult.items; + const additionalModals = Array.isArray(menuResult) ? null : menuResult.modals; return ( <> <CreateUpdateWorkspaceViewModal data={view} isOpen={updateViewModal} onClose={() => setUpdateViewModal(false)} /> <DeleteGlobalViewModal data={view} isOpen={deleteViewModal} onClose={() => setDeleteViewModal(false)} /> + {additionalModals} <CustomMenu ellipsis placement="bottom-end" closeOnSelect buttonClassName="flex-shrink-0 flex items-center justify-center size-[26px] bg-custom-background-80/70 rounded" > - {MENU_ITEMS.items.map((item) => { + {MENU_ITEMS.map((item) => { if (item.shouldRender === false) return null; return (apps/web/core/components/modules/quick-actions.tsx (1)
117-125: Wrap theactionhandler so module context clicks are tracked.
ContextMenuexecutesaction. AddingonClickleaves the original action untouched, socaptureClicknever runs. Overrideactioninstead.- const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => ({ - ...item, - onClick: () => { - captureClick({ - elementName: MODULE_TRACKER_ELEMENTS.CONTEXT_MENU, - }); - item.action(); - }, - })); + const CONTEXT_MENU_ITEMS: TContextMenuItem[] = MENU_ITEMS.map((item) => { + const originalAction = item.action; + return { + ...item, + action: () => { + captureClick({ + elementName: MODULE_TRACKER_ELEMENTS.CONTEXT_MENU, + }); + originalAction?.(); + }, + }; + });
♻️ Duplicate comments (1)
apps/web/core/components/common/quick-actions-helper.tsx (1)
104-104: Past review comment has been addressed.The
!isArchivedconstraint is now present in the delete check. The past review concern about missing archived constraint is resolved.
🧹 Nitpick comments (4)
apps/web/core/components/issues/layout-quick-actions.tsx (1)
45-53: Style the trigger viabuttonClassName.
CustomMenuapplies trigger styles throughbuttonClassName. UsingclassNameleaves the button unstyled. Mirror other quick-action components to ensure consistent UI.<CustomMenu ellipsis placement="bottom-end" closeOnSelect maxHeight="lg" - className="flex-shrink-0 flex items-center justify-center size-[26px] bg-custom-background-80/70 rounded" + buttonClassName="flex-shrink-0 flex items-center justify-center size-[26px] bg-custom-background-80/70 rounded" >apps/web/core/components/common/quick-actions-helper.tsx (3)
90-90: Inconsistent string normalization method.Line 90 uses
toLocaleLowerCase()while line 66 (cycles) usestoLowerCase(). For consistency, use the same method across both hooks unless there's a specific internationalization requirement.Apply this diff for consistency:
- const moduleState = moduleDetails?.status?.toLocaleLowerCase(); + const moduleState = moduleDetails?.status?.toLowerCase();
127-138: Simplify redundant destructuring.Line 129's
const { ...handlers } = props;doesn't exclude any fields and simply copies all props. Either destructure specific fields or usepropsdirectly.Apply this diff for cleaner code:
export const useLayoutMenuItems = (props: UseLayoutMenuItemsProps): MenuResult => { const factory = useQuickActionsFactory(); - const { ...handlers } = props; + const { handleOpenInNewTab, handleCopyLink } = props; // Assemble final menu items - order defined here const items = [ - factory.createOpenInNewTab(handlers.handleOpenInNewTab), - factory.createCopyLayoutLinkMenuItem(handlers.handleCopyLink), + factory.createOpenInNewTab(handleOpenInNewTab), + factory.createCopyLayoutLinkMenuItem(handleCopyLink), ].filter((item) => item.shouldRender !== false); return { items, modals: null }; };
140-145: Stub implementation: incomplete feature.The
useIntakeHeaderMenuItemshook is a no-op stub that returns empty items. If this is a placeholder for future implementation, consider adding a TODO comment to track it. If it's intentionally empty, document why this hook exists.Would you like me to open an issue to track the implementation of intake header menu items, or is this intentionally left empty for a specific reason?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/web/core/components/common/quick-actions-helper.tsx(1 hunks)apps/web/core/components/cycles/quick-actions.tsx(3 hunks)apps/web/core/components/issues/layout-quick-actions.tsx(1 hunks)apps/web/core/components/modules/quick-actions.tsx(3 hunks)apps/web/core/components/views/quick-actions.tsx(3 hunks)apps/web/core/components/workspace/views/quick-action.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T08:14:49.260Z
Learnt from: sriramveeraghanta
PR: makeplane/plane#7697
File: apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx:12-13
Timestamp: 2025-09-02T08:14:49.260Z
Learning: The star-us-link.tsx file in apps/web/app/(all)/[workspaceSlug]/(projects)/ already has "use client" directive at the top, making it a proper Client Component for hook usage.
Applied to files:
apps/web/core/components/issues/layout-quick-actions.tsx
📚 Learning: 2025-10-09T20:42:31.843Z
Learnt from: lifeiscontent
PR: makeplane/plane#7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.
Applied to files:
apps/web/core/components/modules/quick-actions.tsx
🧬 Code graph analysis (6)
apps/web/core/components/cycles/quick-actions.tsx (2)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useCycleMenuItems(61-83)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/views/quick-actions.tsx (2)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useViewMenuItems(110-125)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/issues/layout-quick-actions.tsx (4)
packages/utils/src/string.ts (1)
copyUrlToClipboard(66-72)packages/propel/src/toast/toast.tsx (1)
setToast(198-218)apps/web/core/components/common/quick-actions-helper.tsx (1)
useLayoutMenuItems(127-138)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/common/quick-actions-helper.tsx (5)
packages/types/src/module/modules.ts (1)
IModule(49-89)packages/types/src/views.ts (1)
IProjectView(14-35)packages/types/src/workspace-views.ts (1)
IWorkspaceView(9-33)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)apps/web/core/components/common/quick-actions-factory.tsx (1)
useQuickActionsFactory(9-82)
apps/web/core/components/modules/quick-actions.tsx (2)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useModuleMenuItems(85-108)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/workspace/views/quick-action.tsx (1)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useViewMenuItems(110-125)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Cursor Bugbot
- GitHub Check: Build and lint web apps
🔇 Additional comments (4)
apps/web/core/components/common/quick-actions-helper.tsx (4)
1-59: LGTM! Clean type definitions.The imports and type definitions are well-structured and comprehensive, providing clear contracts for each hook.
61-83: LGTM! Well-structured cycle menu logic.The permission checks and conditional rendering are correctly implemented with good UX considerations (helpful descriptions for disabled actions).
79-79: Unable to determine intent behind deletion logic difference—requesting manual verification.The code review correctly identifies a deletion logic inconsistency:
- Cycles (line 79): Delete disabled for completed items (
!isCompleted && !isArchived)- Modules (line 104): Delete enabled for completed/cancelled items (
!isArchivedonly)However, no test files, comments, or business rule documentation were found in the codebase that clarify whether this difference is intentional. The code pattern shows cycles follow an archive-first approach (completed cycles must be archived), while modules allow direct deletion regardless of completion state. Without access to product requirements or design documentation, I cannot confirm if this inconsistency is a bug or intentional design.
110-125: ****The type definition is correct. Both call sites (quick-action.tsx and quick-actions.tsx) declare
viewas a required, non-nullable prop and immediately useview.idwithout null checks. The guard in useViewMenuItems at line 114 is dead code but not indicative of a type mismatch—it's optional defensive programming. No type correction needed.Likely an incorrect or invalid review comment.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
apps/web/core/components/modules/quick-actions.tsx (1)
98-111: Guard against undefined moduleDetails before calling the hook.The non-null assertion
moduleDetails!at line 100 risks a runtime crash if the module data hasn't loaded yet. Consider early-returning a minimal fallback menu or checkingmoduleDetailsbefore invoking the hook.
🧹 Nitpick comments (1)
apps/web/core/components/common/quick-actions-helper.tsx (1)
61-138: Consider memoizing the items arrays in all menu hooks.The
itemsarrays inuseCycleMenuItems,useModuleMenuItems,useViewMenuItems, anduseLayoutMenuItemsare recalculated on every render. Wrap them withuseMemoto avoid unnecessary recomputation when dependencies haven't changed.Apply this pattern to all hooks:
+import { useMemo } from "react"; export const useModuleMenuItems = (props: UseModuleMenuItemsProps): MenuResult => { const factory = useQuickActionsFactory(); const { moduleDetails, isEditingAllowed, ...handlers } = props; const isArchived = !!moduleDetails?.archived_at; const moduleState = moduleDetails?.status?.toLocaleLowerCase(); const isInArchivableGroup = !!moduleState && ["completed", "cancelled"].includes(moduleState); - const items = [ + const items = useMemo(() => [ factory.createEditMenuItem(handlers.handleEdit, isEditingAllowed && !isArchived), factory.createOpenInNewTabMenuItem(handlers.handleOpenInNewTab), factory.createCopyLinkMenuItem(handlers.handleCopyLink), factory.createArchiveMenuItem(handlers.handleArchive, { shouldRender: isEditingAllowed && !isArchived, disabled: !isInArchivableGroup, description: isInArchivableGroup ? undefined : "Only completed or cancelled modules can be archived", }), factory.createRestoreMenuItem(handlers.handleRestore, isEditingAllowed && isArchived), factory.createDeleteMenuItem(handlers.handleDelete, isEditingAllowed && !isArchived), - ].filter((item) => item.shouldRender !== false); + ].filter((item) => item.shouldRender !== false), [ + factory, + handlers.handleEdit, + handlers.handleOpenInNewTab, + handlers.handleCopyLink, + handlers.handleArchive, + handlers.handleRestore, + handlers.handleDelete, + isEditingAllowed, + isArchived, + isInArchivableGroup, + ]); return { items, modals: null }; };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/core/components/common/quick-actions-helper.tsx(1 hunks)apps/web/core/components/modules/quick-actions.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-09T20:42:31.843Z
Learnt from: lifeiscontent
PR: makeplane/plane#7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.
Applied to files:
apps/web/core/components/modules/quick-actions.tsx
🧬 Code graph analysis (2)
apps/web/core/components/modules/quick-actions.tsx (2)
apps/web/core/components/common/quick-actions-helper.tsx (1)
useModuleMenuItems(85-108)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)
apps/web/core/components/common/quick-actions-helper.tsx (5)
packages/types/src/module/modules.ts (1)
IModule(49-89)packages/types/src/views.ts (1)
IProjectView(14-35)packages/types/src/workspace-views.ts (1)
IWorkspaceView(9-33)packages/ui/src/dropdowns/context-menu/root.tsx (1)
TContextMenuItem(10-23)apps/web/core/components/common/quick-actions-factory.tsx (1)
useQuickActionsFactory(9-82)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build and lint web apps
- GitHub Check: Cursor Bugbot
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/web/core/components/modules/quick-actions.tsx (1)
113-146: LGTM! Clean handling of menu variants and modals.The code correctly normalizes both array and object return types from the hook, and the additionalModals pattern supports future extensibility. The action wrappers at lines 119-124 properly fire the menu item actions with tracking.
apps/web/core/components/common/quick-actions-helper.tsx (2)
7-59: LGTM! Well-structured type definitions.The type definitions are clear, consistent, and properly use
typealiases. TheMenuResultstructure with optional modals supports both simple and extended use cases.
140-145: Placeholder implementation for intake header menu.The
useIntakeHeaderMenuItemshook is currently a stub returning empty items. This is fine if the functionality is planned for future implementation.Is this placeholder intentional for future work, or should it be implemented as part of this PR?
prateekshourya29
approved these changes
Dec 1, 2025
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
aaryan610
approved these changes
Dec 3, 2025
KooshaPari
added a commit
to KooshaPari/Planify
that referenced
this pull request
Mar 29, 2026
) * [PAI-963] feat: enhance CustomSelect component with context for dropdown management (makeplane#8202) * feat: enhance CustomSelect component with context for dropdown management * refactor: streamline CustomSelect component structure and improve dropdown options rendering * [WEB-5603] feat: enhance workspace settings layout and members page (makeplane#8266) * feat: enhance workspace settings layout and members page with new components * refactor: update workspace settings layout and members page to use default exports * refactor: settings layout import changes * refactor: simplify workspaceSlug usage in settings layout * [WEB-5592] chore: add static files update settings for static files support (makeplane#8251) * chore: add static files collection and update settings for static files support * chore: add WhiteNoise middleware for static file handling * chore(deps): upgrade WhiteNoise to version 6.11.0 and add static file reverse proxy in Caddyfile * [WEB-5256]chore: quick actions refactor (makeplane#8019) * chore: quick actions refactor * chore: lint fix * chore: unified factory for actions * chore: lint fix * * chore: removed redundant files * chore: updated imports * chore: updated interfaces to types * chore: updated undefined handling * [WIKI-829] fix: add option to only show placeholder on empty editor (makeplane#8232) * feat: add placeholderOnEmpty functionality to editor components * Update packages/editor/src/core/extensions/placeholder.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: rename placeholderOnEmpty to showPlaceholderOnEmpty across editor components * chore : make optional --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIKI-830] fix: copy clipboard functionality in the editor (makeplane#8229) * feat: enhance clipboard functionality for markdown and HTML content * fix: improve error handling and state management in CustomImageNodeView component * fix: correct asset retrieval query by removing workspace filter in DuplicateAssetEndpoint * fix: update meta tag creation in PasteAssetPlugin for clipboard HTML content * feat: implement copyMarkdownToClipboard utility for enhanced clipboard functionality * refactor: replace copyMarkdownToClipboard utility with copyTextToClipboard for simplified clipboard operations * refactor: streamline clipboard operations by replacing copyTextToClipboard with copyMarkdownToClipboard in editor components * refactor: simplify PasteAssetPlugin by removing unnecessary meta tag handling and streamlining HTML processing * feat: implement asset duplication processing on paste for enhanced clipboard functionality * chore:remove async from copy markdown method * chore: add paste html * remove:prevent default * refactor: remove hasChanges from processAssetDuplication return type for simplified asset processing * fix: format options-dropdown.tsx * feat: add timezone selection to workspace settings (makeplane#8248) * feat: add timezone selection to workspace onboarding, creation and settings * refactor: remove timezone selection from workspace creation and onboarding forms * [WEB-5285] feat: enhance ChangeTrackerMixin to capture changed fields on save (makeplane#8270) - Added an override for the save method in ChangeTrackerMixin to store changed fields before resetting tracking. - Implemented a new method, _reset_tracked_fields, to ensure subsequent saves detect changes relative to the last saved state. - Updated IssueComment to utilize _changes_on_save for determining changed fields, improving accuracy in tracking modifications. * [WEB-5585]chore: timeline chart refactor (makeplane#8246) * chore: timeline chart refactor * fix: format * [WEB-5575]feat: enhance APITokenLogMiddleware to support logging to MongoDB (makeplane#8241) * feat: enhance APITokenLogMiddleware to support logging to MongoDB - Added functionality to log external API requests to MongoDB, with a fallback to PostgreSQL if MongoDB is unavailable. - Implemented error handling for MongoDB connection and logging operations. - Introduced additional fields for MongoDB logs, including timestamps and user identifiers. - Refactored request logging logic to streamline the process and improve maintainability. * fix: improve MongoDB availability checks in APITokenLogMiddleware - Enhanced the logic for determining MongoDB availability by checking if the collection is not None. - Added a check for MongoDB configuration before attempting to retrieve the collection. - Updated error handling to ensure the middleware correctly reflects the state of MongoDB connectivity. * feat: implement logging functionality in logger_task for API activity - Added a new logger_task module to handle logging of API activity to MongoDB and PostgreSQL. - Introduced functions for safely decoding request/response bodies and processing logs based on MongoDB availability. - Refactored APITokenLogMiddleware to utilize the new logging functions, improving code organization and maintainability. * refactor: simplify MongoDB logging in logger_task and middleware - Removed direct dependency on MongoDB collection in log_to_mongo function, now retrieving it internally. - Updated process_logs to check MongoDB configuration before logging, enhancing error handling. - Cleaned up logger.py by removing unused imports related to MongoDB. * feat: add Celery task decorator to process_logs function in logger_task - Introduced the @shared_task decorator to the process_logs function, enabling asynchronous processing of log data. - Updated function signature to include a return type of None for clarity. * [WEB-5609] fix: extended sidebar item pin/unpin makeplane#8287 * [WEB-5608] chore: Hide "Pro" Features in Community Edition (makeplane#8288) * chore: Hide "Pro" Features in Community Edition * refactor: remove time tracking feature and simplify project features list * chore: moving star us button to the top navigation (makeplane#8289) * chore: optimize turborepo (makeplane#8286) * [WIKI-844] fix: realtime sync post vite migration with title editor sync and indexed db access (makeplane#8294) * fix: robust way to handle socket connection and read from indexeddb cache when reqd * fix: realtime sync working with failure handling * fix: title editor added * merge preview into fix/realtime-sync * check * page renderer props * lint errors * lint errors * lint errors * sanitize html * sanitize html * format fix * fix lint * [WEB-4440] fix: duplicate sequence when creating multiple workitems in rapid succession (makeplane#8298) - Replace advisory lock with transaction-level lock in Issue model save method - Updated the save method in the Issue model to use a transaction-level advisory lock for better concurrency control. - Simplified the locking mechanism by removing the explicit unlock step, as the lock is automatically released at the end of the transaction. - Maintained existing functionality for sequence and sort order management while improving code clarity. * chore: format files in API server (makeplane#8292) * chore: fix ruff checks (makeplane#8305) * fix: editor sync changes (makeplane#8306) * chore: upate function declarations * chore: formatted files * chore: fix/check tooling improvements with turbo (makeplane#8304) * fix: broken lock file * chore: add Plane sync label to github templates makeplane#8303 Co-authored-by: Pushya Mitra Thiruvooru <pushya@Pushyas-MacBook-Pro.local> * [WEB-5624] chore: added webhook translations makeplane#8312 * chore(deps): upgrade next themes package * [WEB-5654]fix: custom select selection and dropdown close makeplane#8324 * [WEB-5124] chore: intake work item toast enhancements (makeplane#8329) * [WEB-5647] chore: list layout work item identifier enhancements (makeplane#8326) * chore: file formating * [WEB-5650] feat: Enable Gitea OAuth configuration (makeplane#8325) * feat: implement OAuth configuration helper and integrate into auth forms * fix: ensure OAuth providers are disabled by default if not configured * [WEB-5602] feat: new design system (makeplane#8220) * chore: init tailwind v4 * chore: update all configs * chore: add source to parse monorepo packages * chore: combine all css files * feat: added extended colors * chore: update typography * chore: update extended color var names * refactor: remove initial spacing variable and update dark mode selector * chore: update css files * chore: update animations * chore: remove spacing tokens * fix: external css files * chore: update tailwind-merge version * chore: update font family * chore: added brief agents.md and story for new design system * chore: enhance design system documentation with rare exceptions for visual separation * chore: add fontsource package for typography * chore: material symbols font added * chore: update shadow default * chore: add stroke and outline theme vars * chore: update ring and fill colors * chore: overwrite tailwind typography tokens * chore: add high contrast mode tokens * chore: update scrollbar colors * chore: backward compatibility for buttons and placeholders * chore: add priority colors * chore: update urgent priority color * chore: update plan colors * chore: add missing utility class * chore: update height and padding classes * chore: update label colors * chore: add missing utlity * chore: add typography plugin to space app * chore: replace existing classNames with new design system tokens makeplane#8244 (makeplane#8278) * chore: update border colors * chore: update all borders * chore: update text colors * chore: update css variables * chore: update font sizes and weights * chore: update bg colors * chore: sync changes * fix: uncomment spacing-1200 variable in variables.css * chore: update primary colors * refactor: updated border to border-subtle * refactor: update various components and improve UI consistency across the application * updated classnames * updated classnames * refactor: update color-related class names to use new design system variables for consistency * chore: default automations * chore: update text sizes * chore: home and power k * chore: home and power k * chore: replace ui package button components * chore: update text sizes * chore: updated issue identifier (makeplane#8275) * refactor: top navigation and sidebar design token (makeplane#8276) * chore: update all button components (makeplane#8277) * chore: new button component * chore: update existing buttons * chore: overwrite tailwind typography tokens * fix: twMerge config + fixed cn instances * refactor: toast design token updated (makeplane#8279) * chore: update existing buttons * chore: tooltip design token updatged (makeplane#8280) * chore: moved cn utility to propel (makeplane#8281) * chore: update space app UI (makeplane#8285) * chore; update space app filters component * fix: button whitespace wrap * chore: space app votes * chore: update dropdown components * refactor: auth, onboarding, sidebar, and common component design token migration (makeplane#8291) * chore: checkbox component design token updated * chore: indicator and oauth component design token updated * chore: sidebar design token updated * chore: auth and onboarding design token updated * chore: update divider color * style: update background colors and hover effects across list components * fix: tailwind merge * refactor: toggle switch design token migration and header utility classname added (makeplane#8295) * chore: toggle component design token updated * chore: h-header utility class added * chore: updated color tokens for work item detail page (makeplane#8296) * chore: update react-day-picker UI * refactor: update button sizes and styles in filters components * refactor: breadcrumbs design token updated (makeplane#8297) * chore: update priority icon colors * refactor: updated layout variables * chore: update plan card primary CTA * Chore update editor design system (makeplane#8299) * refactor: update styles for callout, color selector, logo selector, and image uploader * refactor:fix image * chore: update settings UI * chore: updated notifications color and size tokens (makeplane#8302) * chore: update sm button border radius * fix: logo renderer * chore: icon button component * chore: remove deprecated classes * chore: remove deprecated classes * chore: update editor list spacing * fix: icon button size * chore: improvements (makeplane#8309) * chore: update cycles and modules pages * refactor: update background styles across various components to use new design system colors * fix: button type errors * chore: update modals design system (makeplane#8310) * refactor: callout bg * refactor: code bg * refactor: modal size and variant --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * chore: update next-themes * design: update billing and plans component styles and remove unused utility functions (makeplane#8313) * refactor: empty state design token migration and improvements (makeplane#8315) * fix: profile page * refactor: tabs design token updated (makeplane#8316) * chore: updated buttons and tokens for work items (makeplane#8317) * fix: adjust trial button spacing in checkout modal * chore: update add button hover state * fix: type error (makeplane#8318) * fix: type error * chore: code refactor * refactor: update button sizes and background styles in rich filters components * refactor: update editor bg * refactor: enhance Gantt chart sidebar functionality and styling - Removed unused prop from . - Updated to include new props for better block management and scrolling behavior. - Improved auto-scroll functionality for Gantt chart items. - Adjusted styles in component for consistent design. * regression: gantt design * chore: new badge component * fix: favorite star * chore: update backgroung, typography and button sizes across workspace settings general and members pages * fix: header button sizes * fix: emoji icon logo (makeplane#8323) * more fixes * chore: update settings sidebar * refactor: avatar component * chore: updated work item detail sidebar (makeplane#8327) * refactor: update link preview * fix: work item property dropdowns * fix: dropdown buttons border radius * chore: update power k translation * chore: updated profile activity design (makeplane#8328) * chore: update settings pages * chore: update work item sidebar alignments (makeplane#8330) * refactor: admin design system * chore: update page header --------- Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: VipinDevelops <vipinchaudhary1809@gmail.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> * fix: formatting * reexport types * fix: lint error --------- Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: VipinDevelops <vipinchaudhary1809@gmail.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> * [WEB-5668] fix: add fetchWorkspaceLevelProjectEntities method and update project-related fetch keys (makeplane#8347) * [SILO-783] feat: added porters and new serializer based exporter (makeplane#8335) * [WEB-5699] refactor: update styling and classnames of charts according to new design system (makeplane#8345) * refactor: update styling and class names according to new design system in charts * refactor: clean up * feat: custom theming enhancements (makeplane#8342) * [WEB-5671] chore: settings workspace members enhancements makeplane#8346 * [WEB-5666] chore: set project timezone same as workspace timezone in project (makeplane#8340) * [WEB-5614] fix: new design system consistency (makeplane#8351) * chore: tooltip enhancements * chore: project card enhancements * chore: work item card enhancements * chore: update component styles and class names for consistency across the application --------- Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WEB-5708] regression: remove material icon instances from the Space app (makeplane#8353) * chore: sync changes (makeplane#8343) * [WEB-5614] chore: work item detail and list layout enhancements makeplane#8355 * regression: replace old css vars with the new design system tokens (makeplane#8354) * chore: replace old css vars * fix: replace shadow and primary colors * chore: remove hardcoded colors * [WEB-5614] chore: custom theme on colour improvement makeplane#8356 * [WEB-5732] style: update work item detail properties UI (makeplane#8357) * [WEB-5730] fix: user mention colors makeplane#8358 * [WEB-5614] fix: empty state and padding token fixes (makeplane#8359) * [WEB-5614] chore: update component styles and class names for consistency across projects makeplane#8360 * [WEB-5614] chore: logo and icon enhancements makeplane#8362 * fix: work item property icon renderer (makeplane#8363) * [WEB-5614] fix: sidebar and label dropdown makeplane#8364 * fix: material icons font file (makeplane#8366) * [WEB-5614] chore: lucide icon code refactor makeplane#8365 * fix: nested context menu UI (makeplane#8367) * [WEB-5708] style: space app kanban card UI (makeplane#8368) * [WEB-5742] fix: input field background makeplane#8369 * [WEB-5641] chore: sub work item quick menu padding makeplane#8370 * chore: replace old classNames (makeplane#8372) * chore: update component styles and class names for consistency across the application (makeplane#8376) * [WEB-5660] [WEB-5737] fix: cycle and module sidebar makeplane#8375 * [WEB-5676] style: gantt column outline makeplane#8374 * [WEB-5614] chore: platform design token enhancements (makeplane#8373) * [WEB-5649] [WEB-5675] fix: local font files makeplane#8377 * [WEB-5614] chore: primitive token updated (makeplane#8378) * fix: tooltip imports (makeplane#8379) * [WEB-5614] chore: platform header and breadcrumb enhancements (makeplane#8383) * [WEB-5652] fix: kanban quick add UI makeplane#8382 * [WEB-5726] fix: showing an empty state on deleted work item link makeplane#8381 * fix: space app default background (makeplane#8384) * [WIKI-849] feat: debounce for mention search (makeplane#8380) * fix: font imports (makeplane#8387) * chore: platform layout enhancements (makeplane#8386) * fix: image uploader bg in light mode (makeplane#8385) * [WEB-5614] refactor: update styling and structure across various components (makeplane#8388) * fix: input fields bg (makeplane#8389) * fix: custom z-index classNames (makeplane#8395) * [WEB-5454] fix: optimize date validation logic in CycleCreateUpdateModal makeplane#8394 * [WEB-5614] chore: work item detail comment and sidebar enhancements (makeplane#8397) * [WEB-5675] chore: implement `fontsource` as the fonts library (makeplane#8398) * [WEB-5762] fix: workitem detail sidebar properties design consistency (makeplane#8400) * [WEB-5761]fix: intake spacing issue (makeplane#8399) * [WEB-5614] chore: sidebar enhancement makeplane#8401 * [WEB-5768]chore: updated comment UI makeplane#8402 * [WEB-5614] chore: package and layout enhancements makeplane#8403 * chore: update storybook dependency * [WEB-5657] feat: add synchronization configuration for multiple providers in authentication adapter (makeplane#8336) * feat: add sync functionality for OAuth providers - Implemented `check_sync_enabled` method to verify if sync is enabled for Google, GitHub, GitLab, and Gitea. - Added `sync_user_data` method to update user details, including first name, last name, display name, and avatar. - Updated configuration variables to include sync options for each provider. - Integrated sync check into the login/signup process. * feat: add sync toggle for OAuth providers in configuration forms * fix: remove default value for sync options in OAuth configuration forms * chore: delete old avatar and upload a new one * chore: update class method * chore: add email nullable * refactor: streamline sync check for multiple providers and improve avatar deletion logic * fix: ensure ENABLE_SYNC configurations default to "0" for Gitea, Github, Gitlab, and Google forms * fix: simplify toggle switch value handling in ControllerSwitch component --------- Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> * [WEB-5657] chore: synchronization configuration for multiple providers in authentication adapter makeplane#8409 * [WEB-5746]fix: workspace member modal z-index makeplane#8410 * [WEB-5773] fix: editor image full screen modal (makeplane#8413) * [WEB-5774] fix: editor nodes background colors (makeplane#8416) * [WEB-5776]chore: updated design system for alert modal makeplane#8415 * [WEB-5775] fix: mentions search on empty query makeplane#8417 * [WEB-5662][WEB-5770] fix: alignment of cycles in sidebar and layout selection dropdown button (makeplane#8414) * fix: alpha colors (makeplane#8418) * [WEB-5784] fix: truncation issue in wi properties (makeplane#8422) * fix: update background surface 2 variables in tailwind config * fix: improve layout and truncation handling in issue link and list items * docs: update readme with react router badge (makeplane#8424) Updated feature list and modified the local development section. * [WEB-5788] fix: board layout group by icon makeplane#8426 * [WEB-5792] regression: editor font family makeplane#8427 * [WIKI-740] refactor: editor table performance (makeplane#8411) * [WEB-5786] fix: updated font size for dates at Kanban card makeplane#8429 * [WEB-5772] fix: theme switch flicker (makeplane#8428) * [WEB-5784] fix: truncation of links in work items (makeplane#8430) * [WEB-5772] chore: theme switcher and editor colors enhancements (makeplane#8436) * [WEB-5772] chore: theme switcher code refactor makeplane#8438 * chore: workspace events (makeplane#8439) * chore: adding invite and joined events * chore: adding workspace create and update events * [WEB-5798] refactor: web and admin auth related components and update admin designs (makeplane#8431) * refactor: web and admin auth related components and update admin designs. * fix: format * [WEB-5581] fix: resolve logo spinner hydration and theme loading issues (makeplane#8450) - Fix hydration mismatch by lazy loading components that depend on theme - Ensure LogoSpinner renders with correct theme on initial load * [WEB-5791] fix: broken favicon in links (makeplane#8396) * fix: using base url of a redirect url * chore: internal networks check for the final_url * fix: none final_url * fix: exception handling * fix: exception handling * chore: remove unused imports * refactor: moved ip address check logic into separate function * fix: ValueError logic * [WEB-5667] fix: estimate value display in analytics makeplane#8448 * [WEB-5779] fix: handle loading state while fetching project cover image (makeplane#8419) * refactor: replace cover image handling with CoverImage component across profile and project forms * fix: extend CoverImage component to accept additional img props * Update apps/web/core/components/common/cover-image.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: handle undefined cover image URL in ProfileSidebar component --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WEB-5782]chore: migrated modals to @plane/ui (makeplane#8420) * chore: migrated modal to @plane/ui * chore: fixed spacings * [WEB-5808] chore: sidebar project list enhancements (makeplane#8451) * chore: sidebar project list enhancements * chore: code refactor * chore: code refactor * [WEB-5324] refactor: add Unified OAuth Configuration and Missing Gitea Options (makeplane#8050) * refactor: add Unified OAuth Configuration and Missing Gitea Options - Replaced the AuthenticationModes component with a more streamlined implementation using AuthenticationMethodCard. - Removed obsolete authentication modes files from the codebase. - Enhanced the AuthRoot component to utilize the new OAuth configuration hook for better management of authentication options. - Updated type definitions for instance authentication modes to reflect the new structure. * refactor: update OAuth type imports and remove obsolete types - Replaced local type imports with centralized imports from @plane/types in core, extended, and index OAuth hooks. - Removed the now redundant types.ts file as its definitions have been migrated. - Enhanced type definitions for OAuth options to improve consistency across the application. * feat: add new Gitea logo and update OAuth icon imports to use standard HTML img tags * chore: remove unused authentication logos and upgrade button component * [WEB-5574]chore: notification card refactor (makeplane#8234) * chore: notification card refactor * chore: moved base activity types to constants package * [WEB-5804] refactor: decouple filter value types from filter configurations (makeplane#8441) * [WEB-5804] refactor: decouple filter value types from filter configurations Remove value type constraints from filter configurations to support operator-specific value types. Different operators can accept different value types for the same filter property, so value types should be determined at the operator level rather than the filter level. - Remove generic value type parameter from TFilterConfig - Update TOperatorConfigMap to accept union of all value types - Simplify filter config factory signatures across all filter types - Add forceUpdate parameter to updateConditionValue method * refactor: remove filter value type constraints from filter configurations Eliminate the generic value type parameter from filter configurations to allow for operator-specific value types. This change enhances flexibility by enabling different operators to accept various value types for the same filter property. - Updated TFilterConfig and related interfaces to remove value type constraints - Adjusted filter configuration methods and types accordingly - Refactored date operator support to align with the new structure * [WEB-5785]fix: favorites icon size makeplane#8449 * [WEB-5781]chore: removed info banner for preferences makeplane#8442 * [WEB-5809] refactor: tailwind config inline variables (makeplane#8437) * refactor: actions icon migration (makeplane#8219) * chore: gitignore updated * chore: check icon added to propel package * feat: search icon migration * chore: check icon migration * chore: plus icon added to propel package * chore: code refactor * chore: plus icon migration and code refactor * chore: trash icon added to propel package * chore: code refactor * chore: trash icon migration * chore: edit icon added to propel package * chore: new tab icon added to propel package * chore: edit icon migration * chore: newtab icon migration * chore: lock icon added to propel package * chore: lock icon migration * chore: globe icon added to propel package * chore: globe icon migration * chore: copy icon added to propel package * chore: copy icon migration * chore: link icon added to propel package * chore: link icon migration * chore: link icon migration * chore: info icon added to propel package * chore: code refactor * chore: code refactor * chore: code refactor * chore: code refactor * regression: red and green color backgrounds (makeplane#8456) * [WEB-5815] chore: removed the deleted states (makeplane#8457) * Typo: database extension error message (makeplane#8461) * [WEB-5179] chore: icon utils code refactor makeplane#8458 * [WEB-5790] feat: new email templates (makeplane#8423) * chore: remove unused get_client_ip import (makeplane#8453) Remove unused import `get_client_ip` from workspace/invite.py. Identified by ruff linter (F401 error). Signed-off-by: majiayu000 <1835304752@qq.com> * [WEB-5822] fix: migrate ImagePickerPopover to Propel Tabs component and render only enabled tabs makeplane#8290 - Replace custom tab implementation with Propel Tabs - Dynamically render only enabled tabs based on configuration - Filter tabs by isEnabled property for cleaner conditional rendering - Improve tab navigation and accessibility with Propel components * chore: navigation preference enhancements (makeplane#8468) * [WEB-5472] refactor: components of project creation flow (makeplane#8462) * [WEB-857] regression: image uploader error state makeplane#8471 * [WEB-4959]chore: refactor project member page makeplane#8464 * [WEB-5472] refactor: project form makeplane#8472 * migration: added webhook version, navigation related fields and allowed_rate_limit for APIToken (makeplane#8339) * migration: added version field in webhook * chore: add max_length * chore: added product tour fields * chore: updated the migration file * chore: removed the duplicated migration file * chore: added allowed_rate_limit for api_tokens * chore: changed key feature tour to product tour * chore: added is_subscribed_to_changelog field --------- Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> * fix: correct spelling error in database.ts log message (makeplane#8452) Fix "convertion" -> "conversion" in error log message. Signed-off-by: majiayu000 <1835304752@qq.com> * [WEB-5598] refactor: streamline object creation in workspace seed task and improve error handling in workspace creation makeplane#8264 * chore: remove posthog events (makeplane#8465) * chore: remove posthog events * chore: remove event tracking * chore: lint errors * chore: minor changes based on comments * fix: type errors * Revert "[WEB-4959]chore: refactor project member page makeplane#8464" (makeplane#8476) This reverts commit c97e418. * chore: remove unused right sidebar component and clean up workspace member settings (makeplane#8477) * [WEB-5537]refactor: rename IssueUserProperty to ProjectUserProperty and update related references (makeplane#8206) * refactor: rename IssueUserProperty to ProjectUserProperty and update related references across the codebase * migrate: move issue user properties to project user properties and update related fields and constraints * refactor: rename IssueUserPropertySerializer and IssueUserDisplayPropertyEndpoint to ProjectUserPropertySerializer and ProjectUserDisplayPropertyEndpoint, updating all related references * fix: enhance ProjectUserDisplayPropertyEndpoint to handle missing properties by creating new entries and improve response handling * fix: correct formatting in migration for ProjectUserProperty model options * migrate: add migration to update existing non-service API tokens to remove workspace association * migrate: refine migration to update existing non-service API tokens by excluding bot users from workspace removal * chore: changed the project sort order in project user property * chore: remove allowed_rate_limit from APIToken * chore: updated user-properties endpoint for frontend * chore: removed the extra projectuserproperty * chore: updated the migration file * chore: code refactor * fix: type error --------- Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> Co-authored-by: sangeethailango <sangeethailango21@gmail.com> Co-authored-by: vamsikrishnamathala <matalav55@gmail.com> Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WIKI-826] chore: add unique id as key to logo selector (makeplane#8494) * [VPAT-50] chore(security): add X-Frame-Options header to nginx configuration to prevent clickjacking attacks (makeplane#8507) * [VPAT-50] chore(security): add X-Frame-Options header to nginx configuration to prevent clickjacking attacks * [SECURITY] chore: enhance nginx configuration with additional security headers * chore: updated migration file name (makeplane#8515) * chore(deps): react router upgraded * [WEB-5890] migration: added getting_started_checklist, tips, explored_feature fields on the workspace member table (makeplane#8489) * migration: added getting_started_checklist and tips field * fix: remove defaults and added explored_features field * fix: added user table migration * [WEB-5907] fix: magic code sign-in at Space app. makeplane#8552 * [WIKI-735] fix: table insert handle z-index makeplane#8545 * [WEB-5898] chore: update tailwind config makeplane#8516 * chore(deps): bump lodash-es in the npm_and_yarn group across 1 directory (makeplane#8573) Bumps the npm_and_yarn group with 1 update in the / directory: [lodash-es](https://github.com/lodash/lodash). Updates `lodash-es` from 4.17.21 to 4.17.23 - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.17.23 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [WEB-5845] chore: changing description field to description json (makeplane#8230) * chore: migrating description to description json * chore: replace description with description_json * chore: updated migration file * chore: updated the migration file * chore: added description key in external endpoint * chore: updated the migration file * chore: updated the typo --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * chore: fix typos in comments (makeplane#8553) * [GIT-61] chore: allow .md files to be uploaded (makeplane#8571) * chore: allow .md files to be uploaded * chore: allow .md files to be uploaded * [WEB-5860] [WEB-5861] [WEB-5862] style: improved settings interface (makeplane#8520) * style: improved profile settings * chore: minor improvements * style: improved workspace settings * style: workspace settings content * style: improved project settings * fix: project settings flat map * chore: add back navigation from settings pages * style: settings content * style: estimates list * refactor: remove old code * refactor: removed unnecessary line breaks * refactor: create a common component for page header * chore: add fade-in animation to sidebar * fix: formatting * fix: project settings sidebar header * fix: workspace settings sidebar header * fix: settings content wrapper scroll * chore: separate project settings features * fix: formatting * refactor: custom theme selector * refactor: settings headings * refactor: settings headings * fix: project settings sidebar padding * fix: sidebar header padding * fix: sidebar item permissions * fix: missing editable check * refactor: remove unused files * chore: remove unnecessary code * chore: add missing translations * fix: formatting * [GIT-45] fix: allow markdown file attachments (makeplane#8524) * fix: allow markdown file attachments - Add text/markdown to ATTACHMENT_MIME_TYPES - Fixes issue where .md files were rejected with 'Invalid file type' error * added the support for frontend mime type too * fix: node view renders (makeplane#8559) * fix node renders * fix handlers * fix: duplicate id * fix: pdf export (makeplane#8564) * feat: pdf export * fix: tests * fix: tests --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * migration: back migrate all product tour fields to set true (makeplane#8575) * [GIT-66] improvement: prevent disabling last enabled authentication method (makeplane#8570) * fully translated into Ukrainian language (makeplane#8579) * chore: add copyright (makeplane#8584) * feat: adding new copyright info on all files * chore: adding CI * fix: module percentage calculation (makeplane#8595) * fix: file fomatting * [SECUR-113] fix: ssrf for work item links (makeplane#8607) * [SECUR-104] fix: Arbitrary Modification of API Token Rate Limits#8612 * chore(deps): upgrade django version * [WEB-6058] chore : add logic to handle save#8614 * chore(deps): update the node pacakges * fix: type fix for description payload (makeplane#8619) * fix: type fix * fix: duplicate type fix * chore(deps): update lodash package * [WEB-6149] migration: change estimate point key max value to 50 makeplane#8620 * fix: remove ee folder from web (makeplane#8622) * chore: merge constants and services (makeplane#8623) * fix: remove constants and services * fix: formatting * fix: types check * chore: merge helpers and layouts (makeplane#8624) * fix: remove constants and services * fix: formatting * chore: merge helpers and layouts * fix: workspace disbale flag handling * chore(deps): bump cryptography (makeplane#8625) Bumps the pip group with 1 update in the /apps/api/requirements directory: [cryptography](https://github.com/pyca/cryptography). Updates `cryptography` from 44.0.1 to 46.0.5 - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@44.0.1...46.0.5) --- updated-dependencies: - dependency-name: cryptography dependency-version: 46.0.5 dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: update ASCII art in install script header (makeplane#8628) * [WEB-6038] fix: work item empty title flicker makeplane#8618 * fix: workitem description input inital load (makeplane#8617) * [WEB-6137] fix: work item peek view outside click makeplane#8610 * [SECUR-105] fix: csv injection vulnerability sanitization makeplane#8611 * [WIKI-877] fix: order of this dropdown options in pages makeplane#8563 * [WEB-5899]fix: project sort order (makeplane#8530) * fix: project sort order * chore: updated queryset for sort_order * chore: admin folder structure (makeplane#8632) * chore: admin folder structure * fix: copy right check and formatting * fix: types * i18n(ru): expand Russian translation coverage (makeplane#8603) Added missing translations for: - Profile preferences (language, timezone settings) - Account settings sections (preferences, notifications, security, api-tokens, activity) - Workspace settings (billing, exports, webhooks headings/descriptions) - Project settings (states, labels, estimates, automations headings/descriptions) - Power-K command palette (contextual actions, navigation, creation, preferences, help) - Sidebar elements (stickies, your_work, pin/unpin) - Common actions (copy_markdown, overview) - Navigation customization options * chore(deps): update axios dependency * [GIT-57 | WEB-5912] fix: app sidebar ux and responsiveness (makeplane#8560) * fix: project extended sidebar accordion ux * fix: app sidebar mobile responsiveness ux * chore: code refactor * refactor: table drag preview using decorations (makeplane#8597) * refactor: table drag preview using decorations * fix: history meta for table drag state * [WEB-5884] chore: layout loader enhancements makeplane#8500 * [WEB-1201] chore: dropdown options hierarchy improvements (makeplane#8501) * chore: sortBySelectedFirst and sortByCurrentUserThenSelected utils added * chore: members dropdown updated * chore: module dropdown updated * chore: project and label dropdown updated * chore: code refactor * [GIT-44] refactor(auth): add PASSWORD_TOO_WEAK error code (makeplane#8522) * refactor(auth): add PASSWORD_TOO_WEAK error code and update related error handling in password change flow * fix(auth): update import to use type for EAuthenticationErrorCodes in security page * Update apps/web/app/(all)/profile/security/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: updated auth error exception accross zxcvbn usages * fix: improve error handling for password strength validation and update error messages * i18n(ru): update Russian translations for stickies and automation description Added translation for 'stickies' and improved formatting of the automation description in Russian locale. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update translations.ts: issue-artifacts discoverd (makeplane#7979) * [WEB-5873] fix: user avatar ui consistency (makeplane#8495) * fix: user avatar ui consistency * chore: code refactor * [SILO-820] fix: update serializer for module detail API endpoint to use ModuleUpdateSerializer (makeplane#8496) * [VPAT-51] fix: update workspace invitation flow to use token for validation makeplane#8508 - Modified the invite link to include a token for enhanced security. - Updated the WorkspaceJoinEndpoint to validate the token instead of the email. - Adjusted the workspace invitation task to generate links with the token. - Refactored the frontend to handle token in the invitation process. Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * [WEB-5871] chore: added intake count for projects (makeplane#8497) * chore: add intake_count in project list endpoint * chore: sidebar project navigation intake count added * fix: filter out closed intake issues in the count * chore: code refactor * chore: code refactor * fix: filter out deleted intake issues --------- Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WEB-5829] fix: Intake open work count (makeplane#8547) * fix: open intake count at sidebar header * chore: reverted inbox store arguments to core store * fix: intake count update * [WEB-5863] fix: estimate point input validation makeplane#8492 Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * [VPAT-55] chore(security): implement input validation across authentication and workspace forms (makeplane#8528) * chore(security): implement input validation across authentication and workspace forms - Add OWASP-compliant autocomplete attributes to all auth input fields - Create centralized validation utilities blocking injection-risk characters - Apply validation to names, display names, workspace names, and slugs - Block special characters: < > ' " % # { } [ ] * ^ ! - Secure sensitive input fields across admin, web, and space apps * chore: add missing workspace name validation to settings and admin forms * feat: enhance validation regex for international names and usernames - Updated regex patterns to support Unicode characters for person names, display names, company names, and slugs. - Improved validation functions to block injection-risk characters in names and slugs. * [VPAT-16] improvement: add file validation to prevent malicious uploads makeplane#8493 Add client-side checks for double extensions, dangerous file types, dot files, and path traversal patterns. Addresses security audit recommendations for file upload validation. * [WEB-5827] fix: persist external cover image URLs (Unsplash) in project updates makeplane#8482 * [VPAT-27] chore(security): disable autocomplete on sensitive input fields makeplane#8517 Disable autocomplete on authentication and security-related forms to prevent browsers from storing sensitive credentials. This affects sign-in, password reset, account security, and onboarding forms across admin, web, and space apps. Modified components: - Auth forms (email, password, unique code, forgot/reset/set password) - Account security pages - Instance setup and profile onboarding - Shared UI components (auth-input, password-input) * [WEB-5917] fix: generate clean plain text from HTML email template makeplane#8535 * [WEB-5878] chore: add validation for project name/identifier for special characters (makeplane#8529) * chore: update ProjectSerializer to raise validation for special characters in name and identifier * chore: update external endpoints * fix: external api serializer validation * update serializer to send error code * fix: move the regex expression to Project model * [WEB-6194]migration: added archived_at in IssueView makeplane#8641 * migration: added archived_at in IssueView * fix: lint * fix: IDOR Vulnerabilities in Asset & Attachment Endpoints (makeplane#8644) * fix: idor issues in project assets and issue attachements * fix: comments * fix: Member Information Disclosure via Public Endpoint makeplane#8646 * chore: Add forum link and remove discord link on readme (makeplane#8655) * Update README to remove Discord and add Forum link Removed Discord badge and replaced Releases link with Forum link. * Fix forum link in README.md * fix: Update healthcheck endpoint in Dockerfile to target /spaces/ path (makeplane#8674) * Change Dependabot update interval from weekly to daily * [WIKI-887] fix: add scroll in heading layout (makeplane#8596) * fix: add scroll in heading layout * chore: remove visible scroll bar * fix :format * chore: fix outline scroll * chore: fix format * chore: fix translation --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * fix: merge lists in editor (makeplane#8639) * chore: replace prettier with oxfmt (makeplane#8676) * fix: replace eslint with oxlint (makeplane#8677) * fix: replace eslint with oxlint * chore: adding max warning * fix: formatting * chore(deps): minimatch and rollup package vulnerabilities (makeplane#8675) * fix: package updates * fix: package upgrades * fix: minimatch package vulnerabilities * fix: ajv package vulnerabilities * fix: lint * fix: format * [SILO-1028] feat: Project Summary external API (makeplane#8661) * add project summary endpoint * update response structure * [WIKI-852] chore: update page version save logic (makeplane#8440) * chore: updated the logic for page version task * chore: updated the html variable * chore: handled the exception * chore: changed the function name * chore: added a custom variable * [WEB-5225] feat: enhance authentication logging with detailed error and info message (makeplane#7998) * feat: enhance authentication logging with detailed error and info messages - Added logging for various authentication events in the Adapter and its subclasses, including email validation, user existence checks, and password strength validation. - Implemented error handling for GitHub OAuth email retrieval, ensuring proper logging of unexpected responses and missing primary emails. - Updated logging configuration in local and production settings to include a dedicated logger for authentication events. * chore: address copilot comments * chore: addressed some additional comments * chore: update log * fix: lint * [WEB-6420] chore: migrate community references from Discord to Forum (makeplane#8657) * chore: replace Discord references with Forum links * chore: migrate help and community CTAs from Discord to Forum * refactor: replace Discord icons with lucide MessageSquare * chore: rename Discord labels and keys to Forum * chore: remove obsolete Discord icon component * chore: update Discord references to Forum in templates * chore: code refactoring * fix: dependabot and codeql CI * fix: disable react-in-jsx-scope rule in oxlint config (makeplane#8682) After makeplane#8677 replaced ESLint with OxLint, the react-in-jsx-scope rule was not disabled. This causes all commits touching JSX files to fail the pre-commit hook (oxlint --deny-warnings). React 17+ uses automatic JSX runtime so explicit React imports are not required. Fixes makeplane#8681 * chore: space folders (makeplane#8707) * chore: change the space folders structure * fix: format * chore(deps): django version upgrade * [GIT-40]fix: apply sub-issue display filter when adding work items makeplane#8534 * [WEB-5606] fix: work item preview word break makeplane#8537 * [WIKI-892] fix: description input component re-render makeplane#8600 * [WIKI-785] refactor: editor markdown handler makeplane#8546 * [WEB-5911] fix: error outline button text color makeplane#8531 * [SECUR-116] fix: ssrf webhook url for ip address makeplane#8716 * [WEB-6420] chore: self-host social icons in project invitation email (makeplane#8718) * chore: add self-hosted social icon assets for email templates * chore: pass current_site to project invitation email context * chore: replace mailinblue CDN icons with self-hosted static assets * feat: Complete Agent and Worktrees modules - Add Agent CRUD API and frontend - Add Worktrees page with CRUD - Add extended routes for /agents and /worktrees - Add custom sidebar navigation --------- Signed-off-by: majiayu000 <1835304752@qq.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: pratapalakshmi <137189067+pratapalakshmi@users.noreply.github.com> Co-authored-by: b-saikrishnakanth <130811169+b-saikrishnakanth@users.noreply.github.com> Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Vipin Chaudhary <VipinChaudhary1809@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> Co-authored-by: Dheeraj Kumar Ketireddy <dheeraj.ketireddy@plane.so> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: Aaron <lifeiscontent@users.noreply.github.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> Co-authored-by: pushya22 <130810100+pushya22@users.noreply.github.com> Co-authored-by: Pushya Mitra Thiruvooru <pushya@Pushyas-MacBook-Pro.local> Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: Henit Chobisa <chobisa.henit@gmail.com> Co-authored-by: Sangeetha <sangeethailango21@gmail.com> Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> Co-authored-by: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com> Co-authored-by: Shaikh Naasir <yoursdeveloper@protonmail.com> Co-authored-by: lif <1835304752@qq.com> Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> Co-authored-by: vamsikrishnamathala <matalav55@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> Co-authored-by: yy <yhymmt37@gmail.com> Co-authored-by: punto <119956578+AshrithSathu@users.noreply.github.com> Co-authored-by: Ship it <161483884+vcscroll@users.noreply.github.com> Co-authored-by: Akshat Jain <akshatjain9782@gmail.com> Co-authored-by: stelmsk <151884118+stelmsk@users.noreply.github.com> Co-authored-by: Cornelius <70640137+conny3496@users.noreply.github.com> Co-authored-by: Vihar Kurama <vihar.kurama@gmail.com> Co-authored-by: Saurabh Kumar <70131915+Saurabhkmr98@users.noreply.github.com> Co-authored-by: darkingtail <51188676+darkingtail@users.noreply.github.com> Co-authored-by: Claude Code <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update refactors quick actions for a better reusability at these layouts:
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
New Features
Refactor
Chores
Note
Introduces a shared quick‑actions factory and helper hooks, refactoring cycles, modules, project/workspace views, and issues/epics layouts to use the unified API while removing obsolete CE hooks/exports.
useQuickActionsFactoryproviding creators foredit,open-new-tab,copy-link,archive,restore,delete(with descriptions/disabled states) incore/components/common/quick-actions-factory.tsx.core/components/common/quick-actions-helper.tsx:useCycleMenuItems,useModuleMenuItems,useViewMenuItems,useLayoutMenuItems(plususeIntakeHeaderMenuItemsplaceholder).core/components/cycles/quick-actions.tsxto useuseCycleMenuItems; wire modals via handlers; remove inline menu assembly and end‑cycle usage.core/components/modules/quick-actions.tsxto useuseModuleMenuItems; replace inline context menu logic.core/components/views/quick-actions.tsxto useuseViewMenuItems; integrate with publish item.core/components/workspace/views/quick-action.tsxto useuseViewMenuItemsand renderitems.core/components/issues/layout-quick-actions.tsxusinguseLayoutMenuItemsfor open/copy actions.useQuickActionsFactoryfromce/components/common/quick-actions-factory.tsx.ce/components/cycles/end-cycle/use-end-cycle.tsxand its export; keep onlymodalexport.ce/components/views/helper.tsxto minimal placeholders; remove old menu factory/hooks.Written by Cursor Bugbot for commit cd741d8. This will update automatically on new commits. Configure here.