[WEB-5907]fix: magic code sign-in at Space app.

[vamsikrishnamathala]

Description

This update fixes the Magic code sign-in method for users at space app. App will now use magic code sign-in for users signed up with the same.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

• Refactor
  • Improved authentication flow validation for magic link login to ensure proper status verification before proceeding.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The authentication flow now includes status-based routing. The sign-in and sign-up components check the response status field to determine whether to proceed with magic code authentication or credential-based authentication, while the email check response type definition adds the corresponding status field.

Changes

Cohort / File(s)	Summary
Authentication Type Definition apps/space/core/types/auth.ts	Added required status property to IEmailCheckResponse interface with union type "MAGIC_CODE" | "CREDENTIAL" to support status-based routing decisions.
Authentication Flow Logic apps/space/core/components/account/auth-forms/auth-root.tsx	Modified sign-in and sign-up conditional logic to check response.status === "MAGIC_CODE" alongside SMTP and magic login configuration before proceeding to unique code flow; added early return to prevent fall-through logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Status flows like morning dew,
MAGIC_CODE or CREDENTIAL true,
Routes now branch by what we find,
Auth flows dance with types aligned! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references the specific bug being fixed (magic code sign-in) and the target system (Space app), directly matching the main changes.
Description check	✅ Passed	The description includes the required sections with appropriate detail for a bug fix, though test scenarios and references are missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa1b4a1 and f7f756d.

📒 Files selected for processing (2)

• apps/space/core/components/account/auth-forms/auth-root.tsx
• apps/space/core/types/auth.ts

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• apps/space/core/types/auth.ts
• apps/space/core/components/account/auth-forms/auth-root.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Enable TypeScript strict mode and ensure all files are fully typed

Files:

• apps/space/core/types/auth.ts
• apps/space/core/components/account/auth-forms/auth-root.tsx

**/*.{js,jsx,ts,tsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with Tailwind plugin for code formatting, run pnpm fix:format

Files:

• apps/space/core/types/auth.ts
• apps/space/core/components/account/auth-forms/auth-root.tsx

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately

Files:

• apps/space/core/types/auth.ts
• apps/space/core/components/account/auth-forms/auth-root.tsx

🧠 Learnings (1)

📚 Learning: 2025-07-14T11:22:43.964Z

Learnt from: gakshita
Repo: makeplane/plane PR: 7393
File: apps/admin/app/(all)/(dashboard)/email/email-config-form.tsx:104-104
Timestamp: 2025-07-14T11:22:43.964Z
Learning: In the Plane project's SMTP configuration implementation, the email configuration form (email-config-form.tsx) hardcodes ENABLE_SMTP to "1" in form submission because the form is only rendered when SMTP is enabled. The enable/disable functionality is managed at the page level (page.tsx) with a toggle, and the form only handles configuration details when SMTP is already enabled.

Applied to files:

• apps/space/core/components/account/auth-forms/auth-root.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build packages
• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

apps/space/core/types/auth.ts (1)

21-23: Looks good — just verify the new status field is always present.

Since status is now required, please confirm all emailCheck responses (including fixtures/tests and self-hosted environments) include it to avoid runtime fallbacks for magic-code users.

apps/space/core/components/account/auth-forms/auth-root.tsx (1)

100-123: Nice gating of magic-code flow by status — please verify fallback behavior.

Anything other than "MAGIC_CODE" now routes to password/error; confirm this is acceptable for older/self-hosted servers that might omit status, or consider a defensive default if backward compatibility is needed.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[makeplane]

Linked to Plane Work Item(s)

• [WEB-5907] Password field appears on re-login for users without a password after signing out from a published project

This comment was auto-generated by Plane