Deprecate MapboxModuleType.NavigationRouter #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I believe it was the only place that used Nav SDK. Maybe it makes sense to remote the dependency?
Contributor
Author
There was a problem hiding this comment.
We can't remove - TripNotification from Nav SDK is used in unit tests
There was a problem hiding this comment.
Do you think it makes sense migrate unit test to use Nav SDK v3 instead of v2?
Contributor
Author
There was a problem hiding this comment.
I think so - let's cut a ticket for that
annotations/src/main/java/com/mapbox/annotation/module/MapboxModuleType.kt
Outdated
Show resolved
Hide resolved
DSamaryan
force-pushed
the
ds/deprecate-navigation-router-module-type
branch
from
52e621d to
05b7736
Compare
DSamaryan
force-pushed
the
ds/deprecate-navigation-router-module-type
branch
from
05b7736 to
d7d7556
Compare
VysotskiVadim
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to overwrite the router through modular setup has been removed in Core Framework (Navigation SDK v3)