Skip to content

Deprecate MapboxModuleType.NavigationRouter #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DSamaryan merged 1 commit into from
Mar 22, 2024
Merged

Deprecate MapboxModuleType.NavigationRouter #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions annotations/src/main/java/com/mapbox/annotation/module/MapboxModuleType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ enum class MapboxModuleType(
/**
* Main router used by the Navigation SDK.
*/
@Deprecated("Core Navigation Framework doesn't use a custom router implementation so it will not overwrite the built-in router in Core Navigation Framework anymore")
NavigationRouter("Router", "com.mapbox.navigation.base.route", "Router"),

/**
Expand Down
28 changes: 0 additions & 28 deletions examples/src/main/java/com/mapbox/common/examples/MyRouter.kt
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions examples/src/test/java/com/mapbox/common/examples/ModuleProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import com.mapbox.common.module.provider.MapboxModuleProvider
import com.mapbox.common.module.provider.ModuleProviderArgument
import com.mapbox.maps.module.MapTelemetry
import com.mapbox.module.Mapbox_MapTelemetryModuleConfiguration
import com.mapbox.navigation.base.route.Router
import com.mapbox.navigation.base.trip.notification.TripNotification
import io.mockk.mockk
import org.hamcrest.core.IsEqual
Expand All @@ -34,12 +33,6 @@ class ModuleProviderTest {
assertNotNull(logger)
}

@Test
fun nested_module_dependencies() {
val router: Router = MapboxModuleProvider.createModule(MapboxModuleType.NavigationRouter, ::paramsProvider)
assertNotNull(router)
}

@Test
fun generate_configuration() {
Mapbox_MapTelemetryModuleConfiguration.moduleProvider = object : Mapbox_MapTelemetryModuleConfiguration.ModuleProvider {
Expand Down