Directions junction view api #1097

kmadsen · 2020-01-07T23:12:37Z

Adding support for junction views in the directions api https://github.com/mapbox/navigation-sdks/issues/194

Example banner instructions response which includes the view

"bannerInstructions": [
  {
    "distanceAlongGeometry": 82.8,
    "primary": ...,
    "secondary": ...,
    "view": {
      "text": "",
      "components": [
        {
          "text": "",
          "type": "guidance-view",
          "imageURL": "https://api-turn-here-staging-451578336.us-east-1.elb.amazonaws.com/guidance-views/v1/z/jct/CA075101?arrow_ids=CA07510E"
        }
      ],
      "type": "off ramp",
      "modifier": "right"
    }
  }
]
},

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

langsmith · 2020-01-08T16:27:31Z

Replace REPLACE_VERSION_KYLE with the version (i think it's 4.10)

This will be a part of a semver major release, so it'll be 5.0.0

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerComponents.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerComponents.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerInstructions.java

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

sonatype-lift · 2020-01-08T22:30:25Z

Muse analysis has completed. New issues were detected with line numbers outside of the pull request change set:

(AutoValueImmutableFields)[https://github.com/mapbox/mapbox-java/blob/f379c5fe936648bdfc3ac42db4b61fa217a116dd/services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java#L52]: AutoValue instances should be deeply immutable. Therefore, we recommend returning ImmutableList instead. Read more at http://goo.gl/qWo9sC

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

langsmith · 2020-01-08T22:55:13Z

Awesome work and welcome to Mapbox Java! 😄

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java

Guardiola31337 · 2020-01-09T09:27:39Z

...s-directions/src/test/java/com/mapbox/api/directions/v5/models/JunctionViewResponseTest.java

+    String jsonString = responseFromJson1.toJson();
+    BannerInstructions responseFromJson2 = BannerInstructions.fromJson(jsonString);
+
+    Assert.assertEquals(responseFromJson1, responseFromJson2);


NIT

assertEquals(responseFromJson1, responseFromJson2);

Guardiola31337 · 2020-01-09T09:30:20Z

...s-directions/src/test/java/com/mapbox/api/directions/v5/models/JunctionViewResponseTest.java

+  }
+
+  @Test
+  public void fromtestToFromJson() {


Typo *fromtestToFromJson

Guardiola31337 · 2020-01-09T09:33:43Z

...s-directions/src/test/java/com/mapbox/api/directions/v5/models/JunctionViewResponseTest.java

+
+  @Test
+  public void fromtestToFromJson() {
+    BannerInstructions responseFromJson1 = BannerInstructions.fromJson(BANNER_INSTRUCTION_JSON);


Minor thing

Could we improve naming here? Especially responseFromJson1 and responseFromJson2 😬

Guardiola31337 · 2020-01-09T09:34:02Z

...s-directions/src/test/java/com/mapbox/api/directions/v5/models/JunctionViewResponseTest.java

+  }
+
+  @Test
+  public void fromtestToFromJson() {


Minor thing Could we rename the test so it's clearer (although not consistently applied 👀 at the "naming" convention of the rest of the tests)? We should also remove test prefix from tests names, it's implicit with the usage of @Test annotation.

Just noticed these comments and agree with the nits. I'm not ignoring.

Think these were copy pasted so larger clean ups will happen during free time :)

Guardiola31337 · 2020-01-09T09:35:31Z

...s-directions/src/test/java/com/mapbox/api/directions/v5/models/JunctionViewResponseTest.java

+    BannerInstructions responseFromJson = BannerInstructions.fromJson(BANNER_INSTRUCTION_JSON);
+
+    BannerView bannerView = responseFromJson.view();
+    Assert.assertEquals(bannerView.text(), "CA01610_1_E");


Same as above re: Assert.assertEquals vs assertEquals

Kyle Madsen added 7 commits January 7, 2020 14:11

Add junction view api to directions

f51e5d4

style fails

bfd5a93

imports

717f1e4

test the tests

3778466

add components

2ad0056

test utils wont work locally

7a0a5c4

find replace version tag

7871fe6

sonatype-lift bot reviewed Jan 7, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

remove

97bb4bf

sonatype-lift bot reviewed Jan 7, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

update version

90933d6

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

add imageURL parameter

c4230dd

langsmith reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerComponents.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

langsmith reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerComponents.java Outdated Show resolved Hide resolved

another description

5c3780a

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

danpaz reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerInstructions.java Outdated Show resolved Hide resolved

Kyle Madsen added 3 commits January 8, 2020 11:36

update description

80a3531

update comment

6edfd1c

remove new line

aa54ecd

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

langsmith reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

kmadsen mentioned this pull request Jan 8, 2020

Add banner component type #1098

Merged

langsmith added the Ready For Review label Jan 8, 2020

remove line

8cfb1f0

Merge branch 'master' into kyle/directions-junction-view-api

761bf4c

kmadsen force-pushed the kyle/directions-junction-view-api branch from f379c5f to 761bf4c Compare January 8, 2020 22:29

add guidance view type

a027edc

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

Kyle Madsen added 2 commits January 8, 2020 14:36

remove new line

d5fd7a3

what

3306864

mapbox deleted a comment from sonatype-lift bot Jan 8, 2020

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

langsmith approved these changes Jan 8, 2020

View reviewed changes

Kyle Madsen added 2 commits January 8, 2020 14:55

improve test

95a8f92

wrong version

b91fcaf

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

sonatype-lift bot reviewed Jan 8, 2020

View reviewed changes

services-directions/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java Show resolved Hide resolved

kmadsen merged commit 93da3e6 into master Jan 8, 2020

langsmith deleted the kyle/directions-junction-view-api branch January 8, 2020 23:18

langsmith mentioned this pull request Jan 8, 2020

Release 5.0.0 #1100

Closed

15 tasks

Guardiola31337 reviewed Jan 9, 2020

View reviewed changes

kmadsen mentioned this pull request Jan 9, 2020

Bumped Java SDK dependency to 5.0.0 mapbox/mapbox-navigation-android#2352

Merged

10 tasks

Directions junction view api #1097

Directions junction view api #1097

Uh oh!

Conversation

kmadsen commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

langsmith commented Jan 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonatype-lift bot commented Jan 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

langsmith commented Jan 8, 2020

Uh oh!

Uh oh!

Uh oh!

Guardiola31337 Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

Guardiola31337 Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

Guardiola31337 Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

Guardiola31337 Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

kmadsen Jan 11, 2020

Choose a reason for hiding this comment

Uh oh!

Guardiola31337 Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kmadsen commented Jan 7, 2020 •

edited

Loading