Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Jan 9, 2020

Description

Bumps mapbox-java version to 5.0.0.

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Getting the latest version to include Direction API changes needed for Junction Views
mapbox/mapbox-java#1097

Implementation

Bumping all dependencies of mapbox-java to 5.0.0 in dependencies.gradle

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@kmadsen kmadsen force-pushed the kyle/update-mapbox-sdk-services branch from f36016b to eb17930 Compare January 9, 2020 00:54
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #2352 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2352      +/-   ##
============================================
- Coverage     32.77%   32.73%   -0.04%     
  Complexity      624      624              
============================================
  Files           143      143              
  Lines          5547     5541       -6     
  Branches        427      427              
============================================
- Hits           1818     1814       -4     
+ Misses         3533     3532       -1     
+ Partials        196      195       -1

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we went over the Testing checks from the PR template?

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other than that, code-wise looks good to me 👍

@kmadsen kmadsen added this to the v1.0.0 milestone Jan 9, 2020
@kmadsen kmadsen merged commit af0a394 into master Jan 9, 2020
@kmadsen kmadsen deleted the kyle/update-mapbox-sdk-services branch January 9, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants